Re: [edk2-devel] [Patch 1/3] BaseTools: Improve GetDependencyList function

2019-09-19 Thread Liming Gao
Bob: I find this patch will cause the dependent header files not be listed in module Makefile. Then, it will cause the incremental build issue. I don't think this is a good fix. I will send the patch to revert this change. Thanks Liming > -Original Message- > From: Feng, Bob C

[edk2-devel] [Patch 1/3] BaseTools: Improve GetDependencyList function

2019-09-10 Thread Bob Feng
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2102 GetDependencyList get the header file via re.findall in the whole header file. This patch is to pre-process the header file and to feed the shorter string to re.findall. This patch is to improve GetDependencyList() efficiency Cc: Liming G