Re: [edk2-devel] [Patch 3/3] BaseTools/PatchCheck: Disable text conversion in 'git show'

2019-08-08 Thread Laszlo Ersek
>>> mailto:jordan.l.jus...@intel.com>>; Kinney, >>> Michael D >>> mailto:michael.d.kin...@intel.com>> >>> Cc: Feng, Bob C mailto:bob.c.f...@intel.com>>; Gao, >>> Liming >>> mailto:liming@intel.com>> >>> Sub

Re: [edk2-devel] [Patch 3/3] BaseTools/PatchCheck: Disable text conversion in 'git show'

2019-08-08 Thread Andrew Fish via Groups.Io
gt; Cc: Feng, Bob C mailto:bob.c.f...@intel.com>>; Gao, >> Liming >> mailto:liming@intel.com>> >> Subject: Re: [edk2-devel] [Patch 3/3] >> BaseTools/PatchCheck: Disable text conversion in 'git >> show' >> >> On 08/07/19 21:42, Jordan Ju

Re: [edk2-devel] [Patch 3/3] BaseTools/PatchCheck: Disable text conversion in 'git show'

2019-08-08 Thread Michael D Kinney
> To: devel@edk2.groups.io; Justen, Jordan L > ; Kinney, Michael D > > Cc: Feng, Bob C ; Gao, Liming > > Subject: Re: [edk2-devel] [Patch 3/3] > BaseTools/PatchCheck: Disable text conversion in 'git > show' > > On 08/07/19 21:42, Jordan Justen wrote:

Re: [edk2-devel] [Patch 3/3] BaseTools/PatchCheck: Disable text conversion in 'git show'

2019-08-08 Thread Laszlo Ersek
On 08/07/19 21:42, Jordan Justen wrote: > I thought adding Laszlo's settings > to .gitattributes might amount to solving two issues with one change. Independently of the present patch, I would be very much in favor of tracking a .gitattributes file in the project root dir, *if* we could also

Re: [edk2-devel] [Patch 3/3] BaseTools/PatchCheck: Disable text conversion in 'git show'

2019-08-07 Thread Jordan Justen
On 2019-08-05 15:01:14, Kinney, Michael D wrote: > Laszlo, > > The context of this change is only to the PatchCheck.py tool. > and how that tool uses git show. > > I agree with the summary of very flexible capabilities in git > to help developers review different types of files. All of > those

Re: [edk2-devel] [Patch 3/3] BaseTools/PatchCheck: Disable text conversion in 'git show'

2019-08-07 Thread Laszlo Ersek
rom: devel@edk2.groups.io >> [mailto:devel@edk2.groups.io] On Behalf Of Laszlo Ersek >> Sent: Friday, August 2, 2019 4:58 PM >> To: Justen, Jordan L ; >> Kinney, Michael D ; >> devel@edk2.groups.io >> Cc: Feng, Bob C ; Gao, Liming >> >> Subject: Re: [

Re: [edk2-devel] [Patch 3/3] BaseTools/PatchCheck: Disable text conversion in 'git show'

2019-08-05 Thread Michael D Kinney
.io > Cc: Feng, Bob C ; Gao, Liming > > Subject: Re: [edk2-devel] [Patch 3/3] > BaseTools/PatchCheck: Disable text conversion in 'git > show' > > On 08/02/19 20:29, Jordan Justen wrote: > > First, I hope we don't add lots of large .pdf files > into the source >

Re: [edk2-devel] [Patch 3/3] BaseTools/PatchCheck: Disable text conversion in 'git show'

2019-08-02 Thread Laszlo Ersek
On 08/02/19 20:29, Jordan Justen wrote: > First, I hope we don't add lots of large .pdf files into the source > tree. I see two duplicated > 200k .pdf files in edk2, which seems like > a waste of space in the edk2 tree. > >

Re: [edk2-devel] [Patch 3/3] BaseTools/PatchCheck: Disable text conversion in 'git show'

2019-08-02 Thread Jordan Justen
First, I hope we don't add lots of large .pdf files into the source tree. I see two duplicated > 200k .pdf files in edk2, which seems like a waste of space in the edk2 tree. BaseTools/Source/C/BrotliCompress/docs/brotli-comparison-study-2015-09-22.pdf