b C
>; Andrew Fish ; Laszlo Ersek
>
>Subject: RE: [edk2-devel] [Patch v3] BaseTools: Fix GCC compiler failure in
>new added tools.
>
>Liming,
>
>I agree that edk2-staging is a good place to work on cleaning
>these tools up.
>
>Please revert the commit of these tools toda
On Wed, Jul 10, 2019 at 01:42:44PM +, Liming Gao wrote:
> > > - strncat (LocalStr, "[attributes] \n", sizeof("[attributes] \n"));
> > > + strncat (LocalStr, "[attributes] \n", STR_LEN_MAX_4K - strlen
> > > (LocalStr) - 1);
> >
> > This is a very inefficient, and difficult to read, way of
k2.groups.io; leif.lindh...@linaro.org
> Cc: Gao, Zhichao ; Feng, Bob C
> ; Andrew Fish ;
> Laszlo Ersek ; Kinney, Michael D
>
> Subject: RE: [edk2-devel] [Patch v3] BaseTools: Fix GCC
> compiler failure in new added tools.
>
> Lefi:
>
> > -Origina
> ; Kinney, Michael D
> Subject: Re: [edk2-devel] [Patch v3] BaseTools: Fix GCC compiler failure in
> new added tools.
>
> Hi Liming,
>
> On Tue, Jul 09, 2019 at 05:53:33PM +0800, Liming Gao wrote:
> > From: gaozhic
> >
> > GCC 7 or 8 reports some warnings
Hi Liming,
On Tue, Jul 09, 2019 at 05:53:33PM +0800, Liming Gao wrote:
> From: gaozhic
>
> GCC 7 or 8 reports some warnings in new added FCE/FMMT/BlmLib.
Please list the specific warnings addressed.
(But also see my comments below - I think this utility needs ripping
out and rewriting.)
>
On Tue, Jul 09, 2019 at 05:53:33PM +0800, Liming Gao wrote:
> From: gaozhic
>
> GCC 7 or 8 reports some warnings in new added FCE/FMMT/BlmLib.
>
> Signed-off-by: Liming Gao
> Cc: Bob Feng
> ---
> In V2:
> Fix GCC8 compiler issue.
>
> In V3:
> Fix snprintf wrong replacement.
>
>
From: gaozhic
GCC 7 or 8 reports some warnings in new added FCE/FMMT/BlmLib.
Signed-off-by: Liming Gao
Cc: Bob Feng
---
In V2:
Fix GCC8 compiler issue.
In V3:
Fix snprintf wrong replacement.
BaseTools/Source/C/BfmLib/BfmLib.c | 117 +++--
