Re: [edk2-devel] [RFC][PATCH 0/2][edk2-redfish-client]: tune uncrustify script

2023-10-03 Thread Nickle Wang via groups.io
Patch set Reviewed-by: Nickle Wang mailto:nick...@nvidia.com>> Hi @Mike Maslenkin, could you please add Abner and my Reviewed-by to two commit messages in this PR? https://github.com/tianocore/edk2-redfish-client/pull/53 And then I will merge this pull

Re: [edk2-devel] [RFC][PATCH 0/2][edk2-redfish-client]: tune uncrustify script

2023-10-01 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Patch set Reviewed-by: Abner Chang > -Original Message- > From: Mike Maslenkin > Sent: Saturday, September 30, 2023 6:24 AM > To: devel@edk2.groups.io > Cc: Chang, Abner ; nick...@nvidia.com; > ig...@ami.com; Mike Maslenkin > Subject: [RFC][PATCH

[edk2-devel] [RFC][PATCH 0/2][edk2-redfish-client]: tune uncrustify script

2023-09-29 Thread Mike Maslenkin
Please, look at these changes. I've had some troubles when tried to run uncrustify checks locally on macOS and those fixes helped me. Also I tried this set on Linux and it worked. Here is a link to PR: https://github.com/tianocore/edk2-redfish-client/pull/53 Cc: Abner Chang Cc: Nickle Wang Cc: