Re: [edk2-devel] [RFC PATCH] OvmfPkg/OvmfXen: set PcdAcpiS3Enable at initialization

2021-07-27 Thread Anthony PERARD via groups.io
On Wed, Jul 21, 2021 at 02:56:46PM +0800, Gary Lin wrote: > BTW, it seems to me that QEMU fwcfg is only used for Xen Direct Kernel > Boot. However, per xl.cfg manpage, it's possible to turn on or off S3 > support by setting "acpi_s3" in xl.cfg, but PcdAcpiS3Enable wasn't set > in the current

Re: [edk2-devel] [RFC PATCH] OvmfPkg/OvmfXen: set PcdAcpiS3Enable at initialization

2021-07-21 Thread Gary Lin via groups.io
On Tue, Jul 20, 2021 at 02:52:12PM +0800, Gary Lin via groups.io wrote: > On Mon, Jul 19, 2021 at 05:07:21PM +0100, Anthony PERARD wrote: > > It would have been nice to have this patch in a patch series with > > "OvmfPkg/OvmfXen: add QemuKernelLoaderFsDxe", mostly to make it simpler > > to

Re: [edk2-devel] [RFC PATCH] OvmfPkg/OvmfXen: set PcdAcpiS3Enable at initialization

2021-07-20 Thread Gary Lin via groups.io
On Mon, Jul 19, 2021 at 05:07:21PM +0100, Anthony PERARD wrote: > It would have been nice to have this patch in a patch series with > "OvmfPkg/OvmfXen: add QemuKernelLoaderFsDxe", mostly to make it simpler > to understand the problem needed to be fixed. > To be honest, I don't have Xen

Re: [edk2-devel] [RFC PATCH] OvmfPkg/OvmfXen: set PcdAcpiS3Enable at initialization

2021-07-19 Thread Ard Biesheuvel
On Mon, 19 Jul 2021 at 18:07, Anthony PERARD wrote: > > It would have been nice to have this patch in a patch series with > "OvmfPkg/OvmfXen: add QemuKernelLoaderFsDxe", mostly to make it simpler > to understand the problem needed to be fixed. > > On Thu, Jul 08, 2021 at 12:05:49PM +0800, Gary

Re: [edk2-devel] [RFC PATCH] OvmfPkg/OvmfXen: set PcdAcpiS3Enable at initialization

2021-07-19 Thread Anthony PERARD via groups.io
It would have been nice to have this patch in a patch series with "OvmfPkg/OvmfXen: add QemuKernelLoaderFsDxe", mostly to make it simpler to understand the problem needed to be fixed. On Thu, Jul 08, 2021 at 12:05:49PM +0800, Gary Lin wrote: > There are several functions in OvmfPkg/Library using

Re: [edk2-devel] [RFC PATCH] OvmfPkg/OvmfXen: set PcdAcpiS3Enable at initialization

2021-07-19 Thread Anthony PERARD via groups.io
On Thu, Jul 08, 2021 at 12:05:49PM +0800, Gary Lin wrote: > There are several functions in OvmfPkg/Library using > QemuFwCfgS3Enabled() to detect the S3 support status. However, in > MdeModulePkg, PcdAcpiS3Enable is used to check S3 support. Since > InitializeXenPlatform() didn't set

Re: [edk2-devel] [RFC PATCH] OvmfPkg/OvmfXen: set PcdAcpiS3Enable at initialization

2021-07-19 Thread Ard Biesheuvel
On Thu, 8 Jul 2021 at 06:05, Gary Lin wrote: > > There are several functions in OvmfPkg/Library using > QemuFwCfgS3Enabled() to detect the S3 support status. However, in > MdeModulePkg, PcdAcpiS3Enable is used to check S3 support. Since > InitializeXenPlatform() didn't set PcdAcpiS3Enable as >

[edk2-devel] [RFC PATCH] OvmfPkg/OvmfXen: set PcdAcpiS3Enable at initialization

2021-07-07 Thread Gary Lin via groups.io
There are several functions in OvmfPkg/Library using QemuFwCfgS3Enabled() to detect the S3 support status. However, in MdeModulePkg, PcdAcpiS3Enable is used to check S3 support. Since InitializeXenPlatform() didn't set PcdAcpiS3Enable as InitializePlatform() did, this made the inconsistency