Re: [edk2-devel] [Resend PATCH v4 4/4] DynamicTablesPkg: AML Code generation to invoke a method

2023-12-19 Thread PierreGondois
Hello Abdul, On 12/20/23 05:33, Attar, AbdulLateef (Abdul Lateef) wrote: [Public] Hi Pierre, Regarding the below comment +AmlCodeGenInvokeMethod ( + IN CONST CHAR8 *MethodNameString, + INUINT8 NumArgs, + INAML_METHOD_PARAM *Parameters

Re: [edk2-devel] [Resend PATCH v4 4/4] DynamicTablesPkg: AML Code generation to invoke a method

2023-12-19 Thread Abdul Lateef Attar via groups.io
[Public] Hi Pierre, Regarding the below comment > +AmlCodeGenInvokeMethod ( > + IN CONST CHAR8 *MethodNameString, > + INUINT8 NumArgs, > + INAML_METHOD_PARAM *Parameters OPTIONAL, > + INAML_NODE_HANDLE ParentNode Maybe it would be

Re: [edk2-devel] [Resend PATCH v4 4/4] DynamicTablesPkg: AML Code generation to invoke a method

2023-12-19 Thread PierreGondois
Hello Abdul, The new function looks good, there is just one small issue with the tree layout, Regards, Pierre On 12/19/23 04:06, Abdul Lateef Attar wrote: From: Abdul Lateef Attar Adds API to generate AML code to invoke/call another method. Also provides ability to pass arguments of type

[edk2-devel] [Resend PATCH v4 4/4] DynamicTablesPkg: AML Code generation to invoke a method

2023-12-18 Thread Abdul Lateef Attar via groups.io
From: Abdul Lateef Attar Adds API to generate AML code to invoke/call another method. Also provides ability to pass arguments of type integer, string, ArgObj or LocalObj. Cc: Pierre Gondois Cc: Sami Mujawar Signed-off-by: Abdul Lateef Attar --- .../Include/Library/AmlLib/AmlLib.h