Re: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc/StdLib: file descriptor leak in rename()

2023-08-22 Thread Michael D Kinney
Reviewed-by: Michael D Kinney > -Original Message- > From: Jayaprakash, N > Sent: Monday, August 21, 2023 8:22 PM > To: devel@edk2.groups.io > Cc: Jayaprakash, N ; Rebecca Cran > ; Kinney, Michael D ; > Kloper, Dimitry > Subject: [edk2-libc Patch 1/1] edk2-libc/StdLib: file

[edk2-devel] [edk2-libc Patch 1/1] edk2-libc/StdLib: file descriptor leak in rename()

2023-08-21 Thread Jayaprakash, N
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4529 rename() call leads to a function that makes open() for source file to be renamed. The resulting file descriptor is never closed. If you have to rename a couple of files this will quickly exhaust the descriptor table. The fix is trivial -