Sure Mike.
Thanks for your inputs and recommendations.
Regards,
JP
-Original Message-
From: Kinney, Michael D
Sent: 29 November 2022 23:28
To: Jayaprakash, N ; devel@edk2.groups.io; Kinney,
Michael D
Cc: Rebecca Cran ; Kadapathri, Ajay
; Frinzell, Aaron
Subject: RE: [edk2-libc
I recommend leaving it in Chipsec project until the port to MdePkg libs can be
completed.
Mike
> -Original Message-
> From: Jayaprakash, N
> Sent: Tuesday, November 29, 2022 8:22 AM
> To: Kinney, Michael D ; devel@edk2.groups.io
> Cc: Rebecca Cran ; Kadapathri, Ajay
> ; Frinzell,
Hi Mike,
Thanks Mike for your feedback. I completely agree with your suggestions.
Having said that, the code in PR is an existing well tested code from Chipsec
git repo and it was probably written quite a few years ago.
This is probably the reason that it is not following the edk2 conventions
Hi JP,
Many of these APIs are already available from the MdePkg BaseLib, IoLib, and
PciLib.
Why would we add custom ASM implementations of there here?
Why ASM and not NASM. edk2 projects have consolidated on NASM for all IA32/X64
assembly code.
I think the best approach is to port the
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4161
This patch merges the enhancements done by chipsec
tool to edk2 module into edk2-libc repo.
The chipsec enhancements can be used for various
other Python based tools to access platform registers.
These enhancements providing a set of APIs