Re: [edk2-devel] [edk2-platforms/devel-MinPlatform][PATCH 1/5] KabylakeSiliconPkg/BaseResetSystemLib: Add a new API ResetSystem

2019-04-15 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Gao, Zhichao > Sent: Monday, April 15, 2019 11:08 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Kubacki, Michael A > > Subject: [edk2-platforms/devel-MinPlatform][PATCH 1/5] > KabylakeSiliconPkg/BaseR

Re: [edk2-devel] [edk2-platforms/devel-MinPlatform][PATCH 1/5] KabylakeSiliconPkg/BaseResetSystemLib: Add a new API ResetSystem

2019-04-15 Thread Gao, Zhichao
age- > From: Chiu, Chasel > Sent: Monday, April 15, 2019 5:03 PM > To: Gao, Zhichao ; devel@edk2.groups.io > Cc: Kubacki, Michael A > Subject: RE: [edk2-platforms/devel-MinPlatform][PATCH 1/5] > KabylakeSiliconPkg/BaseResetSystemLib: Add a new API ResetSystem > > > Pl

Re: [edk2-devel] [edk2-platforms/devel-MinPlatform][PATCH 1/5] KabylakeSiliconPkg/BaseResetSystemLib: Add a new API ResetSystem

2019-04-15 Thread Chiu, Chasel
Please see below comments inline. > -Original Message- > From: Gao, Zhichao > Sent: Monday, April 15, 2019 11:08 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Kubacki, Michael A > > Subject: [edk2-platforms/devel-MinPlatform][PATCH 1/5] > KabylakeSiliconPkg

[edk2-devel] [edk2-platforms/devel-MinPlatform][PATCH 1/5] KabylakeSiliconPkg/BaseResetSystemLib: Add a new API ResetSystem

2019-04-14 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1460 Add a new API ResetSystem to this ResetSystemLib instance. It only adds the basic functions from ResetSystemRuntimeDxe. Lacking of this interface may cause link error, if some drivers use this new API and link to this library instance. Make