Re: [edk2-devel] [edk2-platforms: PATCH] MinPlatformPkg: Add FSP 2.4 MultiPhase library.

2023-08-08 Thread Nate DeSimone
Gao, Liming ; Dong, > Eric > Subject: RE: [edk2-devel] [edk2-platforms: PATCH] MinPlatformPkg: Add FSP > 2.4 MultiPhase library. > > Is the FSP 2.4 specification available publicly? It is hard to understand the > impact of this without referencing the specification. From the FSP page on

Re: [edk2-devel] [edk2-platforms: PATCH] MinPlatformPkg: Add FSP 2.4 MultiPhase library.

2022-09-01 Thread Tim Lewis via groups.io
] MinPlatformPkg: Add FSP 2.4 MultiPhase library. FSP Wrapper has implemented FSP 2.4 MultiPhase support and required platform to include new library instance. Cc: Nate DeSimone Cc: Isaac Oram Cc: Liming Gao Cc: Eric Dong Signed-off-by: Chasel Chiu --- Platform/Intel/MinPlatformPkg/Include/Dsc

Re: [edk2-devel] [edk2-platforms: PATCH] MinPlatformPkg: Add FSP 2.4 MultiPhase library.

2022-09-01 Thread Chiu, Chasel
Agree. I'm sending patch to rename this lib from edk2 and will send patch to rename this lib from MinPlatformPkg dsc too. Thanks, Chasel > -Original Message- > From: Oram, Isaac W > Sent: Wednesday, August 31, 2022 4:10 PM > To: Chiu, Chasel ; devel@edk2.groups.io > Cc: Desimone,

Re: [edk2-devel] [edk2-platforms: PATCH] MinPlatformPkg: Add FSP 2.4 MultiPhase library.

2022-08-31 Thread Oram, Isaac W
This sample library does not do anything. If the design is such that a NULL library is functional, then a NULL library should be implemented. Having a sample library that has the same function as a NULL library doesn't make sense to me. It looks like a NULL library would work fine in this

[edk2-devel] [edk2-platforms: PATCH] MinPlatformPkg: Add FSP 2.4 MultiPhase library.

2022-08-31 Thread Chiu, Chasel
FSP Wrapper has implemented FSP 2.4 MultiPhase support and required platform to include new library instance. Cc: Nate DeSimone Cc: Isaac Oram Cc: Liming Gao Cc: Eric Dong Signed-off-by: Chasel Chiu --- Platform/Intel/MinPlatformPkg/Include/Dsc/CorePeiLib.dsc | 2 ++ 1 file changed, 2