Re: [edk2-devel] [edk2-platforms: PATCH 1/2] IpmiFeaturePkg: Fail to build this package.

2021-07-08 Thread Chiu, Chasel
Change pushed: 8cb431b46a0888a8ee8e442dc3ea50d7de79e473 107af998afe1a34c7b6aff5240abd9918e51b073 Thanks, Chasel > -Original Message- > From: Chaganty, Rangasai V > Sent: Friday, July 9, 2021 2:33 PM > To: Chiu, Chasel ; devel@edk2.groups.io > Cc: Desimone, Nathaniel L ; Liming Gao >

Re: [edk2-devel] [edk2-platforms: PATCH 1/2] IpmiFeaturePkg: Fail to build this package.

2021-07-08 Thread Chaganty, Rangasai V
Sounds good. -Original Message- From: Chiu, Chasel Sent: Thursday, July 08, 2021 11:32 PM To: Chaganty, Rangasai V ; devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Liming Gao ; Oram, Isaac W Subject: RE: [edk2-platforms: PATCH 1/2] IpmiFeaturePkg: Fail to build this package. Hi Sa

Re: [edk2-devel] [edk2-platforms: PATCH 1/2] IpmiFeaturePkg: Fail to build this package.

2021-07-08 Thread Chiu, Chasel
Hi Sai, We will fix the build failure first and macro naming convention will be checked separately later. Thanks, Chasel > -Original Message- > From: Chaganty, Rangasai V > Sent: Friday, July 9, 2021 10:25 AM > To: Chiu, Chasel ; devel@edk2.groups.io > Cc: Desimone, Nathaniel L ; Li

Re: [edk2-devel] [edk2-platforms: PATCH 1/2] IpmiFeaturePkg: Fail to build this package.

2021-07-08 Thread Chaganty, Rangasai V
In ServerManagment.h, please make sure the newly added macros and structure names are EFI/PI spec defined. If they are not, please remove "EFI_" prefix from the names. With that: Reviewed-by: Sai Chaganty -Original Message- From: Chiu, Chasel Sent: Thursday, July 08, 2021 7:41 AM To:

[edk2-devel] [edk2-platforms: PATCH 1/2] IpmiFeaturePkg: Fail to build this package.

2021-07-08 Thread Chiu, Chasel
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3484 Fixed the build failure of this package. Cc: Nate DeSimone Cc: Sai Chaganty Cc: Liming Gao Cc: Isaac Oram Signed-off-by: Chasel Chiu --- Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Pei/PeiGenericIpmi.inf | 1 + Fe