Re: [edk2-devel] [edk2-platforms:PATCH v3] IntelSiliconPkg/DxeAslUpdateLib: Add DxeAslUpdateLib support

2020-04-18 Thread Nate DeSimone
Hi Miki, In AslUpdateLib.h you have cases of "EFIAPI EFI_STATUS" it should be "EFI_STATUS EFIAPI". Please update. Thanks, Nate -Original Message- From: Shindo, Miki Sent: Monday, April 6, 2020 12:29 AM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Chiu, Chasel ; Desimone,

Re: [edk2-devel] [edk2-platforms:PATCH v3] IntelSiliconPkg/DxeAslUpdateLib: Add DxeAslUpdateLib support

2020-04-14 Thread Chaganty, Rangasai V
Reviewed-by: Sai Chaganty -Original Message- From: Shindo, Miki Sent: Monday, April 06, 2020 12:29 AM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Chiu, Chasel ; Desimone, Nathaniel L ; Agyeman, Prince ; Ni, Ray Subject: [edk2-platforms:PATCH v3]

Re: [edk2-devel] [edk2-platforms:PATCH v3] IntelSiliconPkg/DxeAslUpdateLib: Add DxeAslUpdateLib support

2020-04-14 Thread Ni, Ray
Reviewed-by: Ray Ni > -Original Message- > From: Shindo, Miki > Sent: Monday, April 6, 2020 3:29 PM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Agyeman, Prince > ; Ni, Ray > Subject: [edk2-platforms:PATCH v3]

Re: [edk2-devel] [edk2-platforms:PATCH v3] IntelSiliconPkg/DxeAslUpdateLib: Add DxeAslUpdateLib support

2020-04-10 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: Shindo, Miki Sent: Monday, April 6, 2020 12:29 AM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Chiu, Chasel ; Desimone, Nathaniel L ; Agyeman, Prince ; Ni, Ray Subject: [edk2-platforms:PATCH v3]

[edk2-devel] [edk2-platforms:PATCH v3] IntelSiliconPkg/DxeAslUpdateLib: Add DxeAslUpdateLib support

2020-04-06 Thread Miki Shindo
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2536 This commit adds DxeAslUpdateLib library support in IntelSiliconPkg, which allows AML to be updated in DXE. Signed-off-by: Miki Shindo Cc: Sai Chaganty Cc: Chasel Chiu Cc: Nate DeSimone Cc: Prince Agyeman Cc: Ray Ni Acked-by: Chasel