Re: [edk2-devel] [edk2-platforms][PATCH 04/15] Silicon/BcmGenet: Add missing I/O mapping length and clean up

2020-02-28 Thread Pete Batard
On 2020.02.28 10:58, Ard Biesheuvel wrote: On Fri, 28 Feb 2020 at 11:51, Pete Batard wrote: Hi Ard, On 2020.02.28 10:45, Ard Biesheuvel wrote: On Fri, 28 Feb 2020 at 11:39, Pete Batard wrote: Remove unneeded extra parenthesis on PCD, which can cause problems when used with ACPI ASL macros

Re: [edk2-devel] [edk2-platforms][PATCH 04/15] Silicon/BcmGenet: Add missing I/O mapping length and clean up

2020-02-28 Thread Ard Biesheuvel
On Fri, 28 Feb 2020 at 11:51, Pete Batard wrote: > > Hi Ard, > > On 2020.02.28 10:45, Ard Biesheuvel wrote: > > On Fri, 28 Feb 2020 at 11:39, Pete Batard wrote: > >> > >> Remove unneeded extra parenthesis on PCD, which can cause problems > >> when used with ACPI ASL macros and add an [Includes] s

Re: [edk2-devel] [edk2-platforms][PATCH 04/15] Silicon/BcmGenet: Add missing I/O mapping length and clean up

2020-02-28 Thread Pete Batard
Hi Ard, On 2020.02.28 10:45, Ard Biesheuvel wrote: On Fri, 28 Feb 2020 at 11:39, Pete Batard wrote: Remove unneeded extra parenthesis on PCD, which can cause problems when used with ACPI ASL macros and add an [Includes] section to the .inf, so that the Genet.h header can be referenced where r

Re: [edk2-devel] [edk2-platforms][PATCH 04/15] Silicon/BcmGenet: Add missing I/O mapping length and clean up

2020-02-28 Thread Ard Biesheuvel
On Fri, 28 Feb 2020 at 11:39, Pete Batard wrote: > > Remove unneeded extra parenthesis on PCD, which can cause problems > when used with ACPI ASL macros and add an [Includes] section to the > .inf, so that the Genet.h header can be referenced where required. > > Signed-off-by: Pete Batard > --- >

[edk2-devel] [edk2-platforms][PATCH 04/15] Silicon/BcmGenet: Add missing I/O mapping length and clean up

2020-02-28 Thread Pete Batard
Remove unneeded extra parenthesis on PCD, which can cause problems when used with ACPI ASL macros and add an [Includes] section to the .inf, so that the Genet.h header can be referenced where required. Signed-off-by: Pete Batard --- Silicon/Broadcom/Drivers/Net/BcmGenetDxe/Genet.h | 3 ++- Silic