While I'm all for improvements throughout the file, the scope of this change is
just to fix the GCC failures
and make general style improvements to impacted lines. I'll send a patch V2
with the DEBUG
macro updated to DEBUG_ERROR. Anything further peripheral cleanup is a slippery
slope for this
Two comments on SolStatus.c:
1. "SolEnabled" seems more appropriate variable name than just "Enabled. Should
we consider renaming the variable name?
2. Please replace EFI_D_ERROR with DEBUG_ERROR
-Original Message-
From: Kubacki, Michael A
Sent: Wednesday, September 11, 2019 11:09 PM
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2059
These build failures can be reproduced simply by building the
AdvancedFeaturePkg.dsc file in GCC5. To build the whole package
DSC (not pull individual features into other packages), set
the WORKSPACE variable to the edk2 directory in the
