Re: [edk2-devel] [edk2-platforms][PATCH v1 0/3] MinPlatformPkg: Add FADT duty offset and width PCDs

2022-06-06 Thread Nate DeSimone
The series has been pushed as ~3018b1f..61af470 -Original Message- From: mikub...@linux.microsoft.com Sent: Monday, April 11, 2022 1:58 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Gao, Liming ; Dong, Eric Subject: [edk2-platforms][PATCH v1 0/3]

Re: [edk2-devel] [edk2-platforms][PATCH v1 0/3] MinPlatformPkg: Add FADT duty offset and width PCDs

2022-06-06 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: mikub...@linux.microsoft.com Sent: Monday, April 11, 2022 1:58 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Gao, Liming ; Dong, Eric Subject: [edk2-platforms][PATCH v1 0/3] MinPlatformPkg: Add FADT duty

Re: [edk2-devel] [edk2-platforms][PATCH v1 0/3] MinPlatformPkg: Add FADT duty offset and width PCDs

2022-05-16 Thread Michael Kubacki
Can someone seriously respond? This was approved over 3 weeks ago and sent 5 weeks ago. I know Ankit now has a similar change out but I'd like to see if this can get in and that be rebased on it since this has been out for so long and has the primary change needed for our integration.

Re: [edk2-devel] [edk2-platforms][PATCH v1 0/3] MinPlatformPkg: Add FADT duty offset and width PCDs

2022-05-13 Thread Michael Kubacki
Reminder On 5/10/2022 1:34 PM, Michael Kubacki wrote: Another reminder to look at this patch. Thanks, Michael On 4/29/2022 4:07 PM, Michael Kubacki wrote: Another reminder to merge this series. Chasel has added his review and that is in this branch:

Re: [edk2-devel] [edk2-platforms][PATCH v1 0/3] MinPlatformPkg: Add FADT duty offset and width PCDs

2022-05-10 Thread Michael Kubacki
Another reminder to look at this patch. Thanks, Michael On 4/29/2022 4:07 PM, Michael Kubacki wrote: Another reminder to merge this series. Chasel has added his review and that is in this branch: https://github.com/makubacki/edk2-platforms/commits/active/add_duty_pcds_minplatformpkg_v1_rb1

Re: [edk2-devel] [edk2-platforms][PATCH v1 0/3] MinPlatformPkg: Add FADT duty offset and width PCDs

2022-04-29 Thread Michael Kubacki
Another reminder to merge this series. Chasel has added his review and that is in this branch: https://github.com/makubacki/edk2-platforms/commits/active/add_duty_pcds_minplatformpkg_v1_rb1 Thanks, Michael On 4/22/2022 10:04 AM, Michael Kubacki wrote: Reminder to review this series. Ankit

Re: [edk2-devel] [edk2-platforms][PATCH v1 0/3] MinPlatformPkg: Add FADT duty offset and width PCDs

2022-04-25 Thread Michael Kubacki
Thanks Chasel. I pushed a branch rebased on the latest master branch with R-b tags here in case that helps with merging: https://github.com/makubacki/edk2-platforms/commits/active/add_duty_pcds_minplatformpkg_v1_rb1 Regards, Michael On 4/25/2022 12:08 AM, Chiu, Chasel wrote: Thanks Michael!

Re: [edk2-devel] [edk2-platforms][PATCH v1 0/3] MinPlatformPkg: Add FADT duty offset and width PCDs

2022-04-24 Thread Chiu, Chasel
Thanks Michael! For this patch series: Reviewed-by: Chasel Chiu > -Original Message- > From: mikub...@linux.microsoft.com > Sent: Tuesday, April 12, 2022 4:58 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Gao, Liming > ; Dong, Eric > Subject:

Re: [edk2-devel] [edk2-platforms][PATCH v1 0/3] MinPlatformPkg: Add FADT duty offset and width PCDs

2022-04-22 Thread Michael Kubacki
Reminder to review this series. Ankit Sinha has reviewed it but need a maintainer to review and merge. On 4/11/2022 4:58 PM, Michael Kubacki wrote: From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3543 Adds PCDs to the MinPlatformPkg DEC file so MinPlatformPkg

Re: [edk2-devel] [edk2-platforms][PATCH v1 0/3] MinPlatformPkg: Add FADT duty offset and width PCDs

2022-04-11 Thread Sinha, Ankit
edk2-devel] [edk2-platforms][PATCH v1 0/3] MinPlatformPkg: Add > FADT duty offset and width PCDs > > From: Michael Kubacki > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3543 > > Adds PCDs to the MinPlatformPkg DEC file so MinPlatformPkg consumers > (board pac

[edk2-devel] [edk2-platforms][PATCH v1 0/3] MinPlatformPkg: Add FADT duty offset and width PCDs

2022-04-11 Thread Michael Kubacki
From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3543 Adds PCDs to the MinPlatformPkg DEC file so MinPlatformPkg consumers (board packages) can customize the DUTY_OFFSET and DUTY_CYCLE values in their build files. The copy of AcpiPlatform in SimicsOpenBoardPkg is also