Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] IntelSiliconPkg/PeiSmmAccessLib: Remove S3 requirement

2021-09-09 Thread Ni, Ray
, 2021 10:10 PM > To: devel@edk2.groups.io; Ni, Ray ; Yao, Jiewen > ; Chaganty, Rangasai V > > Subject: Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] > IntelSiliconPkg/PeiSmmAccessLib: Remove S3 requirement > > Ray, > > When do you think this patch will get merged?

Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] IntelSiliconPkg/PeiSmmAccessLib: Remove S3 requirement

2021-09-09 Thread Michael Kubacki
, 2021 6:02 PM To: Yao, Jiewen ; Michael Kubacki ; devel@edk2.groups.io; mikub...@linux.microsoft.com; Chaganty, Rangasai V Subject: RE: [edk2-devel] [edk2-platforms][PATCH v1 1/1] IntelSiliconPkg/PeiSmmAccessLib: Remove S3 requirement Jiewen, We have MmAccess PPI

Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] IntelSiliconPkg/PeiSmmAccessLib: Remove S3 requirement

2021-08-20 Thread Michael Kubacki
Subject: Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] IntelSiliconPkg/PeiSmmAccessLib: Remove S3 requirement Ray, In the end, PI modules are allowed to depend on non-deprecated PI PPIs. The scope of this change is about the API that installs the PPI. So I do not want to diverge the conversation

Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] IntelSiliconPkg/PeiSmmAccessLib: Remove S3 requirement

2021-08-20 Thread Ni, Ray
ubacki > Sent: Friday, August 20, 2021 3:45 AM > To: devel@edk2.groups.io; Yao, Jiewen ; Ni, Ray > ; Chaganty, Rangasai V > > Subject: Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] > IntelSiliconPkg/PeiSmmAccessLib: Remove S3 requirement > > Ray, > > In the end, PI

Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] IntelSiliconPkg/PeiSmmAccessLib: Remove S3 requirement

2021-08-19 Thread Michael Kubacki
, 2021 6:02 PM To: Yao, Jiewen ; Michael Kubacki ; devel@edk2.groups.io; mikub...@linux.microsoft.com; Chaganty, Rangasai V Subject: RE: [edk2-devel] [edk2-platforms][PATCH v1 1/1] IntelSiliconPkg/PeiSmmAccessLib: Remove S3 requirement Jiewen, We have MmAccess PPI

Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] IntelSiliconPkg/PeiSmmAccessLib: Remove S3 requirement

2021-08-19 Thread Yao, Jiewen
ki > ; devel@edk2.groups.io; > mikub...@linux.microsoft.com; Chaganty, Rangasai V > > Subject: RE: [edk2-devel] [edk2-platforms][PATCH v1 1/1] > IntelSiliconPkg/PeiSmmAccessLib: Remove S3 requirement > > Jiewen, > We have MmAccess PPI and gEfiMmPeiSmramMemoryReserveGuid

Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] IntelSiliconPkg/PeiSmmAccessLib: Remove S3 requirement

2021-08-19 Thread Ni, Ray
- > > From: devel@edk2.groups.io On Behalf Of > > Michael > Kubacki > > Sent: Tuesday, August 10, 2021 11:36 PM > > To: devel@edk2.groups.io; Ni, Ray ; Chaganty, > > Rangasai V > > > Cc: Yao, Jiewen > > Subject: Re: [edk2-devel] [edk2-p

Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] IntelSiliconPkg/PeiSmmAccessLib: Remove S3 requirement

2021-08-18 Thread Yao, Jiewen
Thursday, August 19, 2021 2:47 AM > To: devel@edk2.groups.io; Ni, Ray ; > mikub...@linux.microsoft.com; Chaganty, Rangasai V > ; Yao, Jiewen > Subject: Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] > IntelSiliconPkg/PeiSmmAccessLib: Remove S3 requirement > > Jiew

Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] IntelSiliconPkg/PeiSmmAccessLib: Remove S3 requirement

2021-08-18 Thread Michael Kubacki
devel@edk2.groups.io; Ni, Ray ; mikub...@linux.microsoft.com; Chaganty, Rangasai V ; Yao, Jiewen Subject: Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] IntelSiliconPkg/PeiSmmAccessLib: Remove S3 requirement Jiewen/Sai, are you thinking about this? Thanks, Michael On 8/12/2021 1:20 AM, Ni, Ray wrote

Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] IntelSiliconPkg/PeiSmmAccessLib: Remove S3 requirement

2021-08-18 Thread Chaganty, Rangasai V
--Original Message- From: Michael Kubacki Sent: Wednesday, August 18, 2021 11:47 AM To: devel@edk2.groups.io; Ni, Ray ; mikub...@linux.microsoft.com; Chaganty, Rangasai V ; Yao, Jiewen Subject: Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] IntelSiliconPkg/PeiSmmAccessLib: Remove S3 r

Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] IntelSiliconPkg/PeiSmmAccessLib: Remove S3 requirement

2021-08-18 Thread Michael Kubacki
: [edk2-devel] [edk2-platforms][PATCH v1 1/1] IntelSiliconPkg/PeiSmmAccessLib: Remove S3 requirement Installation is a platform decision. The buried dependency on boot mode in this particular function is just a roadblock platforms have to work around. The role of this API is to install the PPI

Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] IntelSiliconPkg/PeiSmmAccessLib: Remove S3 requirement

2021-08-11 Thread Ni, Ray
-Original Message- From: devel@edk2.groups.io On Behalf Of Michael Kubacki Sent: Tuesday, August 10, 2021 11:36 PM To: devel@edk2.groups.io; Ni, Ray ; Chaganty, Rangasai V Cc: Yao, Jiewen Subject: Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] IntelSiliconPkg/PeiSmmAccessLib: Remove S3 requirement

Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] IntelSiliconPkg/PeiSmmAccessLib: Remove S3 requirement

2021-08-10 Thread Michael Kubacki
Installation is a platform decision. The buried dependency on boot mode in this particular function is just a roadblock platforms have to work around. The role of this API is to install the PPI. Thanks, Michael On 8/9/2021 9:47 PM, Ni, Ray wrote: Michael, Allowing the gPeiSmmAccessPpiGuid

Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] IntelSiliconPkg/PeiSmmAccessLib: Remove S3 requirement

2021-08-09 Thread Ni, Ray
Michael, Allowing the gPeiSmmAccessPpiGuid PPI installation in normal boot will further allow gEfiPeiSmmCommunicationPpiGuid installation in normal path, while without your change neither of the PPIs is installed in normal boot. + Jiewen for potential security concern. Thanks, Ray >

Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] IntelSiliconPkg/PeiSmmAccessLib: Remove S3 requirement

2021-08-09 Thread Chaganty, Rangasai V
Reviewed-by: Sai Chaganty -Original Message- From: mikub...@linux.microsoft.com Sent: Monday, August 09, 2021 6:40 AM To: devel@edk2.groups.io Cc: Ni, Ray ; Chaganty, Rangasai V Subject: [edk2-platforms][PATCH v1 1/1] IntelSiliconPkg/PeiSmmAccessLib: Remove S3 requirement From:

[edk2-devel] [edk2-platforms][PATCH v1 1/1] IntelSiliconPkg/PeiSmmAccessLib: Remove S3 requirement

2021-08-09 Thread Michael Kubacki
From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3539 PeiInstallSmmAccessPpi() currently requires the boot mode be set to S3 to actually install gEfiPeiMmAccessPpiGuid. This change removes this requirement in the function implementation for two reasons: 1. Practical