Follow AcpiPlatformDxe (from which this module is derived) and install
all ACPI tables added by board.
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Rangasai V Chaganty
Cc: Deepika Kethi Reddy
Cc: Kathappan Esakkithevar
Signed-off-by: Benjamin Doron
---
.../Acpi/BoardAcpiDxe/BoardAcpiDxe.c
Another reason to install these tables with BoardAcpiDxe is that it calls a
board-implemented hook to patch the tables, if necessary. AcpiPlatformDxe only
installs the tables as they are found.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply
Hi Benjamin,
It would be good to add a check on the status code returned from
PublishAcpiTablesFromFv() to the debug log. Something like this:
Status = PublishAcpiTablesFromFv ();
if (EFI_ERROR (Status)) {
DEBUG ((DEBUG_ERROR, "Error: PublishAcpiTablesFromFv[%g] - %r",
, Status));
}
.
Thanks,
Nate
From: devel@edk2.groups.io On Behalf Of Benjamin Doron
Sent: Wednesday, August 4, 2021 2:51 PM
To: Chaganty; Chaganty, Rangasai V ;
devel@edk2.groups.io
Subject: Re: [edk2-devel] [edk2-platforms][PATCH v1 2/4]
CometlakeOpenBoardPkg/Acpi: BoardAcpiDxe also installs all
Hi Sai,
There may be a requirement to install board-specific ACPI tables. For example,
to support an embedded controller in laptops, or other controllers in servers
and desktops.
In a conversation with Nate about a board port in KabylakeOpenBoardPkg, I said
that the options for such boards
Hi Benjamin,
The problem statement is not clear to me.
Could you share any background for this change - RFC, Bugzilla etc?
Thanks,
Sai Chaganty
-Original Message-
From: Benjamin Doron
Sent: Wednesday, August 04, 2021 12:59 PM
To: devel@edk2.groups.io
Cc: Chiu, Chasel ; Desimone,
Follow AcpiPlatformDxe (from which this module is derived) and install
all ACPI tables added by board.
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Rangasai V Chaganty
Cc: Deepika Kethi Reddy
Cc: Kathappan Esakkithevar
Signed-off-by: Benjamin Doron
---
