Re: [edk2-devel] [edk2-platforms][PATCH v2 2/5] Platform/RPi3/RpiFirmwareDxe: Improve serial number population

2019-10-10 Thread Pete Batard
On 2019.10.10 17:49, Leif Lindholm wrote: On Thu, Oct 10, 2019 at 01:41:20PM +0100, Pete Batard wrote: It's a disagreement. And the same goes for 3/5 & 4/5. Please see the note I wrote in 0/5 for the v2, because the cover letter this is usually the place I try to clarify elements that may throw

Re: [edk2-devel] [edk2-platforms][PATCH v2 2/5] Platform/RPi3/RpiFirmwareDxe: Improve serial number population

2019-10-10 Thread Leif Lindholm
On Thu, Oct 10, 2019 at 01:41:20PM +0100, Pete Batard wrote: > It's a disagreement. And the same goes for 3/5 & 4/5. Please see the note I > wrote in 0/5 for the v2, because the cover letter this is usually the place > I try to clarify elements that may throw off a maintainer, and that don't >

Re: [edk2-devel] [edk2-platforms][PATCH v2 2/5] Platform/RPi3/RpiFirmwareDxe: Improve serial number population

2019-10-10 Thread Pete Batard
Hi Leif, It's a disagreement. And the same goes for 3/5 & 4/5. Please see the note I wrote in 0/5 for the v2, because the cover letter this is usually the place I try to clarify elements that may throw off a maintainer, and that don't belong in a commit message. Not so sound flippant here,

Re: [edk2-devel] [edk2-platforms][PATCH v2 2/5] Platform/RPi3/RpiFirmwareDxe: Improve serial number population

2019-10-10 Thread Leif Lindholm
On Tue, Oct 08, 2019 at 01:38:38PM +0100, Pete Batard wrote: > Improve RpiFirmwareGetSerial() to derive a serial number from the > MAC address, in case the platform returns 0 for the serial number. > > Also fix a typo where "%s" was used instead of "%a". I did not see a reply to my feedback on

[edk2-devel] [edk2-platforms][PATCH v2 2/5] Platform/RPi3/RpiFirmwareDxe: Improve serial number population

2019-10-08 Thread Pete Batard
Improve RpiFirmwareGetSerial() to derive a serial number from the MAC address, in case the platform returns 0 for the serial number. Also fix a typo where "%s" was used instead of "%a". Signed-off-by: Pete Batard --- Platform/RaspberryPi/RPi3/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c | 11