Reviewed-by: Chasel Chiu
> -Original Message-
> From: Desimone, Nathaniel L
> Sent: Wednesday, June 10, 2020 8:31 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Chaganty, Rangasai V
>
> Subject: [edk2-platforms] [PATCH] KabyLakeSiliconPkg: Bitmask comparison
> logic bug
>
>
Good catch.
Reviewed-by: Sai Chaganty
-Original Message-
From: Desimone, Nathaniel L
Sent: Tuesday, June 09, 2020 5:31 PM
To: devel@edk2.groups.io
Cc: Chiu, Chasel ; Chaganty, Rangasai V
Subject: [edk2-platforms] [PATCH] KabyLakeSiliconPkg: Bitmask comparison logic
bug
(Cpptv &
(Cpptv & B_PCH_SPI_SFDPX_VSCCX_CPPTV) can only evaluate to
two possible values, 0x0 or B_PCH_SPI_SFDPX_VSCCX_CPPTV
(aka BIT31). The current comparison to 0x1 will always fail.
Fixed the if statement to compare to B_PCH_SPI_SFDPX_VSCCX_CPPTV.
Signed-off-by: Nate DeSimone
Cc: Chasel Chiu
Cc: Sai
