Re: [edk2-devel] [edk2-platforms] [PATCH V1] KabylakeOpenBoardPkg/AspireVn7Dash572G: Fix Visual Studio Build

2021-09-28 Thread Nate DeSimone
V1] KabylakeOpenBoardPkg/AspireVn7Dash572G: Fix Visual Studio Build AspireVn7Dash572G currently does not build with Visual Studio. This is due to the Visual C++ compiler generating warnings with the GCC compiler does not. The two classes of issues are unused local variables and implicit integer

Re: [edk2-devel] [edk2-platforms] [PATCH V1] KabylakeOpenBoardPkg/AspireVn7Dash572G: Fix Visual Studio Build

2021-09-28 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Desimone, Nathaniel L > Sent: Wednesday, September 29, 2021 9:03 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Benjamin Doron > > Subject: [edk2-platforms] [PATCH V1] > KabylakeOpenBoardPkg/AspireVn7Dash572G: Fix Visual

[edk2-devel] [edk2-platforms] [PATCH V1] KabylakeOpenBoardPkg/AspireVn7Dash572G: Fix Visual Studio Build

2021-09-28 Thread Nate DeSimone
AspireVn7Dash572G currently does not build with Visual Studio. This is due to the Visual C++ compiler generating warnings with the GCC compiler does not. The two classes of issues are unused local variables and implicit integer casts that could result in truncation. Visual C++ requires an explicit