Re: [edk2-devel] [edk2-platforms] [PATCH V1] WhitleySiliconPkg: Improve comments for silicon policy structures

2021-08-11 Thread Nate DeSimone
] WhitleySiliconPkg: Improve comments for silicon policy structures Signed-off-by: Nate DeSimone Cc: Isaac Oram Cc: Chasel Chiu --- .../Include/Ppi/RasImcS3Data.h| 6 + .../Include/Ppi/UpiPolicyPpi.h| 5 +- .../WhitleySiliconPkg/Include/Upi/KtiHost.h | 250

Re: [edk2-devel] [edk2-platforms] [PATCH V1] WhitleySiliconPkg: Improve comments for silicon policy structures

2021-08-11 Thread Nate DeSimone
Hi Chasel, Thank you for the feedback. I have resolved it before push. Thanks, Nate -Original Message- From: Chiu, Chasel Sent: Tuesday, July 20, 2021 9:07 PM To: Desimone, Nathaniel L ; devel@edk2.groups.io Cc: Oram, Isaac W Subject: RE: [edk2-platforms] [PATCH V1] WhitleySiliconPkg:

Re: [edk2-devel] [edk2-platforms] [PATCH V1] WhitleySiliconPkg: Improve comments for silicon policy structures

2021-08-11 Thread Oram, Isaac W
Reviewed-by: Isaac Oram -Original Message- From: devel@edk2.groups.io On Behalf Of Desimone, Nathaniel L Sent: Tuesday, July 20, 2021 1:22 PM To: devel@edk2.groups.io Cc: Oram, Isaac W ; Chiu, Chasel Subject: [edk2-devel] [edk2-platforms] [PATCH V1] WhitleySiliconPkg: Improve

Re: [edk2-devel] [edk2-platforms] [PATCH V1] WhitleySiliconPkg: Improve comments for silicon policy structures

2021-07-20 Thread Chiu, Chasel
Hi Nate, Just one small feedbacks inline, please check them. With that resolved: Reviewed-by: Chasel Chiu Thanks, Chasel > -Original Message- > From: Desimone, Nathaniel L > Sent: Wednesday, July 21, 2021 4:22 AM > To: devel@edk2.groups.io > Cc: Oram, Isaac W ; Chiu, Chasel >

[edk2-devel] [edk2-platforms] [PATCH V1] WhitleySiliconPkg: Improve comments for silicon policy structures

2021-07-20 Thread Nate DeSimone
Signed-off-by: Nate DeSimone Cc: Isaac Oram Cc: Chasel Chiu --- .../Include/Ppi/RasImcS3Data.h| 6 + .../Include/Ppi/UpiPolicyPpi.h| 5 +- .../WhitleySiliconPkg/Include/Upi/KtiHost.h | 250 +- .../SouthClusterLbg/Include/PchPolicyCommon.h |