Re: [edk2-devel] [edk2-platforms PATCH 1/1] AmpereAltraPkg/Ac01PcieLib: drop useless link status register read

2023-10-17 Thread Laszlo Ersek
On 10/17/23 13:38, Nhi Pham via groups.io wrote: > Thanks, Laszlo for this patch. > > Reviewed-by: Nhi Pham > > Regards, > Nhi Thank you both for reviewing; commit 7f3e7fc0b4ed. Laszlo > > On 10/17/2023 5:05 PM, Laszlo Ersek via groups.io wrote: >> Nhi says that reading

Re: [edk2-devel] [edk2-platforms PATCH 1/1] AmpereAltraPkg/Ac01PcieLib: drop useless link status register read

2023-10-17 Thread Nhi Pham via groups.io
Thanks, Laszlo for this patch. Reviewed-by: Nhi Pham Regards, Nhi On 10/17/2023 5:05 PM, Laszlo Ersek via groups.io wrote: Nhi says that reading LINK_CONTROL_LINK_STATUS_REG is redundant; its only use was debugging (before commit 380b4b40c60d). Thus, we can go farther than commit

Re: [edk2-devel] [edk2-platforms PATCH 1/1] AmpereAltraPkg/Ac01PcieLib: drop useless link status register read

2023-10-17 Thread Rebecca Cran via groups.io
On 10/17/2023 4:05 AM, Laszlo Ersek wrote: Nhi says that reading LINK_CONTROL_LINK_STATUS_REG is redundant; its only use was debugging (before commit 380b4b40c60d). Thus, we can go farther than commit 2e27c62ef000, and remove the MmioRead32() call altogether. Build-tested with "Jade.dsc". Cc:

[edk2-devel] [edk2-platforms PATCH 1/1] AmpereAltraPkg/Ac01PcieLib: drop useless link status register read

2023-10-17 Thread Laszlo Ersek
Nhi says that reading LINK_CONTROL_LINK_STATUS_REG is redundant; its only use was debugging (before commit 380b4b40c60d). Thus, we can go farther than commit 2e27c62ef000, and remove the MmioRead32() call altogether. Build-tested with "Jade.dsc". Cc: Chuong Tran Cc: Leif Lindholm Cc: Nhi Pham