On 10/13/23 05:24, Nhi Pham wrote:
> HI Lazslo,
>
> I was not reviewing carefully. The MmioRead32 is redundant code. Can you
> help me get rid of that code?
Sure, if you don't need the read access to the
LINK_CONTROL_LINK_STATUS_REG register, I can drop that too; I just
didn't want to do it
HI Lazslo,
I was not reviewing carefully. The MmioRead32 is redundant code. Can you
help me get rid of that code?
Thanks,
Nhi
On 10/13/2023 9:20 AM, Nhi Pham wrote:
Thanks for fixing it.
Reviewed-by: Nhi Pham
Regards,
Nhi
On 10/12/2023 4:09 PM, Laszlo Ersek wrote:
Commit 380b4b40c60d
Thanks for fixing it.
Reviewed-by: Nhi Pham
Regards,
Nhi
On 10/12/2023 4:09 PM, Laszlo Ersek wrote:
Commit 380b4b40c60d ("AmpereAltraPkg: Update Ampere specific platform PCIe
core", 2023-03-29) removed the DEBUG macro call from
Ac01PcieCoreUpdateLink() that was the only reader of "Val".
Commit 380b4b40c60d ("AmpereAltraPkg: Update Ampere specific platform PCIe
core", 2023-03-29) removed the DEBUG macro call from
Ac01PcieCoreUpdateLink() that was the only reader of "Val". Since then,
Val has only been set, but never read. This triggers
"-Werror=unused-but-set-variable".
Found
