The RealTimeClockLib class header in edk2 mistakenly declares a function
called LibRtcVirtualNotifyEvent(). No component ever calls this function
crossing module boundaries; all RealTimeClockLib instances in edk2 and
edk2-platforms are supposed to register (and do register) their
SetVirtualAddressMap() notification functions.

Rename LibRtcVirtualNotifyEvent() to VirtualNotifyEvent(), and make it
static, in preparation for removing the LibRtcVirtualNotifyEvent()
declaration from the lib class header later.

Build-tested only (with "DurianPkg.dsc").

Cc: Leif Lindholm <quic_llind...@quicinc.com>
Cc: Ling Jia <jial...@phytium.com.cn>
Cc: Peng Xie <xiep...@phytium.com.cn>
Cc: Yiqi Shu <shuy...@phytium.com.cn>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4564
Signed-off-by: Laszlo Ersek <ler...@redhat.com>
---
 Silicon/Phytium/FT2000-4Pkg/Library/RealTimeClockLib/RealTimeClockLib.c | 5 
+++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git 
a/Silicon/Phytium/FT2000-4Pkg/Library/RealTimeClockLib/RealTimeClockLib.c 
b/Silicon/Phytium/FT2000-4Pkg/Library/RealTimeClockLib/RealTimeClockLib.c
index 1c88958e3bb7..5c3d0cdccff8 100644
--- a/Silicon/Phytium/FT2000-4Pkg/Library/RealTimeClockLib/RealTimeClockLib.c
+++ b/Silicon/Phytium/FT2000-4Pkg/Library/RealTimeClockLib/RealTimeClockLib.c
@@ -307,9 +307,10 @@ LibSetWakeupTime (
   @param[in]    Context Event Context
 
 **/
+STATIC
 VOID
 EFIAPI
-LibRtcVirtualNotifyEvent (
+VirtualNotifyEvent (
   IN EFI_EVENT        Event,
   IN VOID             *Context
   )
@@ -452,7 +453,7 @@ LibRtcInitialize (
   Status = gBS->CreateEventEx (
     EVT_NOTIFY_SIGNAL,
     TPL_NOTIFY,
-    LibRtcVirtualNotifyEvent,
+    VirtualNotifyEvent,
     NULL,
     &gEfiEventVirtualAddressChangeGuid,
     &mRtcVirtualAddrChangeEvent



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109557): https://edk2.groups.io/g/devel/message/109557
Mute This Topic: https://groups.io/mt/101914669/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: 
https://edk2.groups.io/g/devel/leave/9847357/21656/1706620634/xyzzy 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


Reply via email to