Re: [edk2-devel] [edk2-redfish-client][PATCH 3/3] RedfishClientPkg/ConverterLib: Function to remove Redfish unchangeable properties

2024-01-16 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Got it and thanks. I will fix the typo, put your RB then merge this patch. Abner > -Original Message- > From: Nickle Wang > Sent: Tuesday, January 16, 2024 2:20 PM > To: Chang, Abner ; devel@edk2.groups.io > Cc: Igor Kulchytskyy > Subject: RE:

Re: [edk2-devel] [edk2-redfish-client][PATCH 3/3] RedfishClientPkg/ConverterLib: Function to remove Redfish unchangeable properties

2024-01-15 Thread Nickle Wang via groups.io
> I didn't choose ReadOnly is because at BIOS perspective as a provider, we > still > update the read only property defined in schema such as BootOptions. Thus I > thought to use ReadOnly is not quite accurate. How do you think? I see. Thanks for your explanation. Please fix the typos and keep

Re: [edk2-devel] [edk2-redfish-client][PATCH 3/3] RedfishClientPkg/ConverterLib: Function to remove Redfish unchangeable properties

2024-01-15 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] > -Original Message- > From: Nickle Wang > Sent: Tuesday, January 16, 2024 11:18 AM > To: Chang, Abner ; devel@edk2.groups.io > Cc: Igor Kulchytskyy > Subject: RE: [edk2-redfish-client][PATCH 3/3] RedfishClientPkg/ConverterLib: > Function to remove

Re: [edk2-devel] [edk2-redfish-client][PATCH 3/3] RedfishClientPkg/ConverterLib: Function to remove Redfish unchangeable properties

2024-01-15 Thread Nickle Wang via groups.io
I found typos. Please see below. Regards, Nickle > -Original Message- > From: abner.ch...@amd.com > Sent: Friday, January 12, 2024 11:26 AM > To: devel@edk2.groups.io > Cc: Nickle Wang ; Igor Kulchytskyy > Subject: [edk2-redfish-client][PATCH 3/3] RedfishClientPkg/ConverterLib: >

[edk2-devel] [edk2-redfish-client][PATCH 3/3] RedfishClientPkg/ConverterLib: Function to remove Redfish unchangeable properties

2024-01-11 Thread Chang, Abner via groups.io
From: Abner Chang Update RedfishCsCommon.c to add a function to remove Redfish unchangeable properties. Signed-off-by: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy --- .../ConverterLib/include/RedfishCsCommon.h| 20 +++ .../ConverterLib/src/RedfishCsCommon.c| 55