Re: [edk2-devel] [edk2platforms][PATCH v1 1/1] IntelSiliconPkg: Add IntelDieInfoProtocol

2021-10-15 Thread Maciej Czajkowski
Can you add some details on how a producer of this interface would know the values to be assigned here? Does this contain any sort of encoding of generation and Die specific ID in a single UINT64? Yes, in order to have a generic field regardless of the die type and per-generation changes it

Re: [edk2-devel] [edk2platforms][PATCH v1 1/1] IntelSiliconPkg: Add IntelDieInfoProtocol

2021-10-15 Thread Maciej Czajkowski
Can you add some details on how a producer of this interface would know the values to be assigned here? Does this contain any sort of encoding of generation and Die specific ID in a single UINT64? Yes, in order to have a generic field regardless of the die type and per-generation changes it

Re: [edk2-devel] [edk2platforms][PATCH v1 1/1] IntelSiliconPkg: Add IntelDieInfoProtocol

2021-10-15 Thread Maciej Czajkowski
What's the difference between SOC and CPU? SOC die differs from typical CPU die in Intel's chiplet design. What the purpose of "DieIndex"? We want to have an indication to which exactly die given protocol instance is referring to (in example in multi socket/multi PCH designs). Have you

Re: [edk2-devel] [edk2platforms][PATCH v1 1/1] IntelSiliconPkg: Add IntelDieInfoProtocol

2021-10-14 Thread Chaganty, Rangasai V
Maciej, Please add description of the interface in the comment block in line 103, specifically covering the purpose of the interface, the producer and consumer of this interface. DieId's description says "Generation and die specific ID number". Can you add some details on how a producer of

Re: [edk2-devel] [edk2platforms][PATCH v1 1/1] IntelSiliconPkg: Add IntelDieInfoProtocol

2021-10-14 Thread Ni, Ray
+#define DIE_INFO_CPU_GUID \ +{ 0x6E5AF2E3, 0x5D84, 0x48F2, { 0x84, 0x28, 0x99, 0xE4, 0x93, 0x4F, 0x51, 0xE4 }} 1. What's the difference between SOC and CPU? + UINT32 DieIndex; 2. What the purpose of "DieIndex"? + INTEL_DIE_INFO_GET_DIE_NAME_STR GetNameStr;

[edk2-devel] [edk2platforms][PATCH v1 1/1] IntelSiliconPkg: Add IntelDieInfoProtocol

2021-10-07 Thread Maciej Czajkowski
Added IntelDieInfoProtocol header into IntelSiliconPkg tree. The purpose is to have generic and unified interface for getting information about dies installed in the system. It will be implemented by silicon code. Change-Id: I219f238a6245eb81dbaebe6b826304baf3f78dc2 Cc: Ray Ni Cc: Rangasai V