[edk2-devel] [edk2-redfish-client][PATCH 05/13] RedfishClientPkg/RedfishFeatureUtilityLib: ues RedfishHttpLib

2024-02-29 Thread Nickle Wang via groups.io
- Remove RedfishHttpCacheLib and use EDK2 RedfishHttpLib. - Remove RedfishLib. - Remove CreatePayloadToPostResource and CreatePayloadToPatchResource because we no longer need them. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- .../RedfishFeatureUtilityLib.inf

[edk2-devel] [edk2-redfish-client][PATCH 04/13] RedfishClientPkg/RedfishResourceConfigLib: ues RedfishHttpLib

2024-02-29 Thread Nickle Wang via groups.io
Remove RedfishHttpCacheLib and use EDK2 RedfishHttpLib. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- .../EdkIIRedfishResourceConfigLib.inf | 2 +- .../Include/Library/EdkIIRedfishResourceConfigLib.h | 4 ++--

[edk2-devel] [edk2-redfish-client][PATCH 03/13] RedfishClientPkg: ues RedfishHttpLib

2024-02-29 Thread Nickle Wang via groups.io
Use EDK2 RedfishHttpLib to replace RedfishHttpCacheLib and RedfishLib Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- RedfishClientPkg/Include/RedfishCollectionCommon.h | 3 +-- RedfishClientPkg/Include/RedfishResourceCommon.h | 3 +-- 2 files changed, 2 insertions(+), 4

[edk2-devel] [edk2-redfish-client][PATCH 02/13] RedfishClientPkg: remove RedfishHttpCacheLib

2024-02-29 Thread Nickle Wang via groups.io
Remove RedfishHttpCacheLib and use EDK2 RedfishHttpLib. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- RedfishClientPkg/RedfishClientPkg.dec | 1 - RedfishClientPkg/RedfishClientLibs.dsc.inc| 2 +- RedfishClientPkg/RedfishClientPkg.dsc | 1 -

[edk2-devel] [edk2-redfish-client][PATCH 01/13] RedfishClientPkg/.github: do not run uncrustify to deleted file.

2024-02-29 Thread Nickle Wang via groups.io
Check to see if file exists or not before running uncrustify. The file in change list may be a deleted file. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- .github/workflows/uncrustify-check.sh | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff

[edk2-devel] [edk2-redfish-client][PATCH 00/13] use Redfish HTTP protocol

2024-02-29 Thread Nickle Wang via groups.io
Redfish HTTP protocol is introduced to edk2 RedfishPkg. Update RedfishClientPkg to use RedfishHttpLib. And remove the use of RedfishHttpCacheLib. I also replace several functions from RedfishLib with the function provided in RedfishHttpLib. In this way, there is no dependency on RedfishLib

Re: [edk2-devel] [edk2-redfish-client][PATCH] edk2-Redfish-client: Clarify HTTP method used for provisioning

2024-02-28 Thread Mike Maslenkin
Reviewed-by: Mike Maslenkin Regards, Mike. On Mon, Feb 26, 2024 at 7:55 AM wrote: > > From: Abner Chang > > Clarify the HTTP method that is used to provision BIOS > managed Redfish resource. > > Signed-off-by: Abner Chang > Cc: Nickle Wang > Cc: Igor Kulchytskyy > Cc: Mike Maslenkin > ---

Re: [edk2-devel] [edk2][PATCH V2 1/2] ArmPkg/ArmGicArchLib: Add macros for SPI and extended SPI ranges

2024-02-28 Thread Sami Mujawar
+Resending with email address for maintainers. Hi Ard, Leif, This patch adds macros that can be used to validate that the SPI ranges are valid. These have been define here so that we do not duplicate it at multiple places. Can you let me know if I can merge this patch, please? Regards, Sami

Re: [edk2-devel] [edk2][PATCH V2 1/2] ArmPkg/ArmGicArchLib: Add macros for SPI and extended SPI ranges

2024-02-28 Thread Sami Mujawar
Hi Ard, Leif, This patch adds macros that can be used to validate that the SPI ranges are valid. These have been define here so that we do not duplicate it at multiple places. Can you let me know if I can merge this patch, please? Regards, Sami Mujawar -=-=-=-=-=-=-=-=-=-=-=- Groups.io

Re: [edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg/ConverterLib: check JSON value type

2024-02-27 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Hi Nickle, As this change is in the autogenerate source files. We have to update the script here: https://github.com/DMTF/Redfish-Schema-C-Struct-Generator Not sure if you have access to this repo, however I am pleased inviting you to update the script on DMTF

Re: [edk2-devel] [edk2 Patch 1/1] BaseTools: Syntax warning invalid escape sequence \C

2024-02-27 Thread Rebecca Cran
Merged as 3e91e421365027ee3e655feab33c67a4f544c777. -- Rebecca Cran On 2/6/24 00:02, Jayaprakash N wrote: REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4666 This commit fixes the issue reported through BZ4666. The Syntax warning related to invalid escape sequence for \C is seen on

Re: [edk2-devel] [edk2-redfish-client][PATCH] edk2-Redfish-client: Clarify HTTP method used for provisioning

2024-02-27 Thread Igor Kulchytskyy via groups.io
Reviewed-by: Igor Kulchytskyy Regards, Igor -Original Message- From: abner.ch...@amd.com Sent: Sunday, February 25, 2024 11:55 PM To: devel@edk2.groups.io Cc: Nickle Wang ; Igor Kulchytskyy ; Mike Maslenkin Subject: [EXTERNAL] [edk2-redfish-client][PATCH] edk2-Redfish-client: Clarify

Re: [edk2-devel] [edk2-test v2] SctPkg: Fixed a pinter error in DevicePathFromTextBBTestCoverage.c

2024-02-27 Thread Heinrich Schuchardt
On 27.02.24 07:37, Chao Li wrote: DevicePathFromTextBBTextCoverage.c function CreateDNSDeviceNode has a bug, code: SctStrToIPv4Addr (, (EFI_IPv4_ADDRESS *)(DNS + sizeof (DNS_DEVICE_PATH))); DNS is a pointer, which is increased by a structure size and converted to EFI_IPv4_ADDRESS*, which will

[edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg/ConverterLib: check JSON value type

2024-02-27 Thread Nickle Wang via groups.io
Check and see if JSON object type is desired type before getting its value. According to the Redfish schema, attribute value can be null value. Add this error handling to avoid system assertion while getting attribute value. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc:

Re: [edk2-devel] [edk2-test v2] SctPkg: Fixed a pinter error in DevicePathFromTextBBTestCoverage.c

2024-02-27 Thread G Edhaya Chandran
The patch is upstreamed through the commit: https://github.com/tianocore/edk2-test/commit/cabb98d44be94e7547605435a0be7c4946d10f8b -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116022): https://edk2.groups.io/g/devel/message/116022 Mute

Re: [edk2-devel] [edk2-test v2] SctPkg: Fixed a pinter error in DevicePathFromTextBBTestCoverage.c

2024-02-27 Thread Chao Li
, 2024 1:34 PM *To:* devel@edk2.groups.io; G Edhaya Chandran *Subject:* Re: [edk2-devel] [edk2-test v2] SctPkg: Fixed a pinter error in DevicePathFromTextBBTestCoverage.c Hi Edhaya, Thanks for you review, I have created a PR on Github: https://github.com/tianocore/edk2-test/pull/87 Thanks

Re: [edk2-devel] [edk2-test v2] SctPkg: Fixed a pinter error in DevicePathFromTextBBTestCoverage.c

2024-02-27 Thread G Edhaya Chandran
Hi Li Chao, As per the maintenance process, I will raise a PR on your behalf based on your patch. And will later close your PR. With Warm Regards, Edhay From: Chao Li Sent: Tuesday, February 27, 2024 1:34 PM To: devel@edk2.groups.io; G Edhaya Chandran Subject: Re: [edk2-devel] [edk2

Re: [edk2-devel] [edk2-test v2] SctPkg: Fixed a pinter error in DevicePathFromTextBBTestCoverage.c

2024-02-27 Thread Chao Li
Hi Edhaya, Thanks for you review, I have created a PR on Github: https://github.com/tianocore/edk2-test/pull/87 Thanks, Chao On 2024/2/27 15:50, G Edhaya Chandran wrote: Hi Li Chao, Thank you for the solution. Reviewed OK. Reviewed-by: G Edhaya Chandran -=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-test v2] SctPkg: Fixed a pinter error in DevicePathFromTextBBTestCoverage.c

2024-02-26 Thread G Edhaya Chandran
Hi Li Chao, Thank you for the solution. Reviewed OK. Reviewed-by: G Edhaya Chandran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116007): https://edk2.groups.io/g/devel/message/116007 Mute This Topic:

[edk2-devel] [edk2-test v2] SctPkg: Fixed a pinter error in DevicePathFromTextBBTestCoverage.c

2024-02-26 Thread Chao Li
DevicePathFromTextBBTextCoverage.c function CreateDNSDeviceNode has a bug, code: SctStrToIPv4Addr (, (EFI_IPv4_ADDRESS *)(DNS + sizeof (DNS_DEVICE_PATH))); DNS is a pointer, which is increased by a structure size and converted to EFI_IPv4_ADDRESS*, which will point to an unknown address. So fix

Re: [edk2-devel] [edk2-redfish-client][PATCH] edk2-Redfish-client: Clarify HTTP method used for provisioning

2024-02-26 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Hi @Igor Kulchytskyy and @Mike Maslenkin, I would like to wait until your review to make sure we all agree with the usage of HTTP methods in edk2 Redfish implementation. Thanks Abner > -Original Message- > From: Nickle Wang > Sent: Monday, February

Re: [edk2-devel] [edk2-redfish-client][PATCH] edk2-Redfish-client: Clarify HTTP method used for provisioning

2024-02-26 Thread Nickle Wang via groups.io
Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: abner.ch...@amd.com > Sent: Monday, February 26, 2024 12:55 PM > To: devel@edk2.groups.io > Cc: Nickle Wang ; Igor Kulchytskyy ; > Mike Maslenkin > Subject: [edk2-redfish-client][PATCH] edk2-Redfish-client:

[edk2-devel] [edk2-redfish-client][PATCH] edk2-Redfish-client: Clarify HTTP method used for provisioning

2024-02-25 Thread Chang, Abner via groups.io
From: Abner Chang Clarify the HTTP method that is used to provision BIOS managed Redfish resource. Signed-off-by: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Cc: Mike Maslenkin --- RedfishClientPkg/Readme.md| 35 ---

Re: [edk2-devel] edk2-test: bug in DevicePathFromTextBBTestCoverage.c

2024-02-25 Thread Laszlo Ersek
Hello Charles, On 2/24/24 17:01, Charles Hyde wrote: > There is a bug in the following source file: > > uefi-sct\ > SctPkg\ > TestCase\ > UEFI\ >EFI\ > Protocol\ > DevicePathFromText\ > BlackBoxTest\ >

Re: [edk2-devel] [edk2-InfSpecification PATCH 0/2] README: INF_VERSION >= 1.30: declare ProcessLibraryCon...() for SEC modules

2024-02-24 Thread Laszlo Ersek
On 2/24/24 22:28, Laszlo Ersek wrote: > The first patch is a minor cleanup, the new feature is documented in the > second patch. > > Rendered version: > > > https://lersek.github.io/edk2-InfSpecification/ProcessLibraryConstructorList-SEC-991/ > >

Re: [edk2-devel] [edk2-BuildSpecification PATCH 0/3] AutoGen.h: declare ProcessLibraryConstructorList() for SEC modules

2024-02-24 Thread Laszlo Ersek
On 2/24/24 22:23, Laszlo Ersek wrote: > The first two patches are cleanups, the new feature is documented in the > third patch. > > I managed to render these updates to public HTML, following > > (a) Mike's note from October 2020: > > https://edk2.groups.io/g/devel/message/66426 > msgid >

[edk2-devel] [edk2-InfSpecification PATCH 2/2] README: INF_VERSION >= 1.30: declare ProcessLibraryCon...() for SEC modules

2024-02-24 Thread Laszlo Ersek
Simply bump INF_VERSION (spec release version) as a fence for the feature AutoGen.h: declare ProcessLibraryConstructorList() for SEC modules described comprehensively in the Build spec. (The INF spec does not seem to have an explicit compatibility table tied to INF_VERSION, except this

[edk2-devel] [edk2-InfSpecification PATCH 1/2] README.md: fix revision history whitespace

2024-02-24 Thread Laszlo Ersek
Fix the right-hand-side whitespace in the revision history table. Cc: Bob Feng Cc: Liming Gao Cc: Michael D Kinney Cc: Rebecca Cran Cc: Yuwei Chen Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=991 Signed-off-by: Laszlo Ersek --- README.md | 4 ++-- 1 file changed, 2 insertions(+), 2

[edk2-devel] [edk2-InfSpecification PATCH 0/2] README: INF_VERSION >= 1.30: declare ProcessLibraryCon...() for SEC modules

2024-02-24 Thread Laszlo Ersek
The first patch is a minor cleanup, the new feature is documented in the second patch. Rendered version: https://lersek.github.io/edk2-InfSpecification/ProcessLibraryConstructorList-SEC-991/ https://github.com/lersek/edk2-InfSpecification/actions/workflows/gitbook-action.yml Cc: Bob Feng

[edk2-devel] [edk2-BuildSpecification PATCH 2/3] AutoGen.c: list the SEC module type for / (VOID)

2024-02-24 Thread Laszlo Ersek
Minimally as of edk2 commit edc6681206c1, the - CreateLibraryConstructorCode() - CreateLibraryDestructorCode() methods in "BaseTools/Source/Python/AutoGen/GenC.py" generate declarations and calls of the form - (VOID) - (VOID) (respectively), for pre-requisite libraries that have type BASE or

[edk2-devel] [edk2-BuildSpecification PATCH 3/3] AutoGen.h: declare ProcessLibraryConstructorList() for SEC modules

2024-02-24 Thread Laszlo Ersek
Most module types have standardized entry point function prototypes. They are declared in headers like - MdePkg/Include/Library/PeiCoreEntryPoint.h - MdePkg/Include/Library/PeimEntryPoint.h - MdePkg/Include/Library/DxeCoreEntryPoint.h - MdePkg/Include/Library/UefiDriverEntryPoint.h -

[edk2-devel] [edk2-BuildSpecification PATCH 0/3] AutoGen.h: declare ProcessLibraryConstructorList() for SEC modules

2024-02-24 Thread Laszlo Ersek
The first two patches are cleanups, the new feature is documented in the third patch. I managed to render these updates to public HTML, following (a) Mike's note from October 2020: https://edk2.groups.io/g/devel/message/66426 msgid (b) the github access token / project secrets steps at

[edk2-devel] [edk2-BuildSpecification PATCH 1/3] README.md: fix revision history whitespace

2024-02-24 Thread Laszlo Ersek
Fix the right-hand-side whitespace in the revision history table. Cc: Bob Feng Cc: Liming Gao Cc: Michael D Kinney Cc: Rebecca Cran Cc: Yuwei Chen Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=991 Signed-off-by: Laszlo Ersek --- README.md | 4 ++-- 1 file changed, 2 insertions(+), 2

[edk2-devel] edk2-test: bug in DevicePathFromTextBBTestCoverage.c

2024-02-24 Thread Charles Hyde
There is a bug in the following source file: uefi-sct\ SctPkg\ TestCase\ UEFI\ EFI\ Protocol\ DevicePathFromText\ BlackBoxTest\ DevicePathFromTextBBTestCoverage.c Lines 1737, 1738, 1742, and

Re: [edk2-devel] [edk2-redfish-client][PATCH v2 2/4] RedfishClientPkg: refine RedfishExternalResourceResourceFeatureCallback

2024-02-23 Thread Nickle Wang via groups.io
Thanks Mike! I merged the pull request. Regards, Nickle From: M M Sent: Friday, February 23, 2024 7:32 PM To: Nickle Wang Cc: devel@edk2.groups.io; Abner Chang ; Igor Kulchytskyy Subject: Re: [edk2-devel] [edk2-redfish-client][PATCH v2 2/4] RedfishClientPkg: refine

Re: [edk2-devel] [edk2-redfish-client][PATCH v2 2/4] RedfishClientPkg: refine RedfishExternalResourceResourceFeatureCallback

2024-02-23 Thread Mike Maslenkin
uary 22, 2024 10:14 AM > > To: Mike Maslenkin > <mailto:mike.maslen...@gmail.com>>; devel@edk2.groups.io > > <mailto:devel@edk2.groups.io> > > Cc: Abner Chang mailto:abner.ch...@amd.com>>; Igor > > Kulchytskyy mailto:ig...@ami.com>> > > Subjec

Re: [edk2-devel] [edk2-redfish-client][PATCH v2 2/4] RedfishClientPkg: refine RedfishExternalResourceResourceFeatureCallback

2024-02-23 Thread Nickle Wang via groups.io
Nickle > -Original Message- > From: devel@edk2.groups.io On Behalf Of Nickle Wang > via groups.io > Sent: Thursday, February 22, 2024 10:14 AM > To: Mike Maslenkin ; devel@edk2.groups.io > Cc: Abner Chang ; Igor Kulchytskyy > Subject: Re: [edk2-devel] [edk2-r

[edk2-devel] [edk2-platforms][PATCH V3] Silicon/Marvell: Update for UEFI spec v2.9 - mantis #1866

2024-02-22 Thread Gahan
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4689 Bug 4689 - GetInfo() of Adapter Information Protocol should have a provision for IHV to return no data for UEFI Spec compliance 2.9 [mantis #1866] Cc: Marcin Wojtas Cc: Leif Lindholm Signed-off-by: Gahan Saraiya ---

Re: [edk2-devel] [edk2-redfish-client][PATCH v2 2/4] RedfishClientPkg: refine RedfishExternalResourceResourceFeatureCallback

2024-02-21 Thread Nickle Wang via groups.io
Thanks for addressing my comment. Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: Mike Maslenkin > Sent: Thursday, February 22, 2024 4:06 AM > To: devel@edk2.groups.io > Cc: Mike Maslenkin ; Nickle Wang > ; Abner Chang ; Igor Kulchytskyy > > Subject:

Re: [edk2-devel] [edk2-platforms 1/1] Platform/Loongson: loongarch supports parsing multi-chip flash

2024-02-21 Thread Chao Li
Reviewed-by: Chao Li Thanks, Chao On 2024/2/19 10:03, xianglai wrote: The current implementation of loongarch NorFlashQemuLib is to parse fdt and think that the first flash address resolved to the NVRAM space, with the evolution of qemu code, loongarch uses the first flash to store UEFI code

[edk2-devel] [edk2-redfish-client][PATCH v2 4/4] RedfishClientPkg: use Json value from a function argument

2024-02-21 Thread Mike Maslenkin
This patch replaces value Private->Json with Json used as second argument for RedfishIdentifyResource(). Currently Json argument is not used at all and the pattern for caller side is: Status = RedfishIdentifyResourceCommon (Private, Private->Json); So in scope of RedfishIdentifyResourceCommon

[edk2-devel] [edk2-redfish-client][PATCH v2 3/4] RedfishClientPkg/Bios: fix leak of GetPendingSettings URI.

2024-02-21 Thread Mike Maslenkin
Cc: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Signed-off-by: Mike Maslenkin Reviewed-by: Abner Chang Reviewed-by: Nickle Wang --- .../Features/Bios/v1_0_9/Dxe/BiosDxe.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git

[edk2-devel] [edk2-redfish-client][PATCH v2 1/4] RedfishClientPkg/RedfishFeatureUtilityLib: fix memory leak on error path

2024-02-21 Thread Mike Maslenkin
Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nickle Wang Signed-off-by: Mike Maslenkin Reviewed-by: Abner Chang Reviewed-by: Nickle Wang --- .../Library/RedfishFeatureUtilityLib/RedfishFeatureUtilityLib.c | 1 + 1 file changed, 1 insertion(+) diff --git

[edk2-devel] [edk2-redfish-client][PATCH v2 2/4] RedfishClientPkg: refine RedfishExternalResourceResourceFeatureCallback

2024-02-21 Thread Mike Maslenkin
Use local variable for BiosUri passed to HandleResource() to avoid problems in case of Private->Uri is overriden down the call stack. Suggested-by: Nickle Wang Cc: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Signed-off-by: Mike Maslenkin ---

[edk2-devel] [edk2-redfish-client][PATCH v2 0/4] RedfishClientPkg: fix memory leaks and refine code

2024-02-21 Thread Mike Maslenkin
This set contains a trivial fix for a leak reviewed on Feb 1 [1] and a fix for а leak discussed in [2] PR: https://github.com/tianocore/edk2-redfish-client/pull/76 [1] https://edk2.groups.io/g/devel/message/114925 [2] https://edk2.groups.io/g/devel/message/114765
 v2: in commit message put Cc

[edk2-devel] [edk2-platforms][PATCH V3] OptionRomPkg: Update for UEFI spec v2.9 - mantis #1866

2024-02-20 Thread Gahan
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4689 Bug 4689 - GetInfo() of Adapter Information Protocol should have a provision for IHV to return no data for UEFI Spec compliance 2.9 [mantis #1866] Cc: Ray Ni Signed-off-by: Gahan Saraiya --- Drivers/OptionRomPkg/UndiRuntimeDxe/Undi32.h

[edk2-devel] [edk2-platforms][PATCH V3] MinPlatformPkg: Update for UEFI spec v2.9 - mantis #1866

2024-02-20 Thread Gahan
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4689 Bug 4689 - GetInfo() of Adapter Information Protocol should have a provision for IHV to return no data for UEFI Spec compliance 2.9 [mantis #1866] Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Cc: Eric Dong Signed-off-by: Gahan

[edk2-devel] [edk2-redfish-client][PATCH 0/4] RedfishClientPkg: fix memory leaks and refine code

2024-02-20 Thread Mike Maslenkin
This set contains a trivial fix for a leak reviewed on Feb 1 [1] and a fix for а leak discussed in [2]. PR: https://github.com/tianocore/edk2-redfish-client/pull/76 [1] https://edk2.groups.io/g/devel/message/114925 [2] https://edk2.groups.io/g/devel/message/114765
 Signed-off-by: Mike Maslenkin

Re: [edk2-devel] [edk2-test][PATCH v1 0/4] uefi-sct/SctPkg: Add SCT Documents

2024-02-20 Thread G Edhaya Chandran
Thank you Samer. The test case spec is consolidated and upstreamed by:  https://github.com/tianocore/edk2-test/commit/f999690054b56780f5efbe0999507d7176bd87f6 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115661):

Re: [edk2-devel] [edk2-redfish-client][PATCH V3] RedfishClientPkg: Readme.md update

2024-02-19 Thread Nickle Wang via groups.io
Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: devel@edk2.groups.io On Behalf Of Chang, Abner > via groups.io > Sent: Monday, February 5, 2024 4:36 PM > To: devel@edk2.groups.io > Cc: Nickle Wang ; Igor Kulchytskyy > Subject: Re: [edk2

Re: [edk2-devel] [edk2-platforms PATCH 5/6] LoongArchQemuPkg: fix SEC ProcessLibraryConstructorList() prototype

2024-02-19 Thread Laszlo Ersek
On 2/19/24 03:21, Chao Li wrote: > Hi Laszlo, > > I have tested: > > 1. Follow edk2 series patch 3 changes to > BaseTools/Source/Python/AutoGen/GenC.py. > > 2. Follow edk2-platforms series patch 5 changes to > edk2-platforms/Platform/Loongson/LoongArchQemuPkg/Sec/SecMain.c. > > After the

Re: [edk2-devel] [edk2-stable202402 PATCH 1/2] UefiCpuPkg/PiSmmCpuDxeSmm: distinguish GetSmBase() failure modes

2024-02-19 Thread duntan
...@apple.com) ; Gao, Liming Cc: Tan, Dun ; Gerd Hoffmann ; Kumar, Rahul R ; Ni, Ray Subject: Re: [edk2-devel] [edk2-stable202402 PATCH 1/2] UefiCpuPkg/PiSmmCpuDxeSmm: distinguish GetSmBase() failure modes On 2/14/24 18:26, Kinney, Michael D wrote: > Merged: https://github.com/tianocore/edk2/p

Re: [edk2-devel] [edk2-platforms PATCH 5/6] LoongArchQemuPkg: fix SEC ProcessLibraryConstructorList() prototype

2024-02-18 Thread Chao Li
Hi Laszlo, I have tested: 1. Follow edk2 series patch 3 changes to BaseTools/Source/Python/AutoGen/GenC.py. 2. Follow edk2-platforms series patch 5 changes to edk2-platforms/Platform/Loongson/LoongArchQemuPkg/Sec/SecMain.c. After the changes, I have built and tested, and it works fine.

[edk2-devel] [edk2-platforms 0/1] loongarch supports parsing multi-chip flash

2024-02-18 Thread xianglai
The current implementation of loongarch NorFlashQemuLib is to parse fdt and think that the first flash address resolved to the NVRAM space, with the evolution of qemu code, loongarch uses the first flash to store UEFI code and the second flash as NVRAM space, so NorFlashQemuLib needs to be able to

[edk2-devel] [edk2-platforms 1/1] Platform/Loongson: loongarch supports parsing multi-chip flash

2024-02-18 Thread xianglai
The current implementation of loongarch NorFlashQemuLib is to parse fdt and think that the first flash address resolved to the NVRAM space, with the evolution of qemu code, loongarch uses the first flash to store UEFI code and the second flash as NVRAM space, so NorFlashQemuLib needs to be able to

[edk2-devel] [edk2-redfish-client][PATCH 2/2] RedfishClientPkg: fix memory leak in ConverterLib

2024-01-26 Thread Mike Maslenkin
The memory returned by json_dumps() must be freed. Signed-off-by: Mike Maslenkin Cc: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy --- RedfishClientPkg/ConverterLib/src/RedfishCsCommon.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git

[edk2-devel] [edk2-redfish-client][PATCH 1/2] RedfishClientPkg: fix uninitialized variable build error

2024-01-26 Thread Mike Maslenkin
Variable 'Status' may be used uninitialized in this function [-Werror=maybe-uninitialized] Signed-off-by: Mike Maslenkin Cc: Abner Chang Cc: Igor Kulchytskyy Reviewed-by: Nickle Wang --- RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c | 1 + 1 file changed, 1 insertion(+)

[edk2-devel] [edk2-redfish-client][PATCH 0/2] RedfishClientPkg: fix memory leak in ConverterLib

2024-01-26 Thread Mike Maslenkin
This patchset contains a trivial fix for memory leak in ConverterLib Also patch 1 is a resend of the same patch sent to list on 4th Jan with added Rb (https://edk2.groups.io/g/devel/message/113162). PR: https://github.com/tianocore/edk2-redfish-client/pull/74 Signed-off-by: Mike Maslenkin Cc:

Re: [edk2-devel] [edk2-redfish-client][PATCH V2] RedfishClientPkg/FeatureDriver: ComputerSystem_1_13_0 driver

2024-01-26 Thread Mike Maslenkin
ou Mike for looking into this patch. > Abner > >> -Original Message- >> From: M M >> Sent: Friday, January 26, 2024 10:11 PM >> To: Chang, Abner >> Cc: devel@edk2.groups.io; Nickle Wang ; Igor >> Kulchytskyy >> Subject: Re: [edk2-devel] [edk

Re: [edk2-devel] [edk2-redfish-client][PATCH V2] RedfishClientPkg/FeatureDriver: ComputerSystem_1_13_0 driver

2024-01-26 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] It is no problem.  Thank you Mike for looking into this patch. Abner > -Original Message- > From: M M > Sent: Friday, January 26, 2024 10:11 PM > To: Chang, Abner > Cc: devel@edk2.groups.io; Nickle Wang ; Igor > Kulchytskyy > Sub

Re: [edk2-devel] [edk2-redfish-client][PATCH V2] RedfishClientPkg/FeatureDriver: ComputerSystem_1_13_0 driver

2024-01-26 Thread Mike Maslenkin
te->Uri is defined as EFI_STRING, or > I miss something? > > Thanks > Abner > >> -Original Message- >> From: M M >> Sent: Friday, January 26, 2024 9:55 PM >> To: devel@edk2.groups.io; Nickle Wang >> Cc: Chang, Abner ; Igor Kulchytsk

Re: [edk2-devel] [edk2-redfish-client][PATCH V2] RedfishClientPkg/FeatureDriver: ComputerSystem_1_13_0 driver

2024-01-26 Thread Chang, Abner via groups.io
; Cc: Chang, Abner ; Igor Kulchytskyy > > Subject: Re: [edk2-devel] [edk2-redfish-client][PATCH V2] > RedfishClientPkg/FeatureDriver: ComputerSystem_1_13_0 driver > > Caution: This message originated from an External Source. Use proper caution > when opening attachments, clicking

Re: [edk2-devel] [edk2-redfish-client][PATCH V2] RedfishClientPkg/FeatureDriver: ComputerSystem_1_13_0 driver

2024-01-26 Thread Mike Maslenkin
Hi Abner, > On 26. 1. 2024., at 05:20, Nickle Wang via groups.io > wrote: > > Hi Abner, > > Same minor issue as 1_5_0. Please add "%a:" to below DEBUG call. > >> + DEBUG ((DEBUG_MANAGEABILITY, " No platform Redfish ConfigureLang >> found for %s\n", __func__, Private->Uri)); > >

Re: [edk2-devel] [edk2-redfish-client][PATCH V3] RedfishClientPkg/FeatureDriver: ComputerSystem_1_13_0 driver

2024-01-25 Thread Nickle Wang via groups.io
Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: abner.ch...@amd.com > Sent: Friday, January 26, 2024 10:32 AM > To: devel@edk2.groups.io > Cc: Nickle Wang ; Igor Kulchytskyy > Subject: [edk2-redfish-client][PATCH V3] RedfishClientPkg/FeatureDriver: >

Re: [edk2-devel] [edk2-redfish-client][PATCH V2] RedfishClientPkg/FeatureDriver: ComputerSystem_1_5_0 driver

2024-01-25 Thread Nickle Wang via groups.io
Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: abner.ch...@amd.com > Sent: Friday, January 26, 2024 10:29 AM > To: devel@edk2.groups.io > Cc: Nickle Wang ; Igor Kulchytskyy > Subject: [edk2-redfish-client][PATCH V2] RedfishClientPkg/FeatureDriver: >

Re: [edk2-devel] [edk2-redfish-client][PATCH V2] RedfishClientPkg/FeatureDriver: ComputerSystem_1_13_0 driver

2024-01-25 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Thanks Nickle, I just sent out the updates. Abner > -Original Message- > From: Nickle Wang > Sent: Friday, January 26, 2024 10:21 AM > To: devel@edk2.groups.io; Chang, Abner > Cc: Igor Kulchytskyy > Subject: RE: [edk2-devel] [e

[edk2-devel] [edk2-redfish-client][PATCH V3] RedfishClientPkg/FeatureDriver: ComputerSystem_1_13_0 driver

2024-01-25 Thread Chang, Abner via groups.io
From: Abner Chang Initial version of edk2 Redfish feature of Redfish schema ComputerSystem_1_13_0. This driver handles ComputerSystem Boot properties but not all. Signed-off-by: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy --- .../v1_13_0/Dxe/ComputerSystemDxe.inf | 53 ++

[edk2-devel] [edk2-redfish-client][PATCH V2] RedfishClientPkg/FeatureDriver: ComputerSystem_1_5_0 driver

2024-01-25 Thread Chang, Abner via groups.io
From: Abner Chang Update Redfish ComputerSystem_1_5_0 feature driver to align the implementation with latest code. This driver handles all of ComputerSystem v1_5_0 properties and incorporate with Redfish simualtor. Signed-off-by: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy ---

Re: [edk2-devel] [edk2-redfish-client][PATCH V2] RedfishClientPkg/FeatureDriver: ComputerSystem_1_13_0 driver

2024-01-25 Thread Nickle Wang via groups.io
@edk2.groups.io On Behalf Of Chang, Abner > via groups.io > Sent: Friday, January 26, 2024 9:00 AM > To: devel@edk2.groups.io > Cc: Nickle Wang ; Igor Kulchytskyy > Subject: [edk2-devel] [edk2-redfish-client][PATCH V2] > RedfishClientPkg/FeatureDriver: ComputerSystem_1_13_0

Re: [edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg/FeatureDriver: ComputerSystem_1_5_0 driver

2024-01-25 Thread Nickle Wang via groups.io
Hi Abner, I found one minor issue: > if (ConfigLangList.Count == 0) { > + DEBUG ((DEBUG_MANAGEABILITY, " No platform Redfish ConfigureLang > + found for %s\n", __func__, Private->Uri)); >return EFI_SUCCESS; "%a:" is missing above. Regards, Nickle > -Original

[edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg/FeatureDriver: ComputerSystem_1_5_0 driver

2024-01-25 Thread Chang, Abner via groups.io
From: Abner Chang Update Redfish ComputerSystem_1_5_0 feature driver to align the implementation with latest code. This driver handles all of ComputerSystem v1_5_0 properties and incorporate with Redfish simualtor. Signed-off-by: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy ---

[edk2-devel] [edk2-redfish-client][PATCH V2] RedfishClientPkg/FeatureDriver: ComputerSystem_1_13_0 driver

2024-01-25 Thread Chang, Abner via groups.io
From: Abner Chang Initial version of edk2 Redfish feature of Redfish schema ComputerSystem_1_13_0. This driver handles ComputerSystem Boot properties but not all. Signed-off-by: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy --- .../v1_13_0/Dxe/ComputerSystemDxe.inf | 53 ++

Re: [edk2-devel][edk2-platforms][PATCH v4] MinPlatformPkg: Support SecFspWrapperPlatformSecLib in X64

2024-01-25 Thread Chaganty, Rangasai V
; S, Ashraf Ali ; Duggapu, Chinni B ; Gao, Liming Subject: [edk2-devel][edk2-platforms][PATCH v4] MinPlatformPkg: Support SecFspWrapperPlatformSecLib in X64 https://bugzilla.tianocore.org/show_bug.cgi?id=4623 1.Added PeiCoreEntry.nasm, SecEntry.nasm and Stack.nasm for X64. 2.Made changes

Re: [edk2-devel] [edk2-platforms][PATCH V2 4/8] Platform/Sgi: Add ACPI tables for RD-Fremont platform

2024-01-25 Thread Prabin CA
Thanks, resolved. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114456): https://edk2.groups.io/g/devel/message/114456 Mute This Topic: https://groups.io/mt/103685116/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe:

Re: [edk2-devel] [edk2-platforms][PATCH V2 3/8] Platform/Sgi: Introduce a flag to enable PCIe support for RD Platforms

2024-01-25 Thread Prabin CA
Hi Pierre, Since, Pcie is not enabled in the platform we have to suppress the Pcie related modules while in booting, other wise it cause the boot hazard to the platforms. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114455):

Re: [edk2-devel] [edk2-platforms][PATCH V2 0/8] Platform/Sgi: Add support for RD-Fremont platform

2024-01-25 Thread Prabin CA
Hi Pierre, Thanks for reviewing it, I have followed the links you send to correct the signed-off. Please review the patches. This patch have dependencies with https://edk2.groups.io/g/devel/message/113732. I had already mentioned same in the cover letter of this Patches too.

[edk2-devel] [edk2-platforms][PATCH v3 8/8] Platform/Sgi: Add CPPC support for RD-Fremont platform

2024-01-25 Thread Prabin CA
Enable ACPI CPPC mechanism for RD-Fremont as defined by the ACPI specification. The implementation uses AMU registers accessible as Fixed-feature Hardware (FFixedHW) for monitoring the performance. Non-secure SCMI fastchannels are used to communicate with LCP to set the desired performance.

[edk2-devel] [edk2-platforms][PATCH v3 7/8] Platform/Sgi: Low Power Idle States for RD-Fremont

2024-01-25 Thread Prabin CA
RD-Fremont platform supports two LPI states, LPI1 (Standby WFI) and LPI3 (Power-down). The cluster supports LPI2 (Power-down) state. The LPI implementation also supports combined power state for core and cluster. Signed-off-by: Prabin CA ---

[edk2-devel] [edk2-platforms][PATCH v3 6/8] Platform/Sgi: Extend SMBIOS support for RD-Fremont

2024-01-25 Thread Prabin CA
Extend the SMBIOS support for RD-Fremont platform. RD-Fremont is a 16 core platform with Poseidon CPU. Each of the CPUs include 64KB L1 Data cache, 64KB L1 Instruction cache and 2MB L2 cache. The platform also includes system level cache of 32MB and 8GB of RAM. Signed-off-by: Prabin CA ---

[edk2-devel] [edk2-platforms][PATCH v3 5/8] Platform/Sgi: Add initial support for RD-Fremont platform

2024-01-25 Thread Prabin CA
The RD-Fremont fixed virtual platform simulates 16 CPUs and 8GB of RAM. Add initial support for this platform by adding the required platform build configuration files. This platform has considerable differences in its memory map compared to its predecessors. So add a corresponding memory map file

[edk2-devel] [edk2-platforms][PATCH v3 4/8] Platform/Sgi: Add ACPI tables for RD-Fremont platform

2024-01-25 Thread Prabin CA
From: Shriram K RD-Fremont is the next platform in the Arm's reference design platform series. This platform includes 32 CPUs but the fixed virtual platform (FVP) simulates 16 CPUs of the platform. There is one CPU per cluster in the system and so the FVP simulates 16 clusters. In preparation

[edk2-devel] [edk2-platforms][PATCH v3 3/8] Platform/Sgi: Introduce a flag to enable PCIe support for RD Platforms

2024-01-25 Thread Prabin CA
Introducing a flag called PCIE_ENABLE, which can be set to TRUE or FALSE from the respective .dsc files to enable or disable the PCIe support. As not all reference design platforms have PCIe support enabled, this flag is introduced. Signed-off-by: Prabin CA ---

[edk2-devel] [edk2-platforms][PATCH v3 2/8] Platform/Sgi: Refactor system memory base and size definitions

2024-01-25 Thread Prabin CA
In preparation of adding the next generation of reference design platform that have different memory map, refactor the PcdSystemMemoryBase and PcdSystemMemorySize PCD definitions from the common PCD definitions file into the various platform generation specific memory map PCD definitions file.

[edk2-devel] [edk2-platforms][PATCH v3 1/8] Platform/Sgi: Update the datatype of PcdSmmuBase from u32 to u64

2024-01-25 Thread Prabin CA
From: Vivek Gautam On RD-N2 and previous generation platforms, the base address was within 32-bit region. However, on upcoming platforms, the SMMUv3 base address is beyond 32-bit address region. So, update the datatype of SMMUv3 base PCD. Signed-off-by: Prabin CA ---

[edk2-devel] [edk2-platforms][PATCH v3 0/8] Platform/Sgi: Add support for RD-Fremont platform

2024-01-25 Thread Prabin CA
Changes since V2: - Removed author's signed-off on the patches, which is owned by another author. Changes since V1: - Corrected memory map in the DSDT file. This patch series introduce support for RD-Fremont reference design platform. This platform includes 32 CPUs, but the fixed virtual

[edk2-devel] [edk2-platforms][PATCH v4 6/6] Platform/Sgi: Extend SMBIOS support for RD-V2 platform

2024-01-25 Thread Prabin CA
From: Pranav Madhu The Neoverse RD-V2 FVP platform includes 16 CPUs and each CPU has 64KB of L1 instruction/data cache, 2MB of L2 cache and 32MB of system level cache. Extend the SMBIOS support for RD-V2 platform with this configuration and reuse rest of the RD-N2 SMBIOS configuration for the

[edk2-devel] [edk2-platforms][PATCH v4 5/6] Platform/Sgi: Define RD-V2 platform id values

2024-01-25 Thread Prabin CA
From: Pranav Madhu Add RD-V2 platform identification values including the part number and configuration number. This information will be used in populating the SMBIOS tables. Signed-off-by: Prabin CA --- Platform/ARM/SgiPkg/Include/SgiPlatform.h | 7 ++-

[edk2-devel] [edk2-platforms][PATCH v4 4/6] Platform/Sgi: Add support for RD-N2-Cfg3 platform

2024-01-25 Thread Prabin CA
The Neoverse RD-N2-Cfg3 platform is a variant of RD-N2 platform with a different mesh size and GIC ITS count. As part of the initial platform support, add the corresponding platform and flash description files. Use PcdPlatformVariant for the RD-N2-Cfg3 platform to specify the platform variant.

[edk2-devel] [edk2-platforms][PATCH v4 3/6] Platform/Sgi: Add a PCD to specify platform variant

2024-01-25 Thread Prabin CA
A new PCD named PcdPlatformVariant is introduced to specify the variant number of a platform. This PCD can be used to select platform variant specific configurations. The default value of this PCD is 0 which selects the base variant. Signed-off-by: Prabin CA ---

[edk2-devel] [edk2-platforms][PATCH v4 2/6] Platform/Sgi: Add VariableFlashInfoLib to fix missing dependency

2024-01-25 Thread Prabin CA
From: Vijayenthiran Subramaniam REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3479 A recent change in MdeModulePkg [1] introduced VariableFlashInfoLib as a dependency to support dynamic variable flash information. Add an instance for the library class VariableFlashInfoLib in

[edk2-devel] [edk2-platforms][PATCH v4 1/6] Platform/Sgi: remove +nofp gcc option flag

2024-01-25 Thread Prabin CA
From: Omkar Anand Kulkarni The software executing at a higher privileged level on the reference design platforms have been updated to allow software executing at EL1 and EL0 to access the Advanced SIMD and floating-point registers (FPEN field of CPACR_EL1 system register is programmed to allow

[edk2-devel] [edk2-platforms][PATCH v4 0/6] Platform/Sgi: Add support for RD-N2-Cfg3 and RD-V2 platform

2024-01-25 Thread Prabin CA
Changes since V3: - Removed author's signed-off on the patches, which is owned by another author. Changes since V2: - Removed the patch which introduce fno-stack-protector in the build flag. Changes since V1: - Addressed comments from Sami This patch series introduces support for two reference

[edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg/FeatureDriver: ComputerSystem_1_13_0 driver

2024-01-25 Thread Chang, Abner via groups.io
From: Abner Chang Initial version of edk2 Redfish feature of Redfish schema ComputerSystem_1_13_0. This driver handles ComputerSystem Boot properties but not all. Signed-off-by: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy --- .../v1_13_0/Dxe/ComputerSystemDxe.inf | 53 ++

Re: [edk2-devel] [edk2-discuss] Multi-ISA Driver Compatibility Survey

2024-01-23 Thread Laszlo Ersek
On 1/22/24 20:04, Rebecca Cran wrote: > Originally posted at > https://twitter.com/UEFIForum/status/1745518769232077208 > > The Multi-ISA Driver Compatibility Survey is at > https://docs.google.com/forms/d/e/1FAIpQLScXjwaSBgLeqB1coEDxCPxho5JWF3AMqshOTJ2wd6Tf0He4LA/viewform > > From that page: >

Re: [edk2-devel] [edk2-platforms][PATCH V4 4/4] Silicon/ARM/NeoverseN1Soc: Consume N1SdpNtFwConfigPei supplied data

2024-01-23 Thread sahil
Hi All, Please find the links to previous discussions below : V1 - https://edk2.groups.io/g/devel/topic/96088980#100022 V2 - https://edk2.groups.io/g/devel/topic/96671861#103652 V3 - https://edk2.groups.io/g/devel/topic/100912169#112452 Thanks, Sahil On Thu, 4 Jan 2024 at 18:46, sahil wrote:

Re: [edk2-devel] [edk2-platforms][PATCH V4 3/4] Platform/ARM/N1Sdp: Enable N1SdpNtFwConfigPei PEI module for N1Sdp

2024-01-23 Thread sahil
Hi All, Please find the links to previous discussions below : V1 - https://edk2.groups.io/g/devel/topic/96088980#100022 V2 - https://edk2.groups.io/g/devel/topic/96671861#103652 V3 - https://edk2.groups.io/g/devel/topic/100912169#112452 Thanks, Sahil On Thu, 4 Jan 2024 at 18:46, sahil wrote:

Re: [edk2-devel] [edk2-platforms][PATCH V4 2/4] Platform/ARM/N1Sdp: Add N1SdpNtFwConfigPei PEI module

2024-01-23 Thread sahil
Hi All, Please find the links to previous discussions below : V1 - https://edk2.groups.io/g/devel/topic/96088980#100022 V2 - https://edk2.groups.io/g/devel/topic/96671861#103652 V3 - https://edk2.groups.io/g/devel/topic/100912169#112452 Thanks, Sahil On Thu, 4 Jan 2024 at 18:46, sahil wrote:

Re: [edk2-devel] [edk2-platforms][PATCH V4 1/4] Silicon/ARM/NeoverseN1Soc: Extract NT_FW_CONFIG address passed by TF-A

2024-01-23 Thread sahil
Hi All, Please find the links to previous discussions below : V1 - https://edk2.groups.io/g/devel/topic/96088980#100022 V2 - https://edk2.groups.io/g/devel/topic/96671861#103652 V3 - https://edk2.groups.io/g/devel/topic/100912169#112452 Thanks, Sahil On Thu, 4 Jan 2024 at 18:46, sahil wrote:

Re: [edk2-devel] [edk2-platforms][PATCH V2 1/1] Platform/ARM/N1Sdp: Route the Debug Serial Port to IOFPGA UART1

2024-01-19 Thread Himanshu Sharma
Link to V1: [edk2-platforms][PATCH V1 1/1] Platform/ARM/N1Sdp: Modify IRQ ID of Debug UART and routing to IOFPGA UART1 (groups.io) ( https://edk2.groups.io/g/devel/message/98064?p=%2C%2C%2C20%2C0%2C0%2C0%3A%3Arecentpostdate%2Fsticky%2C%2Chimanshu%2C20%2C2%2C0%2C96088965 )

Re: [edk2-devel] [edk2-platforms][PATCH V4 0/4] Add support to parse NT_FW_CONFIG

2024-01-19 Thread Sami Mujawar
Hi Sahil, On Thu, Jan 4, 2024 at 05:16 AM, sahil wrote: > > v4: > - Fixed code review comments > - Split the patch into four patches Can you add git notes for the patches in the future, please? See

<    1   2   3   4   5   6   7   8   9   10   >