[edk2-devel] [edk2-platforms][PATCH v1] PurleyOpenBoardPkg: Replace Python Interpreter Name

2023-11-17 Thread Nate DeSimone
Removes the assumption that the python interpreter will have the name python. Cc: Chasel Chiu Signed-off-by: Nate DeSimone --- .../PurleyOpenBoardPkg/BoardMtOlympus/build_board.py | 8 .../PurleyOpenBoardPkg/BoardTiogaPass/build_board.py | 10 +- 2 files changed, 9

[edk2-devel] [edk2-platforms][PATCH v1] WhitleyOpenBoardPkg: Replace Python Interpreter Name

2023-11-17 Thread Nate DeSimone
Removes the assumption that the python interpreter will have the name python. Cc: Chasel Chiu Signed-off-by: Nate DeSimone +# Copyright (c) 2021 - 2023, Intel Corporation. All rights reserved. # Copyright (c) 2022, American Megatrends International LLC. # SPDX-License-Identifier:

[edk2-devel] [edk2-platforms][PATCH v1] MinPlatformPkg: Remove usage of PYTHON_HOME

2023-11-17 Thread Nate DeSimone
Removes usage PYTHON_HOME from RebaseFspBinBaseAddress.py Cc: Chasel Chiu Cc: Liming Gao Cc: Eric Dong Signed-off-by: Nate DeSimone --- .../MinPlatformPkg/Tools/Fsp/RebaseFspBinBaseAddress.py | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git

Re: [edk2-devel] edk2 uncrustify update (73.0.8)?

2023-11-17 Thread Laszlo Ersek
On 11/16/23 09:29, Pedro Falcato wrote: > On Tue, Nov 14, 2023 at 3:01 PM Laszlo Ersek wrote: >> >> On 11/13/23 22:33, Pedro Falcato wrote: >>> On Mon, Nov 13, 2023 at 8:37 PM Rebecca Cran wrote: On 11/13/2023 1:08 PM, Michael Kubacki wrote: > Yes. I just did it. It is relatively

Re: [edk2-devel] edk2 uncrustify update (73.0.8)?

2023-11-16 Thread Michael Kubacki
On 11/16/2023 3:29 AM, Pedro Falcato wrote: On Tue, Nov 14, 2023 at 3:01 PM Laszlo Ersek wrote: On 11/13/23 22:33, Pedro Falcato wrote: On Mon, Nov 13, 2023 at 8:37 PM Rebecca Cran wrote: On 11/13/2023 1:08 PM, Michael Kubacki wrote: Yes. I just did it. It is relatively minor and impacts

Re: [edk2-devel] [edk2-platforms PATCH v2 0/1] Marvell package restructure

2023-11-16 Thread Leif Lindholm
Apologies, I managed to misfile this. Reviewed-by: Leif Lindholm Typo in subject line fixed, pushed as ec5de71d83f3. Thanks! / Leif On Thu, Nov 02, 2023 at 09:15:51 +0530, ndhil...@marvell.com wrote: > From: Narinder Dhillon > > Current Silicon/Marvell package structure does not allow

[edk2-devel] [edk2-platforms][PATCH V1 5/5] Platform/ARM/N1Sdp: Enable FaultTolerantWrite Dxe driver for N1Sdp

2023-11-16 Thread sahil
Signed-off-by: sahil --- Platform/ARM/N1Sdp/N1SdpPlatform.dsc | 5 + Platform/ARM/N1Sdp/N1SdpPlatform.fdf | 1 + 2 files changed, 6 insertions(+) diff --git a/Platform/ARM/N1Sdp/N1SdpPlatform.dsc b/Platform/ARM/N1Sdp/N1SdpPlatform.dsc index 10fe2db9e1b1..703829bbac99 100644 ---

[edk2-devel] [edk2-platforms][PATCH V1 4/5] Platform/ARM/N1Sdp: Persistent storage for N1Sdp

2023-11-16 Thread sahil
Enable persistent storage on QSPI flash device. Signed-off-by: sahil --- Platform/ARM/N1Sdp/N1SdpPlatform.dsc | 20 ++-- Platform/ARM/N1Sdp/N1SdpPlatform.fdf | 4 +++- 2 files changed, 17 insertions(+), 7 deletions(-) diff --git a/Platform/ARM/N1Sdp/N1SdpPlatform.dsc

[edk2-devel] [edk2-platforms][PATCH V1 3/5] Platform/ARM/N1Sdp: NOR flash Dxe Driver for N1Sdp

2023-11-16 Thread sahil
Add NOR flash DXE driver, this brings up NV storage on QSPI's flash device using FVB protocol. Signed-off-by: sahil --- Platform/ARM/N1Sdp/N1SdpPlatform.dec |5 +- Platform/ARM/N1Sdp/Drivers/CadenceQspiDxe/CadenceQspiDxe.inf | 72 ++

[edk2-devel] [edk2-platforms][PATCH V1 2/5] Silicon/ARM/NeoverseN1Soc: NOR flash library for N1Sdp

2023-11-16 Thread sahil
Add NOR flash library, this library provides APIs for getting the list of NOR flash devices on the platform. Signed-off-by: sahil --- Silicon/ARM/NeoverseN1Soc/Library/NorFlashLib/NorFlashLib.inf | 36 ++ Silicon/ARM/NeoverseN1Soc/Library/NorFlashLib/NorFlashLib.c | 52

[edk2-devel] [edk2-platforms][PATCH V1 0/5] Enable non volatile storage on N1SDP

2023-11-16 Thread sahil
N1SDP uses an emulated variable storage on DDR memory for the variable storage. But this emulated variable storage is a volatile memory and so the values of variable cant persist on next reboot or in power cycle. In N1SDP platform, the SoC is connected to IOFPGA which has a Cadence Quad SPI (QSPI)

[edk2-devel] [edk2-platforms][PATCH V1 1/5] Silicon/ARM/NeoverseN1Soc: Enable SCP QSPI flash region

2023-11-16 Thread sahil
Enable SCP QSPI flash region access by adding it in the PlatformLibMem Signed-off-by: sahil --- Silicon/ARM/NeoverseN1Soc/Include/NeoverseN1Soc.h | 6 +- Silicon/ARM/NeoverseN1Soc/Library/PlatformLib/PlatformLibMem.c | 10 -- 2 files changed, 13 insertions(+), 3

Re: [edk2-devel] edk2 uncrustify update (73.0.8)?

2023-11-16 Thread Pedro Falcato
On Tue, Nov 14, 2023 at 3:01 PM Laszlo Ersek wrote: > > On 11/13/23 22:33, Pedro Falcato wrote: > > On Mon, Nov 13, 2023 at 8:37 PM Rebecca Cran wrote: > >> > >> On 11/13/2023 1:08 PM, Michael Kubacki wrote: > >>> Yes. I just did it. It is relatively minor and impacts expected code > >>> areas.

Re: [edk2-devel] [edk2-platforms PATCH 1/2] WhitleyOpenBoardPkg: remove references

2023-11-15 Thread Laszlo Ersek
Hi Chasel, On 11/10/23 02:13, Chiu, Chasel wrote: > > Hi Laszlo, > > I verified and encountered build failure as some files still consuming > definitions from LegacyBiosMpTable.h, for example: >

Re: [edk2-devel] edk2 uncrustify update (73.0.8)?

2023-11-15 Thread Laszlo Ersek
On 11/14/23 16:12, Rebecca Cran wrote: > On 11/14/2023 7:51 AM, Laszlo Ersek via groups.io wrote: > >> Funnily enough, my stance is quite the opposite. I happen to disagree >> with some patterns that uncrustify enforces, but I'm thankful that at >> any given state of CI (= using any given version

Re: [edk2-devel] [edk2-platforms PATCH v2 1/1] Silicon/Marvell: Retructure package

2023-11-14 Thread Marcin Wojtas via groups.io
Hi Narinder, Thanks for the patch. 2 comments: s/Retructure/Restructure/ from the commit title. czw., 2 lis 2023 o 04:47 Narinder Dhillon napisał(a): > > From: Narinder Dhillon > > Current Marvell package structure makes it difficult to add new silicon > packages that reuse common elements

Re: [edk2-devel] edk2 uncrustify update (73.0.8)?

2023-11-14 Thread Rebecca Cran via groups.io
On 11/14/2023 7:51 AM, Laszlo Ersek via groups.io wrote: Funnily enough, my stance is quite the opposite. I happen to disagree with some patterns that uncrustify enforces, but I'm thankful that at any given state of CI (= using any given version of uncrustify), we can't have any more debates

Re: [edk2-devel] edk2 uncrustify update (73.0.8)?

2023-11-14 Thread Laszlo Ersek
On 11/13/23 22:33, Pedro Falcato wrote: > On Mon, Nov 13, 2023 at 8:37 PM Rebecca Cran wrote: >> >> On 11/13/2023 1:08 PM, Michael Kubacki wrote: >>> Yes. I just did it. It is relatively minor and impacts expected code >>> areas. >>> >>> https://github.com/tianocore/edk2/pull/5043/files >> >> >>

Re: [edk2-devel] edk2 uncrustify update (73.0.8)?

2023-11-14 Thread Laszlo Ersek
On 11/13/23 20:07, Pedro Falcato wrote: > On Mon, Nov 13, 2023 at 11:58 AM Laszlo Ersek wrote: >> >> Hi Michael, >> >> recently I encountered an uncrustify failure on github. >> >> The reason was that my local uncrustify was *more recent* (73.0.8) than >> the one we use in edk2 CI (which is

Re: [edk2-devel] edk2 uncrustify update (73.0.8)?

2023-11-13 Thread Michael Kubacki
On 11/13/2023 3:37 PM, Rebecca Cran wrote: On 11/13/2023 1:08 PM, Michael Kubacki wrote: Yes. I just did it. It is relatively minor and impacts expected code areas. https://github.com/tianocore/edk2/pull/5043/files Could you update .git-blame-ignore-revs please?

Re: [edk2-devel] edk2 uncrustify update (73.0.8)?

2023-11-13 Thread Pedro Falcato
On Mon, Nov 13, 2023 at 8:37 PM Rebecca Cran wrote: > > On 11/13/2023 1:08 PM, Michael Kubacki wrote: > > Yes. I just did it. It is relatively minor and impacts expected code > > areas. > > > > https://github.com/tianocore/edk2/pull/5043/files > > > Could you update .git-blame-ignore-revs please?

Re: [edk2-devel] edk2 uncrustify update (73.0.8)?

2023-11-13 Thread Michael D Kinney
t; To: Pedro Falcato ; devel@edk2.groups.io; > ler...@redhat.com > Cc: Kinney, Michael D ; Andrew Fish > ; Marcin Juszkiewicz ; > Leif Lindholm (Quic) > Subject: Re: [edk2-devel] edk2 uncrustify update (73.0.8)? > > On 11/13/2023 2:07 PM, Pedro Falcato wrote: > > On Mon

Re: [edk2-devel] edk2 uncrustify update (73.0.8)?

2023-11-13 Thread Michael Kubacki
On 11/13/2023 2:14 PM, Rebecca Cran via groups.io wrote: On 11/13/2023 5:29 AM, Marcin Juszkiewicz via groups.io wrote: Still a fan of adding edk2-uncrustify to BaseTools. If we are expected to use it then let it get installed at same moment as "build" command is. The issue with doing this

Re: [edk2-devel] edk2 uncrustify update (73.0.8)?

2023-11-13 Thread Rebecca Cran
On 11/13/2023 1:08 PM, Michael Kubacki wrote: Yes. I just did it. It is relatively minor and impacts expected code areas. https://github.com/tianocore/edk2/pull/5043/files Could you update .git-blame-ignore-revs please?

Re: [edk2-devel] edk2 uncrustify update (73.0.8)?

2023-11-13 Thread Michael Kubacki
On 11/13/2023 2:07 PM, Pedro Falcato wrote: On Mon, Nov 13, 2023 at 11:58 AM Laszlo Ersek wrote: Hi Michael, recently I encountered an uncrustify failure on github. The reason was that my local uncrustify was *more recent* (73.0.8) than the one we use in edk2 CI (which is 73.0.3, per the

Re: [edk2-devel] edk2 uncrustify update (73.0.8)?

2023-11-13 Thread Michael Kubacki
On 11/13/2023 6:58 AM, Laszlo Ersek wrote: Hi Michael, recently I encountered an uncrustify failure on github. The reason was that my local uncrustify was *more recent* (73.0.8) than the one we use in edk2 CI (which is 73.0.3, per the edk2 file

Re: [edk2-devel] edk2 uncrustify update (73.0.8)?

2023-11-13 Thread Rebecca Cran via groups.io
On 11/13/2023 5:29 AM, Marcin Juszkiewicz via groups.io wrote: Still a fan of adding edk2-uncrustify to BaseTools. If we are expected to use it then let it get installed at same moment as "build" command is. The issue with doing this is there's a push to remove all C/C++ code from BaseTools

Re: [edk2-devel] edk2 uncrustify update (73.0.8)?

2023-11-13 Thread Pedro Falcato
On Mon, Nov 13, 2023 at 7:07 PM Pedro Falcato via groups.io wrote: > > On Mon, Nov 13, 2023 at 11:58 AM Laszlo Ersek wrote: > > > > Hi Michael, > > > > recently I encountered an uncrustify failure on github. > > > > The reason was that my local uncrustify was *more recent* (73.0.8) than > > the

Re: [edk2-devel] edk2 uncrustify update (73.0.8)?

2023-11-13 Thread Pedro Falcato
On Mon, Nov 13, 2023 at 11:58 AM Laszlo Ersek wrote: > > Hi Michael, > > recently I encountered an uncrustify failure on github. > > The reason was that my local uncrustify was *more recent* (73.0.8) than > the one we use in edk2 CI (which is 73.0.3, per the edk2 file >

[edk2-devel][edk2-staging] DeviceSimPkg branch creation

2023-11-13 Thread Maciej Czajkowski
Hello, I would like to announce DeviceSimPkg branch creation in edk2-staging repository. Branch will be used to develop DeviceSimPkg, a package for developing OS executable tests for device focused code. Branch owner: Maciej Czajkowski , GitHub ID: 81293748 (https://github.com/mczaj)

Re: [edk2-devel] edk2 uncrustify update (73.0.8)?

2023-11-13 Thread Marcin Juszkiewicz
W dniu 13.11.2023 o 12:58, Laszlo Ersek pisze: Note that 73.0.3 indents the subexpression to the "//" comment on the previous line, while 73.0.8 ignores the comment -- which I think is justified here. I believe this improvement may come from uncrustify commit 239c4fad745b ("Prevent endless

[edk2-devel] edk2 uncrustify update (73.0.8)?

2023-11-13 Thread Laszlo Ersek
Hi Michael, recently I encountered an uncrustify failure on github. The reason was that my local uncrustify was *more recent* (73.0.8) than the one we use in edk2 CI (which is 73.0.3, per the edk2 file ".pytool/Plugin/UncrustifyCheck/uncrustify_ext_dep.yaml"). Updating the version number in the

Re: [edk2-devel] [edk2-platforms PATCH 1/2] WhitleyOpenBoardPkg: remove references

2023-11-13 Thread Laszlo Ersek
07-14). The commit message is similarly empty. Laszlo > > Thanks, > Chasel > > > >> -Original Message- >> From: devel@edk2.groups.io On Behalf Of Laszlo Ersek >> Sent: Thursday, November 9, 2023 4:06 AM >> To: devel@edk2.groups.io >> Cc: Chaganty,

Re: [edk2-devel] [edk2-stable202311][PATCH] BaseTools: Python VfrCompiler implementation

2023-11-12 Thread Yuwei Chen
Hi Liming, I know your point. Would you like to start reviewing it and give us more feedbacks? We really hope it can be merged as soon as possible. We can do the merging after the stable tag, but just like you said, maybe we need to review it firstly. Looking forward to your feedbacks, and I

Re: [edk2-devel] [edk2-platforms PATCH v1 1/4] Silicon/Marvell: Retructure package

2023-11-12 Thread Narinder Dhillon
..@semihalf.com > Subject: [EXT] Re: [edk2-devel] [edk2-platforms PATCH v1 1/4] Silicon/Marvell: > Retructure package > > External Email > > -- > On Thu, Oct 26, 2023 at 16:35:52 +0100, Leif Lindholm wrote: > &

[edk2-devel] [edk2-stable202311][Patch v2 2/4] BaseTools/Scripts/GetMaintainer: Handle reviewer only case

2023-11-10 Thread Michael D Kinney
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4593 If a package only has reviewers and no maintainers, then also return the maintainers. In order to detect this case, get_maintainers() is updated to return maintainers, reviews, and lists separately instead of a single merged list. This

[edk2-devel] [edk2-stable202311][Patch v2 1/4] BaseTools/Scripts/GetMaintainer: Fix logic bug collecting maintainers

2023-11-10 Thread Michael D Kinney
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4593 Fix logic bug where maintainers is incorrectly added to lists. Cc: Rebecca Cran Cc: Liming Gao Cc: Bob Feng Cc: Yuwei Chen Cc: Leif Lindholm Signed-off-by: Michael D Kinney --- BaseTools/Scripts/GetMaintainer.py | 2 +- 1 file

[edk2-devel] [edk2-stable202311][Patch v2 3/4] BaseTools/Scripts/GetMaintainer: Simplify logic

2023-11-10 Thread Michael D Kinney
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4593 get_section_maintainers() either returns a list with valid entries or an empty list. It never returns None. Simplify logic that accumulates maintainers, reviewers, and lists by unconditionally appending lists returned from

[edk2-devel] [edk2-stable202311][Patch v2 4/4] BaseTools/Scripts/GetMaintainer: Sort output addresses

2023-11-10 Thread Michael D Kinney
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4593 Sort the list of output addresses alphabetically so this script produces the same output even if the order of patches in a patch series is modified such that that order of files processed by this script changes. Use set() logic instead of

[edk2-devel] [edk2-stable202311][Patch v2 0/4] BaseTools/Scripts/GetMaintainer: Handle reviewer only case

2023-11-10 Thread Michael D Kinney
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4593 New in V2: Split into patch series Fix logic bug where maintainers was incorrectly added to lists. If a package only has reviewers and no maintainers, then also return the maintainers. In order to detect this case, get_maintainers() is

Re: [edk2-devel] [edk2-stable202311][Patch 1/1] BaseTools/Scripts: Handle reviewer only case in GetMaintainer.py

2023-11-10 Thread Leif Lindholm
-Original Message- From: devel@edk2.groups.io On Behalf Of Leif Lindholm Sent: Friday, November 10, 2023 4:44 AM To: Kinney, Michael D Cc: devel@edk2.groups.io; Rebecca Cran ; Gao, Liming ; Feng, Bob C ; Chen, Christine Subject: Re: [edk2-devel] [edk2-stable202311][Patch 1/1] BaseTools

Re: [edk2-devel] [edk2-stable202311][Patch 1/1] BaseTools/Scripts: Handle reviewer only case in GetMaintainer.py

2023-11-10 Thread Michael D Kinney
gt; Cc: devel@edk2.groups.io; Rebecca Cran ; Gao, > Liming ; Feng, Bob C ; > Chen, Christine > Subject: Re: [edk2-devel] [edk2-stable202311][Patch 1/1] > BaseTools/Scripts: Handle reviewer only case in GetMaintainer.py > > On Wed, Nov 08, 2023 at 12:43:23 -0800, Mi

Re: [edk2-devel] [edk2-libc Patch 1/1] ek2-libc: Sample python scripts for socket client capabilities on UEFI shell

2023-11-10 Thread Jayaprakash, N
: Jayaprakash, N ; Rebecca Cran ; Kinney, Michael D Subject: [edk2-devel] [edk2-libc Patch 1/1] ek2-libc: Sample python scripts for socket client capabilities on UEFI shell REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4580 This BZ has been created to provide the sample python scripts

Re: [edk2-devel] [edk2-stable202311][Patch 1/1] BaseTools/Scripts: Handle reviewer only case in GetMaintainer.py

2023-11-10 Thread Leif Lindholm
On Wed, Nov 08, 2023 at 12:43:23 -0800, Michael D Kinney wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4593 > > If a package only has reviewers and no maintainers, then also > return the maintainers. > > Update get_maintainers() to return maintainers, reviews, and > lists

Re: [edk2-devel] [edk2-platforms PATCH 1/2] WhitleyOpenBoardPkg: remove references

2023-11-09 Thread Chiu, Chasel
nty, Rangasai V ; Desimone, Nathaniel > L ; Chiu, Chasel > Subject: [edk2-devel] [edk2-platforms PATCH 1/2] WhitleyOpenBoardPkg: > remove references > > For removing "MdePkg/Include/IndustryStandard/LegacyBiosMpTable.h" from > edk2, first remove the edk2-platforms referen

Re: [edk2-devel] [edk2-stable202311] [PATCH V4 0/3] OvmfPkg: Update TdVmCall to handle the retry for MapGPA

2023-11-09 Thread Yao, Jiewen
Thank you. Merged. https://github.com/tianocore/edk2/pull/5026 > -Original Message- > From: gaoliming > Sent: Thursday, November 9, 2023 9:54 PM > To: devel@edk2.groups.io; Yao, Jiewen ; Sun, CepingX > ; Kinney, Michael D ; > 'Leif Lindholm' ; 'Andrew Fish' > Cc: Aktas, Erdem ; 'James

Re: [edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg/RedfishFeatureUtilityLib: validate string array

2023-11-09 Thread Igor Kulchytskyy via groups.io
Hi Nickle, I noticed one typo. See below the text. And I have a question regarding newly introduced ValidateRedfishStringArrayValues function. You use that function to check if value in Redfish string array can be found in HII configuration string array. And you still call

回复: [edk2-devel] [edk2-platforms][PATCH] Features/IpmiFeaturePkg: Remove IpmiCommandLib from IpmiFeaturePkg

2023-11-09 Thread gaoliming via groups.io
le Wang > 主题: RE: [edk2-devel] [edk2-platforms][PATCH] Features/IpmiFeaturePkg: > Remove IpmiCommandLib from IpmiFeaturePkg > > [AMD Official Use Only - General] > > Hi Nate and Liming, > Please check this patch. The one under IpmiFeaturePkg is an old one, we > should remove

Re: [edk2-devel] [edk2-stable202311][PATCH] BaseTools: Python VfrCompiler implementation

2023-11-09 Thread gaoliming via groups.io
Christine: I can't directly reply to the original mail because it is too large. This is a new feature to add python version VfrCompiler. I don't think we have enough time to review the design and implementation. Although it has no real impact, its code may have many change in future. So, I

[edk2-devel] [edk2-platforms PATCH 2/2] SimicsOpenBoardPkg: remove reference

2023-11-09 Thread Laszlo Ersek
For removing "MdePkg/Include/Guid/Mps.h" from edk2, first remove the edk2-platforms references to that header file. I can't build-test this change. As far as I can tell, building the BoardX58Ich10 platform with "build_bios.py" should build the change; however, that platform fails to build without

[edk2-devel] [edk2-platforms PATCH 1/2] WhitleyOpenBoardPkg: remove references

2023-11-09 Thread Laszlo Ersek
For removing "MdePkg/Include/IndustryStandard/LegacyBiosMpTable.h" from edk2, first remove the edk2-platforms references to that header file. I can't build-test this change. As far as I can tell, building the CooperCityRvp and WilsonCityRvp platforms with "build_bios.py" should build these

[edk2-devel] [edk2-platforms PATCH 0/2] remove and refs

2023-11-09 Thread Laszlo Ersek
Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=1754 Remove references to two old headers that play no role in modern UEFI. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Sai Chaganty Laszlo Ersek (2): WhitleyOpenBoardPkg: remove references SimicsOpenBoardPkg: remove reference

[edk2-devel] [edk2-stable202311][Patch 1/1] BaseTools/Scripts: Handle reviewer only case in GetMaintainer.py

2023-11-08 Thread Michael D Kinney
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4593 If a package only has reviewers and no maintainers, then also return the maintainers. Update get_maintainers() to return maintainers, reviews, and lists separately instead of a single merged list to allow this module to be used by other

[edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg/RedfishFeatureUtilityLib: validate string array

2023-11-07 Thread Nickle Wang via groups.io
- Add function to validate Redfish request for string array type. There is case that user request invalid string array and feature driver can not find corresponding HII option. - Fix typo. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez ---

Re: [edk2-devel] [edk2-platforms][PATCH] Features/IpmiFeaturePkg: Remove IpmiCommandLib from IpmiFeaturePkg

2023-11-07 Thread Chang, Abner via groups.io
io > Sent: Monday, October 30, 2023 2:59 PM > To: devel@edk2.groups.io > Cc: Nate DeSimone ; Liming Gao > ; Chasel Chiu ; Li-Xia > Huang ; Attar, AbdulLateef (Abdul Lateef) > ; Nickle Wang > Subject: [edk2-devel] [edk2-platforms][PATCH] Features/IpmiFeaturePkg: > Remove I

Re: [edk2-devel] [edk2-redfish-client][PATCH 2/2] RedfishClientPkg/RedfishFeatureCoreDxe: notify platform before reboot.

2023-11-05 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Looks good, you can move EDKII_REDFISH_OVERRIDE_PROTOCOL *RedfishOverride from local variable to global variable and locate this protocol only once if there are more than one use cases of Redfish override protocol in RedfishFeatureCore in the future.

Re: [edk2-devel] [edk2-redfish-client][PATCH 1/2] RedfishClientPkg: introduce Redfish override protocol

2023-11-05 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: Nickle Wang > Sent: Thursday, November 2, 2023 6:18 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > ; Nick Ramirez > Subject: [edk2-redfish-client][PATCH 1/2]

Re: [edk2-devel] edk2-platforms: developing Whitley Lake package

2023-11-04 Thread Nate DeSimone
.groups.io On Behalf Of Alireza Banejad Sent: Wednesday, November 1, 2023 12:21 AM To: devel@edk2.groups.io Subject: [edk2-devel] edk2-platforms: developing Whitley Lake package Hello everyone, I am trying to port edk2-platforms for an IceLake-SP board which uses a C621a chipset. digging

[edk2-devel] [edk2-redfish-client][PATCH 2/2] RedfishClientPkg/RedfishFeatureCoreDxe: notify platform before reboot.

2023-11-02 Thread Nickle Wang via groups.io
Call Redfish override protocol to notify platform that the Redfish changes system settings and about to perform system reboot. Platform firmware can do platform specific operation before system rebooted. To follow platform policy, platform can reject system reboot by returning error status and

[edk2-devel] [edk2-redfish-client][PATCH 0/2] introduce Redfish override protocol

2023-11-02 Thread Nickle Wang via groups.io
Introduce Redfish override protocol. If platform likes to do specific operation before system reboot, platform implement this protocol and Redfish feature core driver will call it to notify platform that system is going to reboot. Platform can reject system reboot by returning error status based

[edk2-devel] [edk2-redfish-client][PATCH 1/2] RedfishClientPkg: introduce Redfish override protocol

2023-11-02 Thread Nickle Wang via groups.io
Introduce Redfish override protocol to notify platform that the Redfish changes system settings and about to perform system reboot. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- RedfishClientPkg/RedfishClientPkg.dec | 2 +

[edk2-devel] [edk2-platforms PATCH v2 0/1] Marvell package restructure

2023-11-01 Thread Narinder Dhillon
From: Narinder Dhillon Current Silicon/Marvell package structure does not allow sharing of components that are common to different SoC's. This restructure will increase shared code and better seperation. Credit to Leif Lindholm for providing this new structure. v2: - Remove three lines for

Re: [edk2-devel] [edk2-redfish-client][PATCH 3/3] RedfishClientPkg/RedfishFeatureUtilityLib: fix issues and enhancement

2023-11-01 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: Nickle Wang > Sent: Tuesday, October 31, 2023 3:45 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > ; Nick Ramirez > Subject: [edk2-redfish-client][PATCH 3/3] >

Re: [edk2-devel] [edk2-redfish-client][PATCH 2/3] RedfishClientPkg/RedfishConfigLangMapDxe: uninitialized variable issue

2023-11-01 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: Nickle Wang > Sent: Tuesday, October 31, 2023 3:45 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > ; Nick Ramirez > Subject: [edk2-redfish-client][PATCH 2/3] >

Re: [edk2-devel] [edk2-redfish-client][PATCH 1/3] RedfishClientPkg/RedfishETagDxe: fix uninitialized variable issue

2023-11-01 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: Nickle Wang > Sent: Tuesday, October 31, 2023 3:45 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > ; Nick Ramirez > Subject: [edk2-redfish-client][PATCH 1/3]

[edk2-devel] edk2-platforms: developing Whitley Lake package

2023-11-01 Thread Alireza Banejad
Hello everyone, I am trying to port edk2-platforms for an IceLake-SP board which uses a C621a chipset. digging into the repo I found out that the most compatible board inside WhitelyLakePkg is the WilsonCityRvp (The ReadMe file inside Platform/Intel explicitly says it is IceLake-SP ). I built it

Re: [edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg/RedfishLib: align with edk2 RedfishLib

2023-10-31 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: Nickle Wang > Sent: Thursday, October 26, 2023 4:35 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > ; Nick Ramirez > Subject: [edk2-redfish-client][PATCH]

[edk2-devel] [edk2-redfish-client][PATCH 3/3] RedfishClientPkg/RedfishFeatureUtilityLib: fix issues and enhancement

2023-10-31 Thread Nickle Wang via groups.io
-Add RedfishDebugLib to print Redfish request and response details when PATCH and POST request return error. -Use "%a:" in debug print to align with the style in EDK2. -Enhance GetConfigureLang() to handle pending resource URI. Pending resource share ths same schema as its active resource. So we

[edk2-devel] [edk2-redfish-client][PATCH 2/3] RedfishClientPkg/RedfishConfigLangMapDxe: uninitialized variable issue

2023-10-31 Thread Nickle Wang via groups.io
-RedfishConfigLangMapDxe relies on variable arch protocol. -Status variable is not initialized. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- .../RedfishConfigLangMapDxe/RedfishConfigLangMapDxe.inf | 4 ++--

[edk2-devel] [edk2-redfish-client][PATCH 1/3] RedfishClientPkg/RedfishETagDxe: fix uninitialized variable issue

2023-10-31 Thread Nickle Wang via groups.io
Status variable is not initialized. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- RedfishClientPkg/RedfishETagDxe/RedfishETagDxe.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/RedfishClientPkg/RedfishETagDxe/RedfishETagDxe.c

[edk2-devel] [edk2-redfish-client][PATCH 0/3] Fix various issues and enhancement.

2023-10-31 Thread Nickle Wang via groups.io
Fix various issues and add enhancement to RedfishClientPkg. PR is opened here: https://github.com/tianocore/edk2-redfish-client/pull/55 Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez Nickle Wang (3): RedfishClientPkg/RedfishETagDxe: fix uninitialized

Re: [edk2-devel] [edk2-platforms][PATCH] ManageabilityPkg: Uncrustify on C source files

2023-10-30 Thread Nickle Wang via groups.io
Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: Laszlo Ersek > Sent: Thursday, October 26, 2023 5:50 PM > To: devel@edk2.groups.io; Chang, Abner > Cc: Attar, AbdulLateef (Abdul Lateef) ; Nickle > Wang ; Konstantin Aladyshev > Subject: R

Re: [edk2-devel] [edk2-redfish-client][PATCH v2 0/11] RedfishClientPkg: various minor fixes

2023-10-30 Thread Nickle Wang via groups.io
Reviewed this patch series. Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: Mike Maslenkin > Sent: Friday, October 27, 2023 7:54 AM > To: devel@edk2.groups.io > Cc: abner.ch...@amd.com; Nickle Wang ; > ig...@ami.com; Mike Maslenkin > Subject:

[edk2-devel] [edk2-platforms][PATCH] Features/IpmiFeaturePkg: Remove IpmiCommandLib from IpmiFeaturePkg

2023-10-30 Thread Chang, Abner via groups.io
From: Abner Chang Remove IpmiCommandLib from IpmiFeaturePkg as ManageabilityPkg already had one and is newer. Signed-off-by: Abner Chang Cc: Nate DeSimone Cc: Liming Gao Cc: Chasel Chiu Cc: Li-Xia Huang Cc: Abdul Lateef Attar Cc: Nickle Wang --- .../IpmiFeaturePkg/IpmiFeaturePkg.dec

Re: [edk2-devel] [edk2-platforms][PATCH 2/2] OutOfBandManagement/IpmiFeaturePKg: Remove IpmiCommandLib.h from IpmiFeaturePkg

2023-10-28 Thread Chang, Abner via groups.io
> Cc: Attar, AbdulLateef (Abdul Lateef) ; Isaac > Oram ; Nickle Wang ; Nate > DeSimone ; Liming Gao > > Subject: RE: [edk2-devel] [edk2-platforms][PATCH 2/2] > OutOfBandManagement/IpmiFeaturePKg: Remove IpmiCommandLib.h from > IpmiFeaturePkg > > [AMD Official Use Only - General

Re: [edk2-devel] [edk2-platforms PATCH] Maintainers.txt: remove Isaac Oram's email address

2023-10-28 Thread Laszlo Ersek
On 10/25/23 10:35, Laszlo Ersek wrote: > Email to Isaac's address bounces ("5.1.0 Address > rejected"); remove that address. > > Cc: Abdul Lateef Attar > Cc: Abner Chang > Cc: Ashraf Ali S > Cc: Chasel Chiu > Cc: Eric Dong > Cc: Liming Gao > Cc: Nate DeSimone > Cc: Nickle Wang > Cc:

Re: [edk2-devel] [edk2-libc Patch 1/1] ek2-libc: Sample python scripts for socket client capabilities on UEFI shell

2023-10-28 Thread Laszlo Ersek
On 10/27/23 18:27, Jayaprakash, N wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4580 > > This BZ has been created to provide the sample python scripts > to demonstrate the socket client capabilities using http library > on UEFI shell with the help of Python UEFI interpreter. > The

[edk2-devel] [edk2-libc Patch 1/1] ek2-libc: Sample python scripts for socket client capabilities on UEFI shell

2023-10-27 Thread Jayaprakash, N
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4580 This BZ has been created to provide the sample python scripts to demonstrate the socket client capabilities using http library on UEFI shell with the help of Python UEFI interpreter. The http_echo_client.py and http_echo_server.py scripts

[edk2-devel] [edk2-libc Patch 0/1] AppPkg/Python - Sample scripts to exercise socket functionality

2023-10-27 Thread Jayaprakash, N
This commit provides 2 sample scripts namely http_echo_client.py and http_echo_server.py to exercise the socket capabilities on UEFI shell using the http library from Python UEFI interpreter. Jayaprakash N (1): ek2-libc: Sample python scripts for socket client capabilities on UEFI shell

Re: [edk2-devel] [edk2-platforms][PATCH 1/2] ManageabilityPkg/Ipmi: Remove IpmiCommandLib.h from ManageabilityPkg

2023-10-27 Thread Nickle Wang via groups.io
ickle Wang > Subject: Re: [edk2-devel] [edk2-platforms][PATCH 1/2] ManageabilityPkg/Ipmi: > Remove IpmiCommandLib.h from ManageabilityPkg > > [AMD Official Use Only - General] > > Caution: This message originated from an External Source. Use proper caution > when opening

Re: [edk2-devel] [edk2-libc Patch 0/1] fix missing nanf definition in StdLib

2023-10-26 Thread Jayaprakash, N
Reviewed-by : Jayaprakash Nevara Regards, JP -Original Message- From: devel@edk2.groups.io On Behalf Of Jayaprakash, N Sent: Thursday, October 26, 2023 9:00 PM To: devel@edk2.groups.io Cc: Jayaprakash, N Subject: [edk2-devel] [edk2-libc Patch 0/1] fix missing nanf definition

Re: [edk2-devel] [edk2-redfish-client][PATCH v2 11/11] RedfishFeatureCoreDxe: add check for memory allocation failure

2023-10-26 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: Mike Maslenkin > Sent: Friday, October 27, 2023 7:54 AM > To: devel@edk2.groups.io > Cc: Chang, Abner ; nick...@nvidia.com; > ig...@ami.com; Mike Maslenkin > Subject: [edk2-redfish-client][PATCH v2

Re: [edk2-devel] [edk2-redfish-client][PATCH v2 09/11] RedfishClientPkg: fix StrnCpyS arguments

2023-10-26 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: Mike Maslenkin > Sent: Friday, October 27, 2023 7:54 AM > To: devel@edk2.groups.io > Cc: Chang, Abner ; nick...@nvidia.com; > ig...@ami.com; Mike Maslenkin > Subject: [edk2-redfish-client][PATCH v2

Re: [edk2-devel] [edk2-platforms][PATCH 2/2] OutOfBandManagement/IpmiFeaturePKg: Remove IpmiCommandLib.h from IpmiFeaturePkg

2023-10-26 Thread Chang, Abner via groups.io
l@edk2.groups.io On Behalf Of Chang, > Abner via groups.io > Sent: Wednesday, October 18, 2023 12:53 PM > To: devel@edk2.groups.io; Chang, Abner > Cc: Attar, AbdulLateef (Abdul Lateef) ; Isaac > Oram ; Nickle Wang ; Nate > DeSimone ; Liming Gao > > Subject: Re: [edk2-dev

[edk2-devel] [edk2-redfish-client][PATCH v2 10/11] RedfishFeatureCoreDxe: replace __FUNCTION__ with __func__

2023-10-26 Thread Mike Maslenkin
Signed-off-by: Mike Maslenkin --- .../RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c b/RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c

[edk2-devel] [edk2-redfish-client][PATCH v2 11/11] RedfishFeatureCoreDxe: add check for memory allocation failure

2023-10-26 Thread Mike Maslenkin
Signed-off-by: Mike Maslenkin --- .../RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c b/RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c index

[edk2-devel] [edk2-redfish-client][PATCH v2 08/11] RedfishClientPkg: fix pragma pack usage

2023-10-26 Thread Mike Maslenkin
Signed-off-by: Mike Maslenkin --- RedfishClientPkg/HiiToRedfishBiosDxe/HiiToRedfishBiosData.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/RedfishClientPkg/HiiToRedfishBiosDxe/HiiToRedfishBiosData.h b/RedfishClientPkg/HiiToRedfishBiosDxe/HiiToRedfishBiosData.h index

[edk2-devel] [edk2-redfish-client][PATCH v2 09/11] RedfishClientPkg: fix StrnCpyS arguments

2023-10-26 Thread Mike Maslenkin
StrnCpyS accepts string length in characters, not in bytes. Signed-off-by: Mike Maslenkin --- RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c

[edk2-devel] [edk2-redfish-client][PATCH v2 07/11] RedfishClientPkg: fix memory leak

2023-10-26 Thread Mike Maslenkin
This patch fixes leak in RedfishExternalResourceResourceFeatureCallback function. Signed-off-by: Mike Maslenkin --- RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c

[edk2-devel] [edk2-redfish-client][PATCH v2 05/11] RedfishClientPkg: reduce identation level by adding early return

2023-10-26 Thread Mike Maslenkin
This functions contain memory leaks. Less identation helps to solve this issues. Signed-off-by: Mike Maslenkin --- .../RedfishFeatureUtilityLib.c| 289 +- 1 file changed, 146 insertions(+), 143 deletions(-) diff --git

[edk2-devel] [edk2-redfish-client][PATCH v2 06/11] RedfishClientPkg: fix memory leaks while applying feature settings

2023-10-26 Thread Mike Maslenkin
Signed-off-by: Mike Maslenkin --- .../RedfishFeatureUtilityLib.c| 11 +++ 1 file changed, 11 insertions(+) diff --git a/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtilityLib.c

[edk2-devel] [edk2-redfish-client][PATCH v2 04/11] RedfishClientPkg: RedfishFeatureUtilityLib: fix memory leaks

2023-10-26 Thread Mike Maslenkin
Signed-off-by: Mike Maslenkin --- .../RedfishFeatureUtilityLib.c| 30 +++ 1 file changed, 30 insertions(+) diff --git a/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtilityLib.c

[edk2-devel] [edk2-redfish-client][PATCH v2 02/11] RedfishClientPkg: fix DEBUG macro arguments

2023-10-26 Thread Mike Maslenkin
Signed-off-by: Mike Maslenkin --- .../RedfishFeatureUtilityLib.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtilityLib.c

[edk2-devel] [edk2-redfish-client][PATCH v2 03/11] RedfishLib: remove redudant zeroing

2023-10-26 Thread Mike Maslenkin
Memory allocated by calloc() is filled with bytes of value zero. Signed-off-by: Mike Maslenkin --- .../PrivateLibrary/RedfishLib/edk2libredfish/src/service.c | 1 - 1 file changed, 1 deletion(-) diff --git a/RedfishClientPkg/PrivateLibrary/RedfishLib/edk2libredfish/src/service.c

[edk2-devel] [edk2-redfish-client][PATCH v2 0/11] RedfishClientPkg: various minor fixes

2023-10-26 Thread Mike Maslenkin
This patchset contains fixes of wrong format and number of arguments passed to DEBUG macro. Also a number of memory leaks were fixed. Here is a link to PR: https://github.com/tianocore/edk2-redfish-client/pull/52 Cc: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Signed-off-by: Mike

[edk2-devel] [edk2-redfish-client][PATCH v2 01/11] RedfishClientPkg: fix format used for output __func__

2023-10-26 Thread Mike Maslenkin
Signed-off-by: Mike Maslenkin --- RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c b/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c index

Re: [edk2-devel] [edk2-platforms PATCH v1 1/4] Silicon/Marvell: Retructure package

2023-10-26 Thread Leif Lindholm
On Thu, Oct 26, 2023 at 16:35:52 +0100, Leif Lindholm wrote: > On Wed, Oct 11, 2023 at 10:53:20 -0700, ndhil...@marvell.com wrote: > > From: Narinder Dhillon > > > > Current Marvell package structure makes it difficult to add new silicon > > packages that reuse common elements without creating

Re: [edk2-devel] [edk2-libc Patch 1/1] ek2-libc: realpath function signature doesn't match the standard

2023-10-26 Thread Laszlo Ersek
On 10/26/23 16:17, Jayaprakash, N wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4574 > > This commit is for processing the below PR on edk2-libc repo > https://github.com/tianocore/edk2-libc/pull/10 > The realpath function signature in stdlib of edk2-libc doesn't match > signature

Re: [edk2-devel] [edk2-platforms PATCH v1 1/4] Silicon/Marvell: Retructure package

2023-10-26 Thread Leif Lindholm
On Wed, Oct 11, 2023 at 10:53:20 -0700, ndhil...@marvell.com wrote: > From: Narinder Dhillon > > Current Marvell package structure makes it difficult to add new silicon > packages that reuse common elements without creating nested DEC files. > > This patch creates a new MarvellSiliconPkg folder

Re: [edk2-devel] [edk2-libc Patch 1/1] ek2-libc: realpath function signature doesn't match the standard

2023-10-26 Thread Jayaprakash, N
Reviewed-by: Jayaprakash Nevara It's simple fix to align the function signature as per the standards. Regards, JP -Original Message- From: Jayaprakash, N Sent: Thursday, October 26, 2023 7:47 PM To: devel@edk2.groups.io Cc: Jayaprakash, N ; Rebecca Cran ; Kinney, Michael D ; Kloper,

<    4   5   6   7   8   9   10   11   12   13   >