Thanks for your update. Reviewed-by: Liming Gao <gaolim...@byosoft.com.cn>
> -----邮件原件----- > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Taylor Beebe > 发送时间: 2024年4月10日 3:43 > 收件人: devel@edk2.groups.io; gaolim...@byosoft.com.cn > 抄送: 'Rebecca Cran' <rebe...@bsdio.com>; 'Bob Feng' > <bob.c.f...@intel.com>; 'Yuwei Chen' <yuwei.c...@intel.com> > 主题: Re: 回复: 回复: [edk2-devel] [PATCH v2 0/2] Update BaseTools NULL > Include and Library Matching > > Hi Liming, > > I made a mistake in patch 2 of the v2 series. In v3, lines 126 and 144 > of WorkspaceCommon.py update the check to: > > `LibraryClassName[4:].isdigit()` > > instead of > > `LibraryClass[4:].isdigit()` > > Can you re-review with this change? > > -Taylor > > On 4/1/2024 6:37 PM, gaoliming via groups.io wrote: > > Taylor: > > Thanks for you detail information. I understand this problem. I agree > your fix. Reviewed-by: Liming Gao <gaolim...@byosoft.com.cn> > > > > Thanks > > Liming > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117747): https://edk2.groups.io/g/devel/message/117747 Mute This Topic: https://groups.io/mt/105529073/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
