Re: [edk2-devel] [PATCH] UefiPayloadPkg: Add RNG support

2021-01-21 Thread Yao, Jiewen
gt; ; patrick.rudo...@9elements.com > Cc: Dong, Guo ; You, Benjamin > ; devel@edk2.groups.io; Liu, Zhiguang > > Subject: Re: [edk2-devel] [PATCH] UefiPayloadPkg: Add RNG support > > Hi, Patrick > Let us add MdePkg maintainers into the discussion to see what could be the > b

Re: [edk2-devel] [PATCH] UefiPayloadPkg: Add RNG support

2021-01-21 Thread Ma, Maurice
nt: Thursday, January 21, 2021 1:05 > To: Ma, Maurice > Cc: devel@edk2.groups.io; Dong, Guo ; You, Benjamin > > Subject: Re: [edk2-devel] [PATCH] UefiPayloadPkg: Add RNG support > > Hi Maurice, > it's a copy of the MdeModulePkg's BaseRngLib with runtime detection suppor

Re: [edk2-devel] [PATCH] UefiPayloadPkg: Add RNG support

2021-01-21 Thread Patrick Rudolph
Hi Maurice, it's a copy of the MdeModulePkg's BaseRngLib with runtime detection support. Are the MdeModulePkg maintainers OK with adding runtime detection support? I had the impression that it should only be used on platforms supporting rdrand for sure, and therefore must not be used on platforms

Re: [edk2-devel] [PATCH] UefiPayloadPkg: Add RNG support

2021-01-20 Thread Ma, Maurice
Hi, Patrick There is a BaseRngLib in MdePkg package already. I am wondering why a new instance was created under UefiPayloadPkg in the patch. Could we just reuse the same library in MdePkg? If not, what is the reason? Can we try to enhance the library in MdePkg to address it if required?