Re: [edk2-devel] [PATCH 2/4] RedfishClientPkg: refine RedfishExternalResourceResourceFeatureCallback

2024-02-21 Thread Mike Maslenkin
On Wed, Feb 21, 2024 at 5:34 AM Chang, Abner wrote: > > [AMD Official Use Only - General] > > > -Original Message- > > From: Mike Maslenkin > > Sent: Wednesday, February 21, 2024 8:13 AM > > To: devel@edk2.groups.io > > Cc: Mike Maslenkin ; Nickle Wang > > ; Chang, Abner ; Igor > >

Re: [edk2-devel] [PATCH 2/4] RedfishClientPkg: refine RedfishExternalResourceResourceFeatureCallback

2024-02-21 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Hi Nickle, I have no problem with either one, maybe BiosUri is a better choice. Thanks Abner From: Nickle Wang Sent: Wednesday, February 21, 2024 3:30 PM To: Mike Maslenkin ; devel@edk2.groups.io; Chang, Abner Cc: Igor Kulchytskyy Subject: RE: [PATCH 2/4]

Re: [edk2-devel] [PATCH 2/4] RedfishClientPkg: refine RedfishExternalResourceResourceFeatureCallback

2024-02-20 Thread Nickle Wang via groups.io
Hi Mike, Thanks for incorporating my suggestion to address memory issue. For the name "CollectionUri", I know this is from my suggestion, but I think Abner is right. Could you please change it to "BiosUri" or "ResourceUri" since BIOS resource is not a Redfish collection? @Abner

Re: [edk2-devel] [PATCH 2/4] RedfishClientPkg: refine RedfishExternalResourceResourceFeatureCallback

2024-02-20 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] > -Original Message- > From: Mike Maslenkin > Sent: Wednesday, February 21, 2024 8:13 AM > To: devel@edk2.groups.io > Cc: Mike Maslenkin ; Nickle Wang > ; Chang, Abner ; Igor > Kulchytskyy > Subject: [PATCH 2/4] RedfishClientPkg: refine >