Re: [edk2-devel] [PATCH 31/35] ShellPkg/UefiShellDebug1CommandsLib: fix ShellCloseFile() call

2019-09-23 Thread Gao, Zhichao
devel@edk2.groups.io; ler...@redhat.com > > Cc: Carsey, Jaben ; Ni, Ray > > ; Gao, Zhichao > > Subject: Re: [edk2-devel] [PATCH 31/35] > > ShellPkg/UefiShellDebug1CommandsLib: fix ShellCloseFile() call > > > > On 9/17/19 9:49 PM, Laszlo Ersek wrote: &

Re: [edk2-devel] [PATCH 31/35] ShellPkg/UefiShellDebug1CommandsLib: fix ShellCloseFile() call

2019-09-23 Thread Carsey, Jaben
ject: Re: [edk2-devel] [PATCH 31/35] > ShellPkg/UefiShellDebug1CommandsLib: fix ShellCloseFile() call > > On 9/17/19 9:49 PM, Laszlo Ersek wrote: > > In the FileBufferSave() function, we invoke ShellCloseFile() if "Directory > > Can Not Be Saved". > > > > The

Re: [edk2-devel] [PATCH 31/35] ShellPkg/UefiShellDebug1CommandsLib: fix ShellCloseFile() call

2019-09-23 Thread Philippe Mathieu-Daudé
On 9/17/19 9:49 PM, Laszlo Ersek wrote: > In the FileBufferSave() function, we invoke ShellCloseFile() if "Directory > Can Not Be Saved". > > The ShellCloseFile() function takes a (SHELL_FILE_HANDLE*) parameter > called "FileHandle", and correctly passes the de-referenced (*FileHandle) > to