Re: [edk2-devel] [PATCH V2 2/2] NetworkPkg: Add WiFi profile sync protocol support

2022-09-28 Thread Clark-williams, Zachary
.groups.io; Clark-williams, Zachary Cc: Zachary Clark-Williams Subject: RE: [edk2-devel] [PATCH V2 2/2] NetworkPkg: Add WiFi profile sync protocol support Hi Zack, 1. > + Status = UnicodeStrToAsciiStrS (Profile->Password, (CHAR8 > + *)AsciiPassword, ((StrLen (Profile->Password) +

Re: [edk2-devel] [PATCH V2 2/2] NetworkPkg: Add WiFi profile sync protocol support

2022-09-27 Thread Heng Luo
Hi Zack, 1. > + Status = UnicodeStrToAsciiStrS (Profile->Password, (CHAR8 > + *)AsciiPassword, ((StrLen (Profile->Password) + 1) * sizeof (CHAR8))); I think we should remove '* sizeof (CHAR8)' because the third parameter is the length of string but not size of the memory: Status =