On 2019-08-16 18:09, rebe...@bsdio.com wrote:
> Yes, that's going to be important. Given
> https://docs.microsoft.com/en-us/cpp/porting/visual-cpp-change-history-2003-2015?view=vs-2019,
> I suspect support for VS2008 might already have been broken, since it
> reports that "static_assert" was
On 2019-08-16 18:03, Andrew Fish wrote:
> It is also interesting in the context of our CI as we could pick oldest and
> newest version from every compiler family for the CI build test.
Yes, that's going to be important. Given
> On Aug 16, 2019, at 5:01 PM, Rebecca Cran wrote:
>
> On 2019-08-16 16:58, Andrew Fish via Groups.Io wrote:
>>
>> I'm all for modernization of the C code as long we are thoughtful
>> about compatibility. For example I still see that VS2008 is a
>> supported
On 2019-08-16 16:58, Andrew Fish via Groups.Io wrote:
>
> I'm all for modernization of the C code as long we are thoughtful
> about compatibility. For example I still see that VS2008 is a
> supported BaseTools/Conf/tools_def.template.
It would be interesting to see who's using the older
rd option is for community members to
>>> provide Tested-by responses to the feature along with
>>> statements in the Bugzilla that clearly documents how the
>>> the feature was tested.
>>>
>>> Best regards,
>>>
>>> Mike
that clearly documents how the
>> the feature was tested.
>>
>> Best regards,
>>
>> Mike
>>
>> > -Original Message-
>> > From: devel@edk2.groups.io
>> > [mailto:devel@edk2.groups.io] On Behalf Of Laszlo Ersek
>> > Se
On 2019-08-16 15:40, Vitaly Cheptsov via Groups.Io wrote:
> I missed your message while writing mine, but I am afraid I disagree
> with the functional macro usage for this feature.
>
> I explicitly quoted C standard static_assert definition in one of my
> previous messages, and I want EDK II to be
ted.
>
> Best regards,
>
> Mike
>
>> -Original Message-
>> From: devel@edk2.groups.io
>> [mailto:devel@edk2.groups.io] On Behalf Of Laszlo Ersek
>> Sent: Friday, August 16, 2019 12:39 PM
>> To: vit9...@protonmail.com
>> Cc: devel@edk2.
Laszlo,
I am very glad to you for expressing a different opinion as this lets me view
the situation from different angles.
I understand your concerns, and believe that most of them should actually be
addressed in a way you explain. In fact, I plan to submit more patches myself
for everyone's
Sent: Friday, August 16, 2019 12:39 PM
> To: vit9...@protonmail.com
> Cc: devel@edk2.groups.io; leif.lindh...@linaro.org;
> af...@apple.com
> Subject: Re: [edk2-devel] [PATCH v2 1/1] MdePkg: Add
> STATIC_ASSERT macro
>
> On 08/16/19 19:23, vit9...@protonmail.com wrote:
> > L
On 08/16/19 21:38, Laszlo Ersek wrote:
> I understand that edk2 is a "kit", and quite explicitly caters to
> out-of-tree platforms. That's not a positive trait of edk2 however;
> it's a negative one, in my judgement.
To clarify... I didn't mean that edk2 should willfully ignore dependent
On 08/15/19 18:08, Michael D Kinney wrote:
> Reviewed-by: Michael D Kinney
To summarize: personally, I disgree, but I can accept if the patch goes
in with Mike's R-b.
Thanks,
Laszlo
>> -Original Message-
>> From: devel@edk2.groups.io
>> [mailto:devel@edk2.groups.io] On Behalf Of
On 08/16/19 19:23, vit9...@protonmail.com wrote:
> Laszlo,
>
> I have already mentioned that the documentation is sufficient as
> _Static_assert is C standard
Yes, in a release of the ISO C standard that edk2 does not target.
In addition, edk2 already has several restrictions in place against
start the next development cycle.
>
> Thanks
> Laszlo
>
>> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Yao,
>> Jiewen
>> Sent: Thursday, August 15, 2019 9:05 AM
>> To: devel@edk2.groups.io; vit9...@protonmail.com; Kinney, Michael D
>>
9...@protonmail.com; Kinney, Michael D
>
> Cc: Laszlo Ersek
> Subject: Re: [edk2-devel] [PATCH v2 1/1] MdePkg: Add STATIC_ASSERT macro
>
> Good input.
> I think we should separate the work to convert all EDKII code to use
> STATIC_ASSERT.
> We can do that work once we add S
t;> STATIC_ASSERT (sizeof (UINT16) == 2, "sizeof (UINT16) does not meet UEFI
>> Specification Data Type requirements")
>> STATIC_ASSERT (sizeof (INT32) == 4, "sizeof (INT32) does not meet UEFI
>> Specification Data Type requirements")
>> STATIC_ASSERT (sizeof (C
Reviewed-by: Michael D Kinney
Mike
> -Original Message-
> From: devel@edk2.groups.io
> [mailto:devel@edk2.groups.io] On Behalf Of vit9696 via
> Groups.Io
> Sent: Tuesday, August 13, 2019 1:17 AM
> To: devel@edk2.groups.io
> Subject: [edk2-devel] [PATCH v2 1/1] MdePkg: Add
>
...@linaro.org;
af...@apple.com; Cetola, Stephano
Subject: Re: [edk2-devel] [PATCH v2 1/1] MdePkg: Add STATIC_ASSERT macro
Liming,
Thank you for adding everyone to the CC list. Yes, I would like this to be
merged into the next EDK II stable release.
Best regards,
Vitaly
On чт, авг. 15, 2019 at 04
> Sent: Thursday, August 15, 2019 9:05 AM
> To: devel@edk2.groups.io; vit9...@protonmail.com; Kinney, Michael D
>
> Cc: Laszlo Ersek
> Subject: Re: [edk2-devel] [PATCH v2 1/1] MdePkg: Add STATIC_ASSERT macro
>
> Good input.
>
> I think we should separate the work to co
] On Behalf Of Yao,
Jiewen
Sent: Thursday, August 15, 2019 9:05 AM
To: devel@edk2.groups.io; vit9...@protonmail.com; Kinney, Michael D
Cc: Laszlo Ersek
Subject: Re: [edk2-devel] [PATCH v2 1/1] MdePkg: Add STATIC_ASSERT macro
Good input.
I think we should separate the work to convert all EDKII code
:23 AM
To: Kinney, Michael D
Cc: devel@edk2.groups.io; Laszlo Ersek
Subject: Re: [edk2-devel] [PATCH v2 1/1] MdePkg: Add STATIC_ASSERT macro
Michael, Liming, Laszlo,
Static assertions via _Static_assert are standard C11 functionality, thus any
at least C11 (ISO/IEC 9899 2011) conforming compiler
Size of enum does not
> meet UEFI Specification Data Type requirements")
> STATIC_ASSERT (sizeof (__VERIFY_UINT32_ENUM_SIZE) == 4, "Size of enum does
> not meet UEFI Specification Data Type requirements")
>
> Thanks,
>
> Mike
>
>> -Original
_SIZE) == 4, "Size of enum does not
meet UEFI Specification Data Type requirements")
Thanks,
Mike
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io]
> On Behalf Of Liming Gao
> Sent: Wednesday, August 14, 2019 6:50 AM
> To: devel@edk
Can you add the sample usage of new macro STATIC_ASSERT?
Or, give the link of static_assert or _Static_assert.
If so, the developer knows how to use them in source code.
Thanks
Liming
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of vit9696
24 matches
Mail list logo
