Re: [edk2-devel] [PATCH v2 2/4] OvmfPkg/VirtioMmioDeviceLib: Add virtio 1.0 support.

2021-08-16 Thread Philippe Mathieu-Daudé
On 8/16/21 3:35 PM, Yao, Jiewen wrote: > Hi Greg > Can we define MACRO to replace 1 or 2? That is very confusing. > > For example, > #define VIRT_IO_DEVICE_VERSION_0_95 1 > #define VIRT_IO_DEVICE_VERSION_1_00 2 Good idea. > > Thank you > Yao Jiewen -=-=-=-=-=-=-=-=-=-=-=- Groups.io

Re: [edk2-devel] [PATCH v2 2/4] OvmfPkg/VirtioMmioDeviceLib: Add virtio 1.0 support.

2021-08-16 Thread Yao, Jiewen
hilippe Mathieu-Daude > Subject: Re: [edk2-devel] [PATCH v2 2/4] OvmfPkg/VirtioMmioDeviceLib: Add > virtio 1.0 support. > > Hi Greg > Can we define MACRO to replace 1 or 2? That is very confusing. > > For example, > #define VIRT_IO_DEVICE_VERSION_0_95 1 > #define VIR

Re: [edk2-devel] [PATCH v2 2/4] OvmfPkg/VirtioMmioDeviceLib: Add virtio 1.0 support.

2021-08-16 Thread Yao, Jiewen
Hi Greg Can we define MACRO to replace 1 or 2? That is very confusing. For example, #define VIRT_IO_DEVICE_VERSION_0_95 1 #define VIRT_IO_DEVICE_VERSION_1_00 2 Thank you Yao Jiewen > -Original Message- > From: devel@edk2.groups.io On Behalf Of Gerd > Hoffmann > Sent: Monday, August