Re: [edk2-devel] [PATCH v2 4/5] MdeModulePkg/Bus/Pci/PciBusDxe: Fix NULL_RETURNS Coverity issue

On 11/20/23 04:57, Ranbir Singh wrote: > > > On Wed, Nov 15, 2023 at 3:20 PM Laszlo Ersek > wrote: > > On 11/14/23 17:21, Kinney, Michael D wrote: > > Hi Ranbir, > > > >   > > > > First I want to recognize your efforts to collect Coverity

Re: [edk2-devel] [PATCH v2 4/5] MdeModulePkg/Bus/Pci/PciBusDxe: Fix NULL_RETURNS Coverity issue

*Cc:* devel@edk2.groups.io; Ni, Ray ; Veeresh Sangolli *Subject:* Re: [edk2-devel] [PATCH v2 4/5] MdeModulePkg/Bus/Pci/PciBusDxe: Fix NULL_RETURNS Coverity issue On Mon, Nov 13, 2023 at 4:58 PM Laszlo Ersek mailto:ler...@redhat.com>> wrote:     On 11/10/23 07:11, Ranbir Singh wrote:

Re: [edk2-devel] [PATCH v2 4/5] MdeModulePkg/Bus/Pci/PciBusDxe: Fix NULL_RETURNS Coverity issue

On Wed, Nov 15, 2023 at 3:20 PM Laszlo Ersek wrote: > On 11/14/23 17:21, Kinney, Michael D wrote: > > Hi Ranbir, > > > > > > > > First I want to recognize your efforts to collect Coverity issues and > > propose changes to address > > them. > > > > I still disagree with adding CpuDealLoop() for

Re: [edk2-devel] [PATCH v2 4/5] MdeModulePkg/Bus/Pci/PciBusDxe: Fix NULL_RETURNS Coverity issue

;> We also have to evaluate if a return error status with a DEBUG_ERROR >> message would be a better >> >> choice than an ASSERT() that can be filtered out by build options. >> >> Best regards, >> >> Mike >> >> *From:* devel@edk2.groups.io *On

Re: [edk2-devel] [PATCH v2 4/5] MdeModulePkg/Bus/Pci/PciBusDxe: Fix NULL_RETURNS Coverity issue

On 11/14/23 17:53, Ranbir Singh wrote: > Generally speaking, there now seems to be different views coming from > you and Laszlo. Yes. > We might have to wait for some sort of agreement to be > reached. I don't insist on CpuDeadLoop() *specifically*. Only the following two generic points matter

Re: [edk2-devel] [PATCH v2 4/5] MdeModulePkg/Bus/Pci/PciBusDxe: Fix NULL_RETURNS Coverity issue

On 11/14/23 17:21, Kinney, Michael D wrote: > Hi Ranbir, > >   > > First I want to recognize your efforts to collect Coverity issues and > propose changes to address > them. > > I still disagree with adding CpuDealLoop() for any static analysis issues. > > There have been previous discussions

Re: [edk2-devel] [PATCH v2 4/5] MdeModulePkg/Bus/Pci/PciBusDxe: Fix NULL_RETURNS Coverity issue

Behalf Of *Ranbir Singh *Sent:* Tuesday, November 14, 2023 7:08 AM *To:* Laszlo Ersek *Cc:* devel@edk2.groups.io; Ni, Ray ; Veeresh Sangolli *Subject:* Re: [edk2-devel] [PATCH v2 4/5] MdeModulePkg/Bus/Pci/PciBusDxe: Fix NULL_RETURNS Coverity issue On Mon, Nov 13, 2023 at 4:58 PM Laszlo Ersek <m

Re: [edk2-devel] [PATCH v2 4/5] MdeModulePkg/Bus/Pci/PciBusDxe: Fix NULL_RETURNS Coverity issue

szlo. We might have to wait for some sort of agreement to be reached. > > > *From:* devel@edk2.groups.io * On Behalf Of *Ranbir > Singh > *Sent:* Tuesday, November 14, 2023 7:08 AM > *To:* Laszlo Ersek > *Cc:* devel@edk2.groups.io; Ni, Ray ; Veeresh Sangolli < > veeresh.sango...@de

Re: [edk2-devel] [PATCH v2 4/5] MdeModulePkg/Bus/Pci/PciBusDxe: Fix NULL_RETURNS Coverity issue

Sangolli Subject: Re: [edk2-devel] [PATCH v2 4/5] MdeModulePkg/Bus/Pci/PciBusDxe: Fix NULL_RETURNS Coverity issue On Mon, Nov 13, 2023 at 4:58 PM Laszlo Ersek mailto:ler...@redhat.com>> wrote: On 11/10/23 07:11, Ranbir Singh wrote: > EFI_NOT_READY was listed as one of the error retu

Re: [edk2-devel] [PATCH v2 4/5] MdeModulePkg/Bus/Pci/PciBusDxe: Fix NULL_RETURNS Coverity issue

On Mon, Nov 13, 2023 at 4:58 PM Laszlo Ersek wrote: > On 11/10/23 07:11, Ranbir Singh wrote: > > EFI_NOT_READY was listed as one of the error return values in the > > function header of StartPciDevices(). So, I considered it here. > > > > Maybe we can go by a dual approach, including

Re: [edk2-devel] [PATCH v2 4/5] MdeModulePkg/Bus/Pci/PciBusDxe: Fix NULL_RETURNS Coverity issue

On 11/10/23 07:11, Ranbir Singh wrote: > EFI_NOT_READY was listed as one of the error return values in the > function header of StartPciDevices(). So, I considered it here. > > Maybe we can go by a dual approach, including CpuDeadLoop() in > StartPciDevices() as well as add return value check at

Re: [edk2-devel] [PATCH v2 4/5] MdeModulePkg/Bus/Pci/PciBusDxe: Fix NULL_RETURNS Coverity issue

EFI_NOT_READY was listed as one of the error return values in the function header of StartPciDevices(). So, I considered it here. Maybe we can go by a dual approach, including CpuDeadLoop() in StartPciDevices() as well as add return value check at the call site in PciBusDriverBindingStart(). On

Re: [edk2-devel] [PATCH v2 4/5] MdeModulePkg/Bus/Pci/PciBusDxe: Fix NULL_RETURNS Coverity issue

On 11/7/23 07:19, Ranbir Singh wrote: > From: Ranbir Singh > > The function StartPciDevices has a check > > ASSERT (RootBridge != NULL); > > but this comes into play only in DEBUG mode. In Release mode, there > is no handling if the RootBridge value is NULL and the code proceeds > to