Re: [edk2-devel] [Patch] BaseTools/Build: Fix Structured PCD app host env issues

2020-02-02 Thread Liming Gao
Mike: Sorry. This edk2\BaseTools\get_vsvars.bat can set VS host env. Thanks Liming > -Original Message- > From: Kinney, Michael D > Sent: Saturday, February 1, 2020 12:43 AM > To: Gao, Liming ; devel@edk2.groups.io; Kinney, Michael > D > Cc: Feng, Bob C > Subject: RE: [Patch]

Re: [edk2-devel] [Patch] BaseTools/Build: Fix Structured PCD app host env issues

2020-02-01 Thread Michael D Kinney
host env? Thanks, Mike From: sean.brogan via [] Sent: Friday, January 31, 2020 4:33 PM To: Kinney, Michael D ; devel@edk2.groups.io Subject: Re: [edk2-devel] [Patch] BaseTools/Build: Fix Structured PCD app host env issues Mike, The hardcoded vs paths are not a safe assumption. I would rather

Re: [edk2-devel] [Patch] BaseTools/Build: Fix Structured PCD app host env issues

2020-01-31 Thread Sean via Groups.Io
Mike, The hardcoded vs paths are not a safe assumption. I would rather see agreement of how the environment should be configured prior to calling edk2 build and if being capable of building host os specific binaries is the requirement then that should be clarified and the scripts can be

Re: [edk2-devel] [Patch] BaseTools/Build: Fix Structured PCD app host env issues

2020-01-31 Thread Michael D Kinney
Liming, That script does not set everything up to build host apps for all VS20xx tool chains. It works for VS2017, VS2019, but not any of the others. It sets env vars for those other tool chains but Does not run the VS environment setup script that updates PATH and sets LIBS and INC to support

Re: [edk2-devel] [Patch] BaseTools/Build: Fix Structured PCD app host env issues

2020-01-31 Thread Liming Gao
Mike: I suggest to call BaseTools\set_vsprefix_envs.bat to setup VS environment. Its input parameter is VS2012, VS2013, VS2015, VS2017, VS2019. If so, we don't need to add VS installation path in Build python script. Thanks Liming > -Original Message- > From: Kinney, Michael D >