Re: [edk2-devel] [Patch] BaseTools/DscBuildData: Fix PCD autogen include file conflict

2020-02-04 Thread Michael D Kinney
Liming, I have entered the following BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2503 Mike > -Original Message- > From: Gao, Liming > Sent: Monday, February 3, 2020 10:45 PM > To: Kinney, Michael D ; > devel@edk2.groups.io > Cc: Feng, Bob C ; Gao, Liming > > Subject: RE:

Re: [edk2-devel] [Patch] BaseTools/DscBuildData: Fix PCD autogen include file conflict

2020-02-03 Thread Liming Gao
Mike: If we document this assumption in build specification, I agree this patch. Can you enter one BZ for build spec update? For this patch, Reviewed-by: Liming Gao Thanks Liming > -Original Message- > From: Kinney, Michael D > Sent: Tuesday, February 4, 2020 1:52 AM > To: Gao,

Re: [edk2-devel] [Patch] BaseTools/DscBuildData: Fix PCD autogen include file conflict

2020-02-03 Thread Michael D Kinney
Liming, Yes. I think that is a reasonable assumption. We can document that restriction in the EDK II Build Specification that standard POSIX include files (e.g. ) must never be placed in the same directory with other include files that are required for Structured PCD data types or

Re: [edk2-devel] [Patch] BaseTools/DscBuildData: Fix PCD autogen include file conflict

2020-02-02 Thread Liming Gao
Mike: Yes. Build tool needs to know host OS behavior and get the full include path. For this patch, it skips some include paths. If this include path also includes other required header file, it will cause the build break. Can we have the assumption that all sys header files and other non-sys

Re: [edk2-devel] [Patch] BaseTools/DscBuildData: Fix PCD autogen include file conflict

2020-02-02 Thread Michael D Kinney
Liming, The build tools would need to know which env var to query for all OS/host tool chain combinations and how to parse that information for full paths in an OS specific manner. We should not build that type of information into the build tools. The fix I have provided does not need this

Re: [edk2-devel] [Patch] BaseTools/DscBuildData: Fix PCD autogen include file conflict

2020-02-02 Thread Liming Gao
Mike: Another way is to parse INCLUDE env value and add the system PATH into -I options as the first priority. Thanks Liming > -Original Message- > From: Kinney, Michael D > Sent: Thursday, January 30, 2020 8:46 AM > To: devel@edk2.groups.io > Cc: Feng, Bob C ; Gao, Liming >

Re: [edk2-devel] [Patch] BaseTools/DscBuildData: Fix PCD autogen include file conflict

2020-02-02 Thread Liming Gao
Mike: Can we consider to parse INCLUDE env value and add those path to -I options as the first priority? Thanks Liming > -Original Message- > From: Kinney, Michael D > Sent: Thursday, January 30, 2020 8:46 AM > To: devel@edk2.groups.io > Cc: Feng, Bob C ; Gao, Liming > Subject: