Re: [edk2-devel] [Patch 1/2] ShellPkg: Add NetworkPkg/NetworkPkg.dec as the package dependency

2019-05-20 Thread Gao, Zhichao
Reviewed-by: Zhichao Gao > -Original Message- > From: Gao, Liming > Sent: Tuesday, May 21, 2019 9:06 AM > To: Carsey, Jaben ; devel@edk2.groups.io > Cc: Gao, Zhichao ; Ni, Ray > Subject: RE: [Patch 1/2] ShellPkg: Add NetworkPkg/NetworkPkg.dec as the > package dependency > > Jaben: >

Re: [edk2-devel] [Patch 1/2] ShellPkg: Add NetworkPkg/NetworkPkg.dec as the package dependency

2019-05-20 Thread Liming Gao
Jaben: Yes. MdeModulePkg is still required. Thanks Liming > -Original Message- > From: Carsey, Jaben > Sent: Tuesday, May 21, 2019 12:35 AM > To: Gao, Liming ; devel@edk2.groups.io > Cc: Gao, Zhichao ; Ni, Ray > Subject: RE: [Patch 1/2] ShellPkg: Add NetworkPkg/NetworkPkg.dec as the

Re: [edk2-devel] [Patch 1/2] ShellPkg: Add NetworkPkg/NetworkPkg.dec as the package dependency

2019-05-20 Thread Carsey, Jaben
Netlib class definition and instance are both moving? Are these modules using MdeModulePkg for a different lib or can we remove it? > -Original Message- > From: Gao, Liming > Sent: Monday, May 20, 2019 6:09 AM > To: devel@edk2.groups.io > Cc: Gao, Zhichao ; Ni, Ray ; > Carsey, Jaben >