Re: [edk2-devel] [RFC PATCH 1/1] MdeModulePkg/PiDxeS3BootScriptLib: Use SafeIntLib to avoid truncation

2020-02-17 Thread GuoMinJ
I agree with this comment. Laszlo Ersek 于2020年2月17日周一 下午5:32写道: > On 02/13/20 19:33, Philippe Mathieu-Daudé wrote: > > On 2/13/20 7:29 PM, Philippe Mathieu-Daude wrote: > >> Math expressions written in terms of SafeIntLib function calls > >> are easily readable, making review trivial. Convert

Re: [edk2-devel] [RFC PATCH 1/1] MdeModulePkg/PiDxeS3BootScriptLib: Use SafeIntLib to avoid truncation

2020-02-17 Thread GuoMinJ
I agree with this comment. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#54572): https://edk2.groups.io/g/devel/message/54572 Mute This Topic: https://groups.io/mt/71248587/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe:

Re: [edk2-devel] [RFC PATCH 1/1] MdeModulePkg/PiDxeS3BootScriptLib: Use SafeIntLib to avoid truncation

2020-02-17 Thread GuoMinJ
I agree with this comment. Thanks. Guomin -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#54570): https://edk2.groups.io/g/devel/message/54570 Mute This Topic: https://groups.io/mt/71248587/21656 Group Owner: devel+ow...@edk2.groups.io

Re: [edk2-devel] [RFC PATCH 1/1] MdeModulePkg/PiDxeS3BootScriptLib: Use SafeIntLib to avoid truncation

2020-02-17 Thread Laszlo Ersek
On 02/13/20 19:33, Philippe Mathieu-Daudé wrote: > On 2/13/20 7:29 PM, Philippe Mathieu-Daude wrote: >> Math expressions written in terms of SafeIntLib function calls >> are easily readable, making review trivial. Convert the truncation >> checks added by commit 322ac05f8 to SafeIntLib calls. >>

Re: [edk2-devel] [RFC PATCH 1/1] MdeModulePkg/PiDxeS3BootScriptLib: Use SafeIntLib to avoid truncation

2020-02-13 Thread Philippe Mathieu-Daudé
On 2/13/20 7:29 PM, Philippe Mathieu-Daude wrote: Math expressions written in terms of SafeIntLib function calls are easily readable, making review trivial. Convert the truncation checks added by commit 322ac05f8 to SafeIntLib calls. Cc: Jian J Wang Cc: Hao A Wu Cc: Eric Dong Suggested-by: