We are working on auto assignment.
Right now, maintainers need to watch new PRs and do assignments.
Mike
From: Dhaval Sharma
Sent: Thursday, June 20, 2024 10:16 PM
To: Kinney, Michael D ; devel@edk2.groups.io
Subject: Re: [edk2-devel] GitHub PR Code Review process now active
Hi Michael,
Just
Hi Michael,
Just to clarify my understanding. Once a PR is submitted (or it moves from
draft to regular PR state), it automatically gets reviewers assigned? I
submitted this one https://github.com/tianocore/edk2/pull/5802 and was
wondering if I should be sending maintainers an email or be assure
.io; Kinney, Michael D
Subject: Re: [edk2-devel] GitHub PR Code Review process now active
On 6/5/2024 4:21 PM, Michael D Kinney via groups.io wrote:
* Some PRs have been merged using the "Rebase and Merge" button in the
PR after all required reviews completed and all CI chec
s.io; Kinney, Michael D
> Subject: RE: [edk2-devel] GitHub PR Code Review process now active
>
>
> Hi Mike,
>
> Glad to see EDK2 PR code review process is active.
> In Slim Bootloader project, it runs BaseTools/Scripts/PatchCheck.py to check
> the PR commit message when running
starting a review.
>
> The CI tests include combinations of OS/compiler that not all
> contributors have available.
>
> Mike
>
> > -Original Message-
> > From: Neal Gompa
> > Sent: Monday, June 3, 2024 11:47 AM
> > To: devel@edk2.groups.io; K
of these known issues for another week and
then evaluate if it should be applied to edk2-platforms yet.
Mike
> -Original Message-
> From: Rebecca Cran
> Sent: Wednesday, June 5, 2024 3:48 PM
> To: devel@edk2.groups.io; Kinney, Michael D
> Subject: Re: [edk2-devel] GitHub PR
On 6/5/2024 4:21 PM, Michael D Kinney via groups.io wrote:
* Some PRs have been merged using the "Rebase and Merge" button in the
PR after all required reviews completed and all CI checks pass. Instead,
the "push" label should continue to be used. There does not appear to be
any unexpect
redo again
Using "Update with rebase"
Please provide feedback if you are seeing other issues or have other suggestions
to improve the process.
Thanks,
Mike
> -Original Message-
> From: Kinney, Michael D
> Sent: Monday, June 3, 2024 12:38 PM
> To: Neal Gompa ; de
On Mon, Jun 03, 2024 at 02:46:30PM GMT, Neal Gompa wrote:
> That said, draft PRs cannot be reviewed, so we should not be telling
> people to make draft PRs.
It makes sense to open draft PRs, work in the PR until CI is clean,
only then flip the PR to 'ready' and bother maintainers to review.
take
Gompa
> Sent: Monday, June 3, 2024 11:47 AM
> To: devel@edk2.groups.io; Kinney, Michael D
> Subject: Re: [edk2-devel] GitHub PR Code Review process now active
>
> Hmm, I don't see a setting for it anymore, maybe that's not a thing anymore?
>
> I seemingly recall that
his. Do you happen to know where
> this is configurable or a link to GitHub docs for configuration?
>
> Mike
>
> > -Original Message-
> > From: Neal Gompa
> > Sent: Monday, June 3, 2024 9:13 AM
> > To: devel@edk2.groups.io; Kinney, Michael D
> > Subj
> -Original Message-
> From: Neal Gompa
> Sent: Monday, June 3, 2024 9:13 AM
> To: devel@edk2.groups.io; Kinney, Michael D
> Subject: Re: [edk2-devel] GitHub PR Code Review process now active
>
> On Tue, May 28, 2024 at 2:53 PM Michael D Kinney via groups.io
> wrote:
&g
On Tue, May 28, 2024 at 2:53 PM Michael D Kinney via groups.io
wrote:
>
> Hello,
>
> The GitHub PR code review process is now active. Please
> use the new PR based code review process for all new
> submissions starting today.
>
> * The Wiki has been updated with the process changes.
>
>
> http
;
kra...@redhat.com; Kubacki, Michael
Cc: Kinney, Michael D
Subject: RE: [edk2-devel] GitHub PR Code Review process now active
Yes.
Mike
-Original Message-
From: Kasbekar, Saloni
Sent: Thursday, May 30, 2024 10:39 AM
To: devel@edk2.groups.io; mikub...@linux.microsoft.com; Kinney, Mich
1 AM
> To: Kasbekar, Saloni ; devel@edk2.groups.io;
> mikub...@linux.microsoft.com; Rebecca Cran ;
> kra...@redhat.com; Kubacki, Michael
> Cc: Kinney, Michael D
> Subject: RE: [edk2-devel] GitHub PR Code Review process now active
>
> Yes.
>
> Mike
>
> > -Ori
Wednesday, May 29, 2024 5:51 PM
> To: Kinney, Michael D ; devel@edk2.groups.io;
> Rebecca Cran ; kra...@redhat.com; Kubacki, Michael
>
> Subject: Re: [edk2-devel] GitHub PR Code Review process now active
>
> I've updated the wiki process to clarify that maintainers need to
.groups.io;
Rebecca Cran ; kra...@redhat.com; Kubacki, Michael
Subject: Re: [edk2-devel] GitHub PR Code Review process now active
I've updated the wiki process to clarify that maintainers need to ensure PR
reviewers are added and that a contributor cannot do so unless they are a
maintainer in
hael D
> Cc: Michael Kubacki ; devel@edk2.groups.io;
> Rebecca Cran ; Kubacki, Michael
>
> Subject: Re: [edk2-devel] GitHub PR Code Review process now active
>
> On Wed, May 29, 2024 at 08:06:00PM GMT, Kinney, Michael D wrote:
> > We could, but that would require manually syncin
On Wed, May 29, 2024 at 08:06:00PM GMT, Kinney, Michael D wrote:
> We could, but that would require manually syncing CODEOWNERS
> with Maintainer.txt until that part of the process is automated.
https://github.com/tianocore/edk2/pull/5703 ;)
take care,
Gerd
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io
Michael D ;
Rebecca Cran ; kra...@redhat.com; Kubacki, Michael
Subject: Re: [edk2-devel] GitHub PR Code Review process now active
Mike,
I agree that automatically adding reviewers would be helpful.
Do you think we could add a CODEOWNERS file now to assist with this?
Benefits being:
1. CODEOWN
en button when I see it.)
Thank you
Yao, Jiewen
From: devel@edk2.groups.io On Behalf Of Chang, Abner via
groups.io
Sent: Wednesday, May 29, 2024 10:48 PM
To: Kinney, Michael D ; devel@edk2.groups.io
Cc: Kinney, Michael D
Subject: Re: [edk2-devel] GitHub PR Code Review process now active
[A
a...@redhat.com; Kubacki, Michael
>
> Subject: Re: [edk2-devel] GitHub PR Code Review process now active
>
> Mike,
>
> I agree that automatically adding reviewers would be helpful.
>
> Do you think we could add a CODEOWNERS file now to assist with this?
>
> Benefits
assigned reviewer.
Mike
-Original Message-
From: Rebecca Cran
Sent: Wednesday, May 29, 2024 11:19 AM
To: devel@edk2.groups.io; Kinney, Michael D ;
kra...@redhat.com; Kubacki, Michael
Subject: Re: [edk2-devel] GitHub PR Code Review process now active
On 5/29/2024 12:09 PM, Michael D
being an
assigned reviewer.
Mike
> -Original Message-
> From: Rebecca Cran
> Sent: Wednesday, May 29, 2024 11:19 AM
> To: devel@edk2.groups.io; Kinney, Michael D ;
> kra...@redhat.com; Kubacki, Michael
> Subject: Re: [edk2-devel] GitHub PR Code Review process now active
On 5/29/2024 12:09 PM, Michael D Kinney via groups.io wrote:
Hi Gerd,
We can clarify the Wiki. A Maintainer has to be involved in every
code review. The first action a Maintainer does is verify that the
code change should be considered at all or rejected. Then add
maintainers for the ones tha
to be involved in reviewing newly
submitted PRs.
Mike
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Gerd Hoffmann
> Sent: Wednesday, May 29, 2024 9:38 AM
> To: devel@edk2.groups.io; Kinney, Michael D
> Subject: Re: [edk2-devel] GitHub PR Code Review pro
On Wed, May 29, 2024 at 03:00:13PM GMT, Michael D Kinney wrote:
> Hi Gerd,
>
> You are in the EDK II Reviewers team.
>
> The current settings only allow members of the EDK II Maintainers
> team to assign reviewers.
That contradicts the wiki instructions which say I should assign
reviewers mysel
process discussion.
Best regards,
Mike
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Gerd Hoffmann
> Sent: Tuesday, May 28, 2024 11:39 PM
> To: devel@edk2.groups.io; Kinney, Michael D
> Subject: Re: [edk2-devel] GitHub PR Code Review process now active
>
[AMD Official Use Only - AMD Internal Distribution Only]
Thanks for the clarification, Mike.
Thanks
Abner
From: Kinney, Michael D
Sent: Wednesday, May 29, 2024 10:44:41 PM
To: Chang, Abner ; devel@edk2.groups.io
Cc: Kinney, Michael D
Subject: RE: GitHub PR Cod
Hi Abner,
Yes. The plan is to apply to all repos.
We want to use it on edk2 for a while to make sure we get the
settings and process correct, then we will expand.
Mike
> -Original Message-
> From: Chang, Abner
> Sent: Wednesday, May 29, 2024 3:41 AM
> To: devel@edk2.groups.io; Kinney,
[AMD Official Use Only - AMD Internal Distribution Only]
Hi Mike,
Wondering if we also plan to apply GitHub PR process on edk2-platforms repo? Or
other repos under tianocore? I found there is another email thread "Enable
GitHub PR, protected branches, and 'push' label" on edk2-platforms, but no
> The GitHub PR code review process is now active. Please
> use the new PR based code review process for all new
> submissions starting today.
>
> * The Wiki has been updated with the process changes.
>
>
> https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process
>
32 matches
Mail list logo
