Linux Kernel soft hangs if 8259 PIC is not configured by BIOS: was (RE: [edk2-devel] [RFC][PATCH v1 0/1] PcAtChipsetPkg: Remove framework modules)

2019-05-28 Thread Kirkendall, Garrett
Since this change will be removing the 8259 PIC driver, I'll mention a quirk I ran into in the Linux Kernel up through at least 5.0 (and I am sure later, I just didn't verify): Does anyone have pull in the Linux Kernel world to get them to take this seriously? Hopefully someday soon end users

[edk2-devel][Patch 6/7] MdeModulePkg/DxeIpl: Support Capsule On Disk.

2019-05-28 Thread Xu, Wei6
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1852 If Capsule On Disk mode, call Capsule On Disk Load PPI to load capsules. When it fails, still goes to Firmware Update boot path. BDS will clear corresponding indicator and reboot later on. Cc: Jian J Wang Cc: Hao A Wu Cc: Chao B Zhang

[edk2-devel][Patch 7/7] MdeModulePkg: Add Capsule On Disk APIs into CapsuleLib.

2019-05-28 Thread Xu, Wei6
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1852 CoDCheckCapsuleOnDiskFlag() is to check if CapsuleOnDisk flag in "OsIndications" Variable is enabled. It is used to indicate whether capsule on disk is provisioned in normal boot path. CoDClearCapsuleOnDiskFlag() is to to clear

[edk2-devel][Patch 1/7] MdePkg: Add Pei Boot In CapsuleOnDisk Mode Ppi definition.

2019-05-28 Thread Xu, Wei6
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1852 This PPI indicates current boot mode is capsule on disk mode. Cc: Michael D Kinney Cc: Liming Gao Cc: Chao B Zhang Signed-off-by: Wei6 Xu --- MdePkg/Include/Ppi/BootInRecoveryMode.h | 9 - MdePkg/MdePkg.dec

[edk2-devel][Patch 2/7] MdeModulePkg: Add Capsule On Disk related definition.

2019-05-28 Thread Xu, Wei6
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1852 This patch will add Capsule On Disk related definition, including GUID, PPI and PCDs: The Capsule On Disk Name GUID indicates the capsule is to store Capsule On Disk file names. The Pei Capsule On Disk PPI provides service to retrieve

[edk2-devel][Patch 4/7] MdeModulePkg/BdsDxe: Support Capsule On Disk.

2019-05-28 Thread Xu, Wei6
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1852 Set EFI_OS_INDICATIONS_FILE_CAPSULE_DELIVERY_SUPPORTED bit of "OsIndicationsSupported" variable to indicate the Capsule On Disk is supported or not, according to PcdCapsuleOnDiskSupport. Cc: Jian J Wang Cc: Hao A Wu Cc: Chao B Zhang

[edk2-devel][Patch 3/7] MdeModulePkg: Add CapsuleOnDiskLoadPei PEIM.

2019-05-28 Thread Xu, Wei6
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1852 This module provides PPI to load Capsule On Disk temp relocation file from Root Directory file system, retrieve the capsules from the temp file and create capsule hobs for these capsules. Cc: Jian J Wang Cc: Hao A Wu Cc: Chao B Zhang

Re: [edk2-devel] OVMF and SMBIOS

2019-05-28 Thread Laszlo Ersek
On 05/28/19 17:18, Tomas Pilar (tpilar) wrote: > Hi, > > I am trying to create kvm instance using libvirt and Qemu and OVMF that also > has SMBIOS included. My current version of Qemu only supports type 0 and type > 1 SMBIOS tables so I specify those. However, when I use smbiosview in the >

Re: Linux Kernel soft hangs if 8259 PIC is not configured by BIOS: was (RE: [edk2-devel] [RFC][PATCH v1 0/1] PcAtChipsetPkg: Remove framework modules)

2019-05-28 Thread Kirkendall, Garrett
See below -Original Message- From: Kinney, Michael D Sent: Tuesday, May 28, 2019 12:07 PM To: Kirkendall, Garrett ; devel@edk2.groups.io; Wu, Hao A ; Kinney, Michael D Cc: Ni, Ray ; Andrew Fish ; Laszlo Ersek ; Leif Lindholm Subject: RE: Linux Kernel soft hangs if 8259 PIC is not

Re: [edk2-devel] [PATCH] BaseTools/GenBiosId: Add a new tool GenBiosId

2019-05-28 Thread Michael D Kinney
Could this tools be ported to Python using the python struct module to access C structures? The implementation may be much simpler if python was used for command line parsing. And this capability could also be provided as a python module to support direct access from pre/post build steps

Re: Linux Kernel soft hangs if 8259 PIC is not configured by BIOS: was (RE: [edk2-devel] [RFC][PATCH v1 0/1] PcAtChipsetPkg: Remove framework modules)

2019-05-28 Thread Michael D Kinney
Hi Garrett, Two thoughts on this issue: 1) Just because 8259 is not used by UEFI FW does not mean the 8259 HW should not be initialized into an OS compatible state. This init code could be part of the chipset/si init code without requiring the 8259 driver/protocol. 2) The HPET driver in

Re: Linux Kernel soft hangs if 8259 PIC is not configured by BIOS: was (RE: [edk2-devel] [RFC][PATCH v1 0/1] PcAtChipsetPkg: Remove framework modules)

2019-05-28 Thread Leif Lindholm
Hi Garrett, Presumably you mean https://lkml.org/lkml/2019/5/9/304? I'm not familiar enough with the PC platform to stick my oar in, but Gleixner's counterquestion is an honest one - he does not see an obvious solution to the problem. And unless someone finds the problem interesting, this is

Re: [edk2-devel] [PATCH v2 1/7] EmbeddedPkg: Add SD command support for DwEmmc

2019-05-28 Thread Leif Lindholm
Hi Tien Hock, Thanks for resubmitting this. On Mon, May 27, 2019 at 05:30:22PM +0800, tien.hock@intel.com wrote: > From: "TIen Hock, Loh" > > Added ACMD6 for SD support. For SD, after CMD55 is sent, the next > command should be an application command, which should not expect > data > >

Re: [edk2-devel] [PATCH v2 2/7] EmbeddedPkg: Fix DwEmmc CMD8 support for SD

2019-05-28 Thread Leif Lindholm
On Mon, May 27, 2019 at 05:30:23PM +0800, tien.hock@intel.com wrote: > From: "Tien Hock, Loh" > > On CMD8, for SD, the controller should not expect data as this is a > SEND_IF_COND command to verify SD operating condition, and does not have > data. > > Signed-off-by: Tien Hock, Loh > Cc:

Re: [edk2-devel] [PATCH v2 7/7] EmbeddedPkg: Fix DwEmmc read/write size in preparing DMA size

2019-05-28 Thread Leif Lindholm
On Mon, May 27, 2019 at 05:30:28PM +0800, tien.hock@intel.com wrote: > From: "Tien Hock, Loh" > > Add support for reading data that is less than DWEMMC_BLOCK_SIZE, > otherwise it would read bigger data than requested and cause errors > > Signed-off-by: "Tien Hock, Loh" > Cc: Leif Lindholm

Re: [edk2-devel] [PATCH v2 3/7] EmbeddedPkg: Send command when MMC ask for response

2019-05-28 Thread Leif Lindholm
On Mon, May 27, 2019 at 05:30:24PM +0800, tien.hock@intel.com wrote: > From: "Tien Hock, Loh" > > Send command when MMC ask for response in DwEmmcReceiveResponse, and > command is a pending command (eg. DMA needs to be set up first) > > Signed-off-by: "Tien Hock, Loh" > Cc: Leif Lindholm

Re: [edk2-devel] [PATCH v2 4/7] EmbeddedPkg: Fix response check flag

2019-05-28 Thread Leif Lindholm
On Mon, May 27, 2019 at 05:30:25PM +0800, tien.hock@intel.com wrote: > From: "Tien Hock, Loh" > > Do not send CRC response check if the MMC command does not support CRC > response > > Signed-off-by: Tien Hock, Loh > Cc: Leif Lindholm > Cc: Ard Biesheuvel Reviewed-by: Leif Lindholm >

Re: [edk2-devel] [PATCH v2 5/7] EmbeddedPkg: Clear CTYPE on initialization

2019-05-28 Thread Leif Lindholm
On Mon, May 27, 2019 at 05:30:26PM +0800, tien.hock@intel.com wrote: > From: "Tien Hock, Loh" > > Clear CTYPE on initialization. This is important if previous bootloader > changes the CTYPE can cause the controller to not initialize correctly > if CTYPE is not reset to 0 > > Signed-off-by:

Re: [edk2-devel] [PATCH v2 6/7] EmbeddedPkg: Fix DwEmmc SendCommand polling

2019-05-28 Thread Leif Lindholm
+Haojian, Haojian - since you are the original author, can you comment on the delays? Are these silicon bug workarounds (so we need to add a Pcd), or does these changes work on your platforms too? Regards, Leif On Mon, May 27, 2019 at 05:30:27PM +0800, tien.hock@intel.com wrote: > From:

<    1   2