Re: [edk2-devel][Patch v2 1/7] MdePkg: Add Pei Boot In CapsuleOnDisk Mode Ppi definition.

> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Xu, > Wei6 > Sent: Wednesday, June 05, 2019 11:42 PM > To: devel@edk2.groups.io > Cc: Kinney, Michael D; Gao, Liming; Zhang, Chao B; Xu, Wei6 > Subject: [edk2-devel][Patch v2 1/7] MdePkg: Add Pei

Re: [edk2-devel][Patch v2 0/7] Implement Capsule On Disk.

Hello Chao, Do you have any comment/feedback on this series? One comment with regard to the series below: > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Xu, Wei6 > Sent: Wednesday, June 05, 2019 11:42 PM > To: devel@edk2.groups.io > Cc:

Re: [edk2-devel] [PATCH] MdeModulePkg/PeiMain: Substantial change for PeiAllocatePool

Hi Zhichao, On 06/12/19 06:50, Gao, Zhichao wrote: > From: Bret Barkelew > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1901 > > The original logic is ASSERT if fail to create HOB. But > that doesn't make sense for release version. So it is required > to set the Buffer to null to

Re: [edk2-devel][Patch v2 7/7] MdeModulePkg: Add Capsule On Disk APIs into CapsuleLib.

> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Xu, > Wei6 > Sent: Wednesday, June 05, 2019 11:42 PM > To: devel@edk2.groups.io > Cc: Wang, Jian J; Wu, Hao A; Zhang, Chao B; Xu, Wei6 > Subject: [edk2-devel][Patch v2 7/7] MdeModulePkg: Add

Re: [edk2-devel][Patch v2 3/7] MdeModulePkg: Add CapsuleOnDiskLoadPei PEIM.

> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Xu, > Wei6 > Sent: Wednesday, June 05, 2019 11:42 PM > To: devel@edk2.groups.io > Cc: Wang, Jian J; Wu, Hao A; Zhang, Chao B; Xu, Wei6 > Subject: [edk2-devel][Patch v2 3/7] MdeModulePkg: Add >

Re: [edk2-devel][Patch v2 6/7] MdeModulePkg/DxeIpl: Support Capsule On Disk.

> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Xu, > Wei6 > Sent: Wednesday, June 05, 2019 11:42 PM > To: devel@edk2.groups.io > Cc: Wang, Jian J; Wu, Hao A; Zhang, Chao B; Xu, Wei6 > Subject: [edk2-devel][Patch v2 6/7] MdeModulePkg/DxeIpl:

Re: [edk2-devel][Patch v2 2/7] MdeModulePkg: Add Capsule On Disk related definition.

> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Xu, > Wei6 > Sent: Wednesday, June 05, 2019 11:42 PM > To: devel@edk2.groups.io > Cc: Wang, Jian J; Wu, Hao A; Zhang, Chao B; Xu, Wei6 > Subject: [edk2-devel][Patch v2 2/7] MdeModulePkg: Add

Re: [edk2-devel][Patch v2 5/7] MdeModulePkg/CapsuleRuntimeDxe: Introduce PCD to control this feature.

> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Xu, > Wei6 > Sent: Wednesday, June 05, 2019 11:42 PM > To: devel@edk2.groups.io > Cc: Wang, Jian J; Wu, Hao A; Zhang, Chao B; Xu, Wei6 > Subject: [edk2-devel][Patch v2 5/7]

Re: [edk2-devel][Patch v2 1/7] MdePkg: Add Pei Boot In CapsuleOnDisk Mode Ppi definition.

Wei: >-Original Message- >From: Wu, Hao A >Sent: Wednesday, June 12, 2019 3:48 PM >To: devel@edk2.groups.io; Xu, Wei6 >Cc: Kinney, Michael D ; Gao, Liming >; Zhang, Chao B >Subject: RE: [edk2-devel][Patch v2 1/7] MdePkg: Add Pei Boot In >CapsuleOnDisk Mode Ppi definition. > >>

Re: [edk2-devel] [PATCH] CryptoPkg: Add lacking instances for build only

On 06/12/19 04:39, Gao, Zhichao wrote: > From: Bret Barkelew > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1900 > > Add the lacking instance to [Componnets] of dsc file > for build only. > > Cc: Jian Wang > Cc: Ting Ye > Cc: Liming Gao > Cc: Sean Brogan > Cc: Michael Turner >

Re: [edk2-devel] RFC for Edk2-ToolEnv

Both of these RFCs listed flake8 because that is what we have today and it should be relatively easy to get parity.  I am super happy to have you add/propose/provide pr with additional test capability like Pylint.  Thats one of the goals of adding this to tianocore. You can see what we are

Re: [edk2-devel][Patch v2 0/7] Implement Capsule On Disk.

HI Hao: I don't have extra comments for the whole patch From: Wu, Hao A Sent: Wednesday, June 12, 2019 3:48 PM To: devel@edk2.groups.io; Xu, Wei6 ; Zhang, Chao B Cc: Wang, Jian J ; Kinney, Michael D ; Gao, Liming Subject: RE: [edk2-devel][Patch v2 0/7] Implement Capsule On Disk. Hello

Re: [edk2-devel] [edk2-platforms PATCH v1 1/1 -resend] Platform/ARM/JunoPkg: Add support for PPTT dynamic generation

Reviewed-by: Alexei Fedorov Alexei From: devel@edk2.groups.io on behalf of Krzysztof Koch via Groups.Io Sent: 12 June 2019 10:31 To: devel@edk2.groups.io Cc: Ard Biesheuvel; Leif Lindholm; Michael D Kinney; Sami Mujawar; Matteo Carlini; Stephanie

Re: [edk2-devel] UEFI SCT Build Broken

Hi Ashish, Thank for raising this issue. UEFI SCT build pass with edk2-stable201903, and fail on edk2-stable201905, because edk2 drop the IPF support (4e1daa60f5372c22a11503961061ffa569eaf873). UEFI SCT can remove IPF support too. I can follow it tomorrow. Thanks. Best Regards Eric From:

Re: [edk2-devel] EDK II Stable Tag release edk2-stable201905 completed

On Wed, Jun 12, 2019 at 10:18:24AM +0200, Laszlo Ersek wrote: > > In this instance, we explicitly don't care about the submodule for > > that other project (and I really hope this is the norm) - so we > > shouldn't be documenting steps that rely on that additional > > submodule existing. > > Yes;

[edk2-devel] [edk2-platforms PATCH v1 1/1 -resend] Platform/ARM/JunoPkg: Add support for PPTT dynamic generation

Update the Platform Respository for the Juno platform to include support for generation of the Processor Properties Topology Table (PPTT) using the Dynamic Tables Framework. The Platform Repository now also describes the cache and processor topology in Juno (all revisions). Signed-off-by:

Re: [edk2-devel] [PATCH v2 0/6] Ovmf: Drop IntelFramework[Module]Pkg dependency

Ray, On 06/12/19 04:13, Wu, Hao A wrote: >> -Original Message- >> From: Ni, Ray >> Sent: Wednesday, June 12, 2019 10:04 AM >> To: Wu, Hao A; David Woodhouse; Justen, Jordan L; devel@edk2.groups.io >> Cc: Laszlo Ersek; Ard Biesheuvel; Phillips, D Scott >> Subject: RE: [PATCH v2 0/6] Ovmf:

Re: [edk2-devel] EDK II Stable Tag release edk2-stable201905 completed

On 06/12/19 11:21, Leif Lindholm wrote: > On Wed, Jun 12, 2019 at 10:18:24AM +0200, Laszlo Ersek wrote: >>> In this instance, we explicitly don't care about the submodule for >>> that other project (and I really hope this is the norm) - so we >>> shouldn't be documenting steps that rely on that

[edk2-devel] [PATCH] ShellPkg/UefiShellLib: Set input pointer parameter to null if failure

From: Bret Barkelew REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1906 While failed to allocate memory to save the response, set the input/output parameter 'Response'(VOID **) to NULL to indicate the failure not only depend on the returned status. Cc: Jaben Carsey Cc: Ray Ni Cc: Liming

Re: [edk2-devel] ExtScsiPassThru support for Logical SCSI devices

Hello Ravi Kumar, Inline comments below: From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Ravi Kumar Siadri Sent: Wednesday, June 12, 2019 12:01 PM To: devel@edk2.groups.io Subject: Re: [edk2-devel] ExtScsiPassThru support for Logical SCSI devices Hi, Can someone help me

Re: [edk2-devel] [PATCH 0/2] EdkRepo - The Multi-Repository Tool for EDK II

Hi Nate, On 06/12/19 02:04, Nate DeSimone wrote: > This patch series is raised to add the EdkRepo and EdkRepo-Manifest branches > to the Edk2-Staging repository. These branches are added to host EdkRepo, > the multi-repository tool for EDK II firmware development to TianoCore. > > For more

Re: [edk2-devel][Patch v2 2/7] MdeModulePkg: Add Capsule On Disk related definition.

Hi Hao, Thanks a lot for the comments. It comes from the feedback of SDL review. The PcdCapsuleOnDiskSupport only has type of '[PcdsFixedAtBuild, PcdsPatchableInModule]', so that Capsule On Disk feature can be configured by platform during build time, to ensure the feature will be permanently

Re: [edk2-devel] [PATCH v2 1/1] ShellPkg: acpiview: ACPI 6.3 update for MADT parser

Hi Zhichao, Please find my comments inline below. They are marked with [Krzysztof] Kind regards, Krzysztof -Original Message- From: Gao, Zhichao Sent: Monday, June 10, 2019 2:08 To: Krzysztof Koch ; devel@edk2.groups.io Cc: Sami Mujawar ; Carsey, Jaben ; Ni, Ray ; Matteo Carlini ;

[edk2-devel] [BIKESHEDDING-TARGET] BaseTools: add GetMaintainer.py helper script

This is work-in-progress, but I figured it would be a good time to start having a conversation about how we want it to work. The script currently does nothing clever whatsoever with regards to looking at historical contributors to the modified code - it only performs a lookup in Maintainers.txt.

Re: [edk2-devel] [PATCH v2 0/6] Ovmf: Drop IntelFramework[Module]Pkg dependency

> -Original Message- > From: devel@edk2.groups.io On Behalf Of Laszlo > Ersek > Sent: Wednesday, June 12, 2019 3:58 PM > To: Wu, Hao A ; Ni, Ray ; David > Woodhouse ; Justen, Jordan L > ; devel@edk2.groups.io > Cc: Ard Biesheuvel ; Phillips, D Scott > > Subject: Re: [edk2-devel] [PATCH

Re: [edk2-devel] [PATCH v2 0/6] Ovmf: Drop IntelFramework[Module]Pkg dependency

On 06/12/19 10:03, David Woodhouse wrote: > On Wed, 2019-06-12 at 09:58 +0200, Laszlo Ersek wrote: >> Ray, >> >> On 06/12/19 04:13, Wu, Hao A wrote: -Original Message- From: Ni, Ray Sent: Wednesday, June 12, 2019 10:04 AM To: Wu, Hao A; David Woodhouse; Justen, Jordan

[edk2-devel] [PATCH v1 1/2] MdePkg: Add Generic Initiator Affinity Structure definitions to SRAT

Add Generic Initiator Affinity Structure to the list of recognised System Resource Affinity Table (SRAT) structure types. Add definitions for Device Handle Types inside the Generic Initiator Affinity Structure. References: - ACPI 6.3 January 2019, Table 5-78 Signed-off-by: Krzysztof Koch ---

[edk2-devel] [PATCH v1 0/2] Update the SRAT Acpiview parser to ACPI 6.3

This patch adds a number of definitions to the ACPI 6.3 header file for the purpose of parsing Revision 3 of the System Resource Affinity Table (SRAT) in the Acpiview UEFI shell tool. By defining the Generic Initiator Affinity Structure's Type ID and the allowed Device Handle Types for the

Re: [edk2-devel] [PATCH 0/2] EdkRepo - The Multi-Repository Tool for EDK II

Hi Laszlo, I wasn't 100% sure on what to do with it myself. I took the existing Maintainers.txt and did the minimal modification necessary to describe EdkRepo. I'm completely flexible with whatever Maintainers.txt format the stewards prefer. If a change is needed let me know and I'll submit a

Re: [edk2-devel] [patch] ShellPkg/Debug1CommandsLib: Fix bugs in func DisplaySysEventLogData

Pushed. > -Original Message- > From: Bi, Dandan > Sent: Monday, June 10, 2019 5:52 PM > To: devel@edk2.groups.io; oleks...@ami.com; Ni, Ray ; > Carsey, Jaben > Cc: Gao, Zhichao > Subject: RE: [patch] ShellPkg/Debug1CommandsLib: Fix bugs in func > DisplaySysEventLogData > Importance:

[edk2-devel] [PATCH v1 0/2] Update the SRAT Acpiview parser to ACPI 6.3

This patch adds a number of definitions to the ACPI 6.3 header file for the purpose of parsing Revision 3 of the System Resource Affinity Table (SRAT) in the Acpiview UEFI shell tool. By defining the Generic Initiator Affinity Structure's Type ID and the allowed Device Handle Types for the

[edk2-devel] [PATCH v1 2/2] ShellPkg: acpiview: Update SRAT parser to ACPI 6.3

Add support for parsing revision 3 of System Resource Affinity Table (SRAT). Decode and dump the new Generic Initiator Affinity Structure. Validate the Device Handle Type field inside the Generic Initiator Affinity Structure. Signed-off-by: Krzysztof Koch --- Changes can be seen at:

Re: [edk2-devel] UEFI SCT Build Broken

Hi Eric, That's right. I meant the latest tag in my email. Thanks for updating this in the bug I filed as well. Thanks Ashish From: Jin, Eric Sent: Wednesday, June 12, 2019 3:18 AM To: Ashish Singhal; Supreeth Venkatesh; devel@edk2.groups.io Cc: Jin, Eric

Re: [edk2-devel] EDK II Stable Tag release edk2-stable201905 completed

Hi Liming, On Wed, Jun 12, 2019 at 01:30:23PM +, Gao, Liming wrote: > > > What I am saying is: > > > - We should have a policy (i.e., a section in toplevel Readme.md) > > > regarding submodules. > > > - That policy *should* include the requirement to not permit > > > submodules

Re: [edk2-devel] [PATCH] CryptoPkg: Add lacking instances for build only

With the wording/spelling addressed (see Laszlo's comment, https://edk2.groups.io/g/devel/message/42273), Reviewed-by: Jian J Wang > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Gao, > Zhichao > Sent: Wednesday, June 12, 2019 10:40 AM > To:

Re: [edk2-devel] [PATCH v2 0/6] Ovmf: Drop IntelFramework[Module]Pkg dependency

On 06/12/19 17:15, David Woodhouse wrote: > On Wed, 2019-06-12 at 13:52 +0200, Laszlo Ersek wrote: >> (2c) SeaBIOS is built *twice*, once for the CSM, and another time for >> the Cirrus VGABIOS. > > We shouldn't need to rebuild the VGA BIOS, should we? Any Legacy VGA > BIOS should work — and

[edk2-devel] [PATCH v1 2/2] ShellPkg: acpiview: Update SRAT parser to ACPI 6.3

Add support for parsing revision 3 of System Resource Affinity Table (SRAT). Decode and dump the new Generic Initiator Affinity Structure. Validate the Device Handle Type field inside the Generic Initiator Affinity Structure. Signed-off-by: Krzysztof Koch --- Changes can be seen at:

[edk2-devel] [PATCH v1 0/2] Update the SRAT Acpiview parser to ACPI 6.3

This patch adds a number of definitions to the ACPI 6.3 header file for the purpose of parsing Revision 3 of the System Resource Affinity Table (SRAT) in the Acpiview UEFI shell tool. By defining the Generic Initiator Affinity Structure's Type ID and the allowed Device Handle Types for the

Re: [edk2-devel] [BIKESHEDDING-TARGET] BaseTools: add GetMaintainer.py helper script

On 06/12/19 13:19, Leif Lindholm wrote: > This is work-in-progress, but I figured it would be a good time to start > having a conversation about how we want it to work. > > The script currently does nothing clever whatsoever with regards to > looking at historical contributors to the modified

Re: [edk2-devel] [PATCH v2 0/6] Ovmf: Drop IntelFramework[Module]Pkg dependency

On Wed, 2019-06-12 at 09:58 +0200, Laszlo Ersek wrote: > Ray, > > On 06/12/19 04:13, Wu, Hao A wrote: > > > -Original Message- > > > From: Ni, Ray > > > Sent: Wednesday, June 12, 2019 10:04 AM > > > To: Wu, Hao A; David Woodhouse; Justen, Jordan L; devel@edk2.groups.io > > > Cc: Laszlo

Re: [edk2-devel] [RFC][edk2-platform][Add new packages in Platform\Intel directory]

Isaac and Eric: Here is the proposal for new packages in Platform\Intel directory. BoardModulePkg: This package includes the libraries shared between the different board packages. Those libraries are linked by the drivers in the board packages. DebugFeaturePkg: This package provides the debug

Re: [edk2-devel] [edk2-platform patch 0/2] Import IntelSiliconPkg from edk2 repo master

Thanks! Push @f87b5c8a6b4b8401a490f4f100f412425b295e5a..bb556a89c69bd6f8a6ee0aa9d43550a47fc808cb > -Original Message- > From: Chaganty, Rangasai V > Sent: Tuesday, June 11, 2019 4:47 PM > To: Gao, Liming ; devel@edk2.groups.io > Cc: Kinney, Michael D ; Ni, Ray > Subject: RE:

Re: [edk2-devel] [PATCH v2 0/6] Ovmf: Drop IntelFramework[Module]Pkg dependency

On Wed, 2019-06-12 at 13:52 +0200, Laszlo Ersek wrote: > > I don't think it's on Hao to determine an (edk2 base commit, SeaBIOS > base commit) pair from the past at which the CSM functionality worked > "flawlessly". Absolutely! I was only suggesting that Hao should make sure it doesn't get

Re: [edk2-devel] EDK II Stable Tag release edk2-stable201905 completed

Leif: > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Laszlo > Ersek > Sent: Wednesday, June 12, 2019 5:38 PM > To: Leif Lindholm > Cc: devel@edk2.groups.io; Gao, Liming ; Kinney, Michael > D ; af...@apple.com > Subject: Re: [edk2-devel] EDK

Re: [edk2-devel] [PATCH] BaseTools: Cannot store library cache of different arch together

Hi Steven, This looks good, thank you. Thanks, Christian From: Shi, Steven Sent: Tuesday, June 11, 2019 8:30 PM To: Rodriguez, Christian ; devel@edk2.groups.io Cc: Gao, Liming ; Feng, Bob C Subject: RE: [PATCH] BaseTools: Cannot store library cache of different arch together Sorry, the

Re: [edk2-devel] [PATCH v2 0/6] Ovmf: Drop IntelFramework[Module]Pkg dependency

On Wed, 2019-06-12 at 13:52 +0200, Laszlo Ersek wrote: > (2c) SeaBIOS is built *twice*, once for the CSM, and another time for > the Cirrus VGABIOS. We shouldn't need to rebuild the VGA BIOS, should we? Any Legacy VGA BIOS should work — and indeed UEFI should be able to use the Legacy VGA BIOS

Re: [edk2-devel] [BIKESHEDDING-TARGET] BaseTools: add GetMaintainer.py helper script

On Wed, Jun 12, 2019 at 03:27:15PM +0200, Laszlo Ersek wrote: > On 06/12/19 13:19, Leif Lindholm wrote: > > This is work-in-progress, but I figured it would be a good time to start > > having a conversation about how we want it to work. > > > > The script currently does nothing clever whatsoever

Re: [edk2-devel] [edk2-test] [tianocore/edk2-test] Add Firmware Management Protocol and HII Config Access Protocol into IHVSCT. (#3)

Hello Shrishail, Pull requests is no longer the way to get your change request into the new edk2-test repo. Please send in “git format-patch” style patches to the devel@edk2.groups.io with the subject line containing [edk2-test]. Thanks, Supreeth From:

[edk2-devel] [edk2-test][PATCH v1 5/5] EasLib: Remove files required for building Ipf

Remove all files required for building Ipf Eas library as edk2 (edk2-stable201905) has removed IPF support. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Supreeth Venkatesh --- .../Framework/ENTS/EasLib/Ipf/EntsLibPlat.h | 55 --

[edk2-devel] [edk2-test][PATCH v1 3/5] Framework/EntsLib: Remove Ipf source files from inf file

Remove source and header files required for building Ipf library from inf file as edk2 (edk2-stable201905) has removed IPF support. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Supreeth Venkatesh --- .../SCT/Framework/ENTS/EasLib/EntsLib.inf | 7

[edk2-devel] [edk2-test][PATCH v1 1/5] Library/EntsLib: Remove references to SalSystemTable

Remove references to SalSystemTable and gtEfiSalSystemTableGuid as edk2 (edk2-stable201905) has removed IPF support. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Supreeth Venkatesh --- uefi-sct/SctPkg/Include/Library/EntsLib.h | 3 +-- 1 file changed, 1 insertion(+), 2

[edk2-devel] [edk2-test][PATCH v1 4/5] SctLib: Remove Ipf source files

Remove all files required for building Ipf Sct library as edk2 (edk2-stable201905) has removed IPF support. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Supreeth Venkatesh --- uefi-sct/SctPkg/Library/SctLib/Ipf/PalApi.h | 138

[edk2-devel] [edk2-test][PATCH v1 2/5] Framework/ENTS: Remove reference to gtEfiSalSystemTableGuid

Remove references to gtEfiSalSystemTableGuid as edk2 (edk2-stable201905) has removed IPF support. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Supreeth Venkatesh --- .../TestInfrastructure/SCT/Framework/ENTS/EasLib/EntsLib.c | 2 +- 1 file changed, 1 insertion(+),

Re: [edk2-devel] [PATCH v1 2/2] ShellPkg: acpiview: Update SRAT parser to ACPI 6.3

Reviewed-by: Jaben Carsey I don't have access to a platform with ACPI 6.3 to do a test. Can someone do a test and respond with tested-by if possible? > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Krzysztof Koch > Sent: Wednesday, June

Re: [edk2-devel] [PATCH v2 1/1] ShellPkg: acpiview: ACPI 6.3 update for MADT parser

Reviewed-by: Sami Mujawar -Original Message- From: Krzysztof Koch Sent: 12 June 2019 11:44 AM To: Gao, Zhichao ; devel@edk2.groups.io Cc: Sami Mujawar ; Carsey, Jaben ; Ni, Ray ; nd Subject: RE: [PATCH v2 1/1] ShellPkg: acpiview: ACPI 6.3 update for MADT parser Hi Zhichao, Please

Re: [edk2-devel] [PATCH v2 00/10] Duplicate required CSM components for OVMF

On Mon, 2019-05-27 at 11:03 +0800, Hao A Wu wrote: > ''' > Please note that this series will be hold until the edk2-stable201905 is > created. > ''' > > The series is also available at: > https://github.com/hwu25/edk2/tree/ovmf_csm_v2 > > V2 changes: > > Discussion with David Woodhouse for him

[edk2-devel] [PATCH 11/10] OvmfPkg/Csm/LegacyBiosDxe: Correct Legacy16GetTableAddress call for E820 data

The DX register is supposed to contain the required alignment for the allocation. It was zero, and SeaBIOS doesn't (well, didn't) cope well with that. Set it appropriately, and set BX to indicate the regions it's OK to allocate in too. That was already OK but let's make sure it's initialised

Re: [edk2-devel] [PATCH v1 1/2] MdePkg: Add Generic Initiator Affinity Structure definitions to SRAT

Reviewed-by: Sami Mujawar -Original Message- From: Krzysztof Koch Sent: 12 June 2019 03:11 PM To: devel@edk2.groups.io Cc: jaben.car...@intel.com; ray...@intel.com; zhichao@intel.com; michael.d.kin...@intel.com; liming@intel.com; Sami Mujawar ; Matteo Carlini ; Stephanie

Re: [edk2-devel] [PATCH v1 2/2] ShellPkg: acpiview: Update SRAT parser to ACPI 6.3

Reviewed-by: Sami Mujawar -Original Message- From: Krzysztof Koch Sent: 12 June 2019 03:11 PM To: devel@edk2.groups.io Cc: jaben.car...@intel.com; ray...@intel.com; zhichao@intel.com; michael.d.kin...@intel.com; liming@intel.com; Sami Mujawar ; Matteo Carlini ; Stephanie

Re: [edk2-devel] [PATCH] CryptoPkg: Add lacking instances for build only

I would fix the typo and replace the word 'lacking' with 'missing' in both BZ and the subject. Thanks, Zhichao > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Laszlo Ersek > Sent: Wednesday, June 12, 2019 4:38 PM > To: devel@edk2.groups.io;

Re: [edk2-devel] [PATCH] MdeModulePkg/PeiMain: Substantial change for PeiAllocatePool

Thanks for the comments. Your example makes the purpose clear. I would update the subject like that. Thanks, Zhichao > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Laszlo Ersek > Sent: Wednesday, June 12, 2019 4:34 PM > To:

[edk2-devel] [PATCH v4 0/2] Add SCSI Support for Storage Security Command Protocol

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1546 V4 changes: Add SSC Protocol in addition to BlockIo instead of in place of BlockIo. Add error handling for (BlockSize == 0) in Read and WriteBlocks commands to handle partitions that do not support ReadCapacity(). V3 changes: Initialize

[edk2-devel] [PATCH v4 2/2] MdeModulePkg/ScsiDiskDxe: Support Storage Security Command Protocol

This patch implements the EFI_STORAGE_SECURITY_COMMAND_PROTOCOL in the ScsiDiskDxe driver. Support is currently limited to the RPMB Well-known LUN for UFS devices. Cc: Michael D Kinney Cc: Jiewen Yao Cc: Jian J Wang Cc: Liming Gao Signed-off-by: Christopher J Zurcher ---

[edk2-devel] [PATCH v4 1/2] MdePkg: Implement SCSI commands for Security Protocol In/Out

This patch implements the Security Protocol In and Security Protocol Out commands in UefiScsiLib to prepare support for the Storage Security Command Protocol. Cc: Jiewen Yao Cc: Jian J Wang Cc: Liming Gao Signed-off-by: Christopher J Zurcher --- MdePkg/Include/IndustryStandard/Scsi.h | 48

Re: [edk2-devel] [PATCH v2 1/1] ShellPkg: acpiview: ACPI 6.3 update for MADT parser

Thanks for the interpret. Seems I read the old version spec. Now it is clear for me. Reviewed-by: Zhichao Gao > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Krzysztof Koch > Sent: Wednesday, June 12, 2019 6:44 PM > To: Gao, Zhichao ;

Re: [edk2-devel] [PATCH v3 1/1] BaseTools/Capsule: Tool to Generate Windows Firmware Update Driver

Eric: Can you help post link for Windows Firmware Update Drivers? Thanks Liming >-Original Message- >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Eric >Jin >Sent: Tuesday, June 11, 2019 2:23 PM >To: devel@edk2.groups.io >Cc: Feng, Bob C ; Gao, Liming >; Kinney,

Re: [edk2-devel] [PATCH v2 0/6] Ovmf: Drop IntelFramework[Module]Pkg dependency

> -Original Message- > From: David Woodhouse [mailto:dw...@infradead.org] > Sent: Wednesday, June 12, 2019 8:08 PM > To: devel@edk2.groups.io; ler...@redhat.com; Wu, Hao A; Ni, Ray; Justen, > Jordan L > Cc: Ard Biesheuvel; Phillips, D Scott > Subject: Re: [edk2-devel] [PATCH v2 0/6] Ovmf: