On 9/4/19 4:27 AM, Jin, Eric wrote:
Hi Heinrich Schuchardt,
According to
https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-Format
The statement "Contributed-under:..." need be removed.
With that: Reviewed-by: Eric Jin
If no object, I will help to push with this change by
This patch adds the following in Platform/Intel/build.cfg:
BoardX58Ich10 = SimicsOpenBoardPkg/BoardX58Ich10/build_config.cfg
But the file SimicsOpenBoardPkg/BoardX58Ich10/build_config.cfg is not added
until patch 7/7. This patch seems more appropriate as the final patch of the
series.
>
Reviewed-by: Michael Kubacki
> -Original Message-
> From: Wei, David Y
> Sent: Friday, August 30, 2019 2:19 PM
> To: devel@edk2.groups.io
> Cc: Wu, Hao A ; Gao, Liming ;
> Sinha, Ankit ; Agyeman, Prince
> ; Kubacki, Michael A
> ; Desimone, Nathaniel L
> ; Kinney, Michael D
>
> Subject:
The following files still have "SkyLake" in the comment at the top of the file.
This needs to be changed.
* SktUefiBootInclude.fdf
* SktPostMemoryInclude.fdf
Given this is the first commit for Simics QSP, I think it would be helpful to
expand the QSP acronym (Quick Start Package) in the
Reviewed-by: Michael Kubacki
> -Original Message-
> From: Wei, David Y
> Sent: Friday, August 30, 2019 2:19 PM
> To: devel@edk2.groups.io
> Cc: Wu, Hao A ; Gao, Liming ;
> Sinha, Ankit ; Agyeman, Prince
> ; Kubacki, Michael A
> ; Desimone, Nathaniel L
> ; Kinney, Michael D
>
> Subject:
Reviewed-by: Michael Kubacki
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Chiu, Chasel
> Sent: Tuesday, September 3, 2019 2:12 AM
> To: Chen, Marc W ; devel@edk2.groups.io
> Cc: Kubacki, Michael A ; Desimone, Nathaniel L
> ; Gao, Liming
> Subject: Re: [edk2-devel]
Reviewed-by: Michael Kubacki
> -Original Message-
> From: Chen, Marc W
> Sent: Monday, September 2, 2019 8:36 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Kubacki, Michael A
> ; Chaganty, Rangasai V
> ; Desimone, Nathaniel L
>
> Subject: [edk2-platforms][PATCH V2 3/6]
Reviewed-by: Michael Kubacki
> -Original Message-
> From: Chen, Marc W
> Sent: Monday, September 2, 2019 8:36 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Kubacki, Michael A
> ; Chaganty, Rangasai V
> ; Desimone, Nathaniel L
>
> Subject: [edk2-platforms][PATCH V2 4/6]
push@adb59b633c12eae334540295092da94736bffa33
>-Original Message-
>From: Ni, Ray
>Sent: Wednesday, September 04, 2019 12:10 PM
>To: Gao, Zhichao ; devel@edk2.groups.io
>Cc: Oleksiy ; Gao, Liming
>Subject: RE: [PATCH v3 1/1] ShellPkg/Pci.c: Update supported link speed to
>PCI5.0
>
S3PciSegmentLib library class header file should be
Include/Library/S3PciSegmentLib.h instead of
Include/Library/PciSegmentLib.h.
https://bugzilla.tianocore.org/show_bug.cgi?id=2146
Cc: Michael D Kinney
Cc: Liming Gao
Signed-off-by: Shenglei Zhang
---
MdePkg/MdePkg.dec | 2 +-
1 file changed,
Library Class Header file is not specified correctly in
Package.dec files. So now update them.
https://bugzilla.tianocore.org/show_bug.cgi?id=2146
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Jiewen Yao
Cc: Jian Wang
Cc: Chao Zhang
Shenglei Zhang (2):
MdePkg/MdePkg.dec: Update PciSegmentLib.h
%s/supproted/supported/g
Signed-off-by: Heinrich Schuchardt
---
.../Protocol/PciIo/BlackBoxTest/PciIoBBTestStress.c | 2 +-
.../BlackBoxTest/SimpleNetworkBBTestConformance.c| 12 ++--
.../BlackBoxTest/SimpleNetworkBBTestFunction.c | 12 ++--
Hi Bob,
On Wed, Sep 04, 2019 at 02:10:23AM +, Feng, Bob C wrote:
> Hi Leif,
>
> I have no Debian environment. On Debian, can python3 work with
> antlr3?
Yes. The below is equivalent to what I have already done.
Can you please respond to the question I asked about the API version
error I
RISC-V package library definitions.
RiscV.h
-Add RiscV.h which conform with RISC-V Privilege Spec v1.10.
sbi.h
sbi_bits.h
sbi_types.h
- Add definitions for RISC-V OpenSBI EDK2 port.
RealTimeClockLib.h
- Header file of platform level Real Time Clock library.
SbiFirmwareContext.h
- Header file
Add opensbi-HOWTO.txt for users to build RISC-V platform with RISC-V OpenSBI
library.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Abner Chang
---
RiscVPkg/opensbi/opensbi-HOWTO.txt | 17 +
1 file changed, 17 insertions(+)
create mode 100644
Add RISC-V processor binding and RISC-V processor specific definitions and
macros.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Abner Chang
---
MdePkg/Library/BaseLib/BaseLib.inf | 18 +-
MdePkg/Library/BaseLib/RiscV64/CpuBreakpoint.c | 33 ++
RiscVCpuLib: Add RISC-V CPU Library.
- This library provides CSR assembly functions to read/write RISC-V specific
Control and Status registers.
RiscVDxeIplHandoffLib
RiscVDxeIplHandoffOpenSbiLib
- Provide DxeIpl platform implementation-specifc library for RISC-V platform.
Two libraries are
The driver produces RISC-V EFI_CPU_ARCH_PROTOCOL and use RISC-V platform level
timer library
Due to RISC-V timer CSR is platform implementation specific, RISC-V CPU DXE
driver invokes platform level timer library
to access to timer CSRs.
Contributed-under: TianoCore Contribution Agreement 1.0
Support RISC-V image relocation.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Abner Chang
---
MdePkg/Library/BasePeCoffLib/BasePeCoff.c | 3 +-
MdePkg/Library/BasePeCoffLib/BasePeCoffLib.inf | 5 +
MdePkg/Library/BasePeCoffLib/BasePeCoffLib.uni |
This branch "RISC-V-V2" is used to contribute RISC-V architecture on EDK2.
Compare to the old branch "RISC-V", this branch "RISC-V-V2" is created based on
the most recent edk2/master @37eef910. This is easier for reviewers to have
clear ideas of edk2 code changes for RISC-V EDK2 implementation.
Support RISC-V cache related functions.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Abner Chang
---
.../BaseSynchronizationLib.inf | 6 +
.../RiscV64/Synchronization.c | 189 +
Implement RISC-V cache maintenance functions in BaseCacheMaintenanceLib.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Abner Chang
---
.../BaseCacheMaintenanceLib.inf| 4 +
.../Library/BaseCacheMaintenanceLib/RiscVCache.c | 242
Add RISC-V processor related definitions.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Abner Chang
---
MdePkg/Include/IndustryStandard/PeImage.h | 14 +-
MdePkg/Include/Library/BaseLib.h | 67 ++
MdePkg/Include/Protocol/DebugSupport.h| 55 +
Add RISCV64 Arch.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Abner Chang
---
MdeModulePkg/Logo/Logo.inf | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MdeModulePkg/Logo/Logo.inf b/MdeModulePkg/Logo/Logo.inf
index 0182025..243748c 100644
---
Since commit 35e242b698cd ("MdePkg/BaseLib: rewrite Base64Decode()",
2019-07-16), Base64Decode() guarantees that DestinationSize is larger on
output than it was on input if RETURN_BUFFER_TOO_SMALL is returned. Clean
up the retval handling for the first Base64Decode() call in
EnrollDefaultKeys,
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2153
Current logic will skip searching EFI_PEI_CORE_FV_LOCATION_PPI when the
PPI in PpiList having EFI_PEI_PPI_DESCRIPTOR_TERMINATE_LIST flag,
but platform may pass single PPI in PpiList that should be supported.
Changed the logic to verify
RISC-V generic SMBIOS DXE driver for building up SMBIOS type 4, type 7 and type
44 records.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Abner Chang
---
RiscVPkg/Universal/SmbiosDxe/RiscVSmbiosDxe.c | 343 +
Add RISC-V sections in MdePkg.dec.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Abner Chang
---
MdePkg/MdePkg.dec | 9 +
1 file changed, 9 insertions(+)
diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec
index 3fd7d16..9673c3c 100644
--- a/MdePkg/MdePkg.dec
Update SmBios header file to conform with SMBIOS v3.3.0.
The major update is to add definitions of SMBIOS Type 44h record.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Abner Chang
---
MdePkg/Include/IndustryStandard/SmBios.h | 74 +++-
1
- Add RiscVPkg package which provides RISC-V processor related drivers and
libraries.
- Support RISC-V OpenSBI and RISC-V platforms
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Abner Chang
---
RiscVPkg/RiscVPkg.dec | 57
BaseTools changes for building EDK2 RISC-V platform.
The changes made to build_rule.template is to avoid build errors cause by
GCC711RISCV tool chain.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Abner Chang
---
BaseTools/Conf/build_rule.template |
RISC-V MMIO library instance. RISC-V only supports memory map I/O. However the
first implementation
of RISC-V EDK2 port uses PC/AT as the RISC-V platform spec. We have to keep the
I/O functions as the temporary solution.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by:
Add RISCV64 Arch.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Abner Chang
---
NetworkPkg/Network.dsc.inc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/NetworkPkg/Network.dsc.inc b/NetworkPkg/Network.dsc.inc
index c7f4328..b484f9b 100644
---
This is the abstract driver which incorporate with platform level RTC library
(RealTimeClockLib) to provide Real Time Clock Architecture Protocol.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Abner Chang
---
.../RealTimeClockRuntimeDxe/RealTimeClock.c| 157
Implement RISC-V CPU related functions in BaseCpuLib.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Abner Chang
---
MdePkg/Library/BaseCpuLib/BaseCpuLib.inf | 4
MdePkg/Library/BaseCpuLib/RiscV/Cpu.s| 25 +
2 files changed, 29
- Implement RISC-V DxeIpl.
- Provide DxeIpl platform implementation-specifc library for RISC-V platform.
Two libraries are provided in this commit,
* Defualt library which simply switch stack and transfer
control to DXE core.
* Switch stack, privilege mode and then transfer control to
Add RISC-V in INF for building CapsuleRuntimeDxe RISC-V image.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Abner Chang
---
MdeModulePkg/Universal/CapsuleRuntimeDxe/CapsuleRuntimeDxe.inf | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git
Add RISC-V specific LD scripts. ."rela(INFO)" in the latest GccBase.lds causes
PE32 relocation error. This is the temporaty solution untill we find the root
casue.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Abner Chang
---
BaseTools/Scripts/GccBaseRiscV.lds | 71
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2147
This patch is to sort the Pcd settings so that PcdTokenNumber
will not change if the platform's Pcd settings are the same.
Signed-off-by: Bob Feng
Cc: Liming Gao
Cc: Steven Shi
---
BaseTools/Source/Python/AutoGen/PlatformAutoGen.py|
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1992
For the LoadImage() boot service, with EFI_SECURITY_VIOLATION retval,
the Image was loaded and an ImageHandle was created with a valid
EFI_LOADED_IMAGE_PROTOCOL, but the image can not be started right now.
This follows UEFI Spec.
But if
For the LoadImage() boot service, with EFI_SECURITY_VIOLATION retval,
the Image was loaded and an ImageHandle was created with a valid
EFI_LOADED_IMAGE_PROTOCOL, but the image can not be started right now.
This follows UEFI Spec.
But if the caller of LoadImage() doesn't have the option to defer
For the LoadImage() boot service, with EFI_SECURITY_VIOLATION retval,
the Image was loaded and an ImageHandle was created with a valid
EFI_LOADED_IMAGE_PROTOCOL, but the image can not be started right now.
This follows UEFI Spec.
But if the caller of LoadImage() doesn't have the option to defer
On Tue, 3 Sep 2019 19:20:25 +0200
Laszlo Ersek wrote:
> On 09/03/19 16:53, Igor Mammedov wrote:
> > On Mon, 2 Sep 2019 21:09:58 +0200
> > Laszlo Ersek wrote:
> >
> >> On 09/02/19 10:45, Igor Mammedov wrote:
> >>> On Fri, 30 Aug 2019 20:46:14 +0200
> >>> Laszlo Ersek wrote:
> >>>
>
Hi Bob,
On Wed, Sep 04, 2019 at 09:12:30AM +, Feng, Bob C wrote:
> The CLexer.py and CParser.py under CParser3 were generated with
> antlr3.0.1
> (https://github.com/tianocore/tianocore.github.io/wiki/ECC-tool) . I
> think API version error may be due to antlr-python-runtime on
> Debian has
Hi Jonathan, I created a new branch "RISC-V-V2" on edk2-staging which is based
on most recent EDK2 master and sent the patches based on it.
This is easier for reviewers to review the changes for RISC-V EDK2 port. The
original "RISC-V" branch has some stale implementation and may confuse people.
Does ThunderBolt need to be enabled by default? I want to be sure we're not
including it in stages (generally considered advanced) where there's not a use
case and setting it to FALSE works as expected.
> -Original Message-
> From: Sinha, Ankit
> Sent: Friday, August 30, 2019 3:41 PM
>
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1778
We are going to add keyword (lower case) 'static' for functions and global
variables which are not referenced outside their current C file.
However, the ECC tool only recognizes upper case 'STATIC' at this moment.
This will lead to issue
Tcg2PpVendorLib library class header should be
Include/Library/Tcg2PpVendorLib.h instead of
Include/Library/TcgPpVendorLib.h.
https://bugzilla.tianocore.org/show_bug.cgi?id=2146
Cc: Jiewen Yao
Cc: Jian Wang
Cc: Chao Zhang
Signed-off-by: Shenglei Zhang
---
SecurityPkg/SecurityPkg.dec | 2 +-
If EFI_SIMPLE_NETWORK.Statistics() is not supported, it will return
EFI_UNSUPPORTED. In this case do not expect input parameters to be checked
for conformance.
Signed-off-by: Heinrich Schuchardt
---
.../SimpleNetworkBBTestConformance.c | 112 +++---
1 file changed, 72
This patch is not applying cleanly for me. Can you please check it against the
current master branch?
error: patch failed:
Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c:1329
error: Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c: patch does
not apply
error: patch
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1992
For the LoadImage() boot service, with EFI_SECURITY_VIOLATION retval,
the Image was loaded and an ImageHandle was created with a valid
EFI_LOADED_IMAGE_PROTOCOL, but the image can not be started right now.
This follows UEFI Spec.
But if
Hi Leif,
The CLexer.py and CParser.py under CParser3 were generated with antlr3.0.1
(https://github.com/tianocore/tianocore.github.io/wiki/ECC-tool) . I think API
version error may be due to antlr-python-runtime on Debian has different
version. What's the antlr-python-runtime on Debian?
For the LoadImage() boot service, with EFI_SECURITY_VIOLATION retval,
the Image was loaded and an ImageHandle was created with a valid
EFI_LOADED_IMAGE_PROTOCOL, but the image can not be started right now.
This follows UEFI Spec.
But if the caller of LoadImage() doesn't have the option to defer
On Wed, 4 Sep 2019 at 08:37, Leif Lindholm wrote:
>
> On Wed, Sep 04, 2019 at 05:01:58AM -0700, Ard Biesheuvel wrote:
> > On Wed, 4 Sep 2019 at 04:49, Leif Lindholm wrote:
> > >
> > > On Tue, Sep 03, 2019 at 09:17:33PM -0700, Ard Biesheuvel wrote:
> > > > We take great care to avoid GOT based
On Wed, 4 Sep 2019 at 01:26, Dandan Bi wrote:
>
> For the LoadImage() boot service, with EFI_SECURITY_VIOLATION retval,
> the Image was loaded and an ImageHandle was created with a valid
> EFI_LOADED_IMAGE_PROTOCOL, but the image can not be started right now.
> This follows UEFI Spec.
>
> But if
On Wed, 4 Sep 2019 11:18:40 +
Abner Chang wrote:
> Hi Jonathan, I created a new branch "RISC-V-V2" on edk2-staging which is
> based on most recent EDK2 master and sent the patches based on it.
> This is easier for reviewers to review the changes for RISC-V EDK2 port. The
> original
From: Agyeman
Fixed GPIO table missing curly brackets
Cc: Ankit Sinha
Cc: Nate DeSimone
Cc: Michael Kubacki
Cc: Chasel Chiu
CC: Dandan Bi
Signed-off-by: Agyeman
---
.../N1xxWU/Library/BoardInitLib/N1xxWUGpioTable.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
On Wed, Sep 04, 2019 at 09:34:34AM -0700, Ard Biesheuvel wrote:
> Incorporate the stack protector library into the AARCH64 build of
> the Shell binaries as a NULL library resolution, to avoid build
> errors when the compiler injects stack integrity checks.
>
> Signed-off-by: Ard Biesheuvel
Reviewed-by: Ray Ni
> -Original Message-
> From: Gao, Zhichao
> Sent: Monday, September 2, 2019 1:51 AM
> To: devel@edk2.groups.io; Gao, Zhichao
> Cc: Carsey, Jaben ; Ni, Ray ;
> Andrew Fish
> Subject: RE: [edk2-devel] [PATCH V2] ShellPkg/UefiHandleParsingLib: Fix
> incorrect
Hi Abner,
On Wed, Sep 04, 2019 at 06:42:56PM +0800, Abner Chang wrote:
> - Add RiscVPkg package which provides RISC-V processor related drivers and
> libraries.
> - Support RISC-V OpenSBI and RISC-V platforms
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Abner
On Wed, Sep 04, 2019 at 06:42:57PM +0800, Abner Chang wrote:
> RISC-V package library definitions.
>
> RiscV.h
> -Add RiscV.h which conform with RISC-V Privilege Spec v1.10.
>
> sbi.h
> sbi_bits.h
> sbi_types.h
> - Add definitions for RISC-V OpenSBI EDK2 port.
A web search suggests this refers
Incorporate the stack protector library into the AARCH64 build of
the Shell binaries as a NULL library resolution, to avoid build
errors when the compiler injects stack integrity checks.
Signed-off-by: Ard Biesheuvel
---
ShellPkg/ShellPkg.dsc | 5 +
1 file changed, 1 insertion(+), 4
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Chiu, Chasel
> Sent: Wednesday, September 4, 2019 1:56 AM
> To: devel@edk2.groups.io
> Cc: Dong, Eric ; Ni, Ray ; Laszlo
> Ersek
> Subject: [edk2-devel] [PATCH] UefiCpuPkg: support single
> EFI_PEI_CORE_FV_LOCATION_PPI in
Hi Hao,
I tried making both the NamespaceID and NSID values the same when calling
the passthru function for these admin commands and it didn't work. I think
that is due to another place in the passthru code filtering the NamespaceId
input values on line 517-520.
The NamespaceId parameter is being
From: Ni, Ray
Sent: Tuesday, September 3, 2019 6:56 PM
> 1. can we directly call AcquireSpinLock()? *OrFail() can be removed IMO.
> 2. It's a patch to change the behavior of SmmStartupThisAP(). So that to
> reduce the potential bugs in caller's code. Patch title is a bit mis-leading.
The way I
On Wed, Sep 04, 2019 at 06:42:58PM +0800, Abner Chang wrote:
> Add RISC-V sections in MdePkg.dec.
This can be included whenever the respective include directories are
created.
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Abner Chang
> ---
> MdePkg/MdePkg.dec | 9
On Tue, Sep 03, 2019 at 09:17:33PM -0700, Ard Biesheuvel wrote:
> We take great care to avoid GOT based relocations in EDK2 executables,
> primarily because they are pointless - we don't care about things like
> the CoW footprint or relocations that target read-only sections, and so
> GOT entries
Tom:
Thanks for your update function header with RFC 4646 Languages. Please remove
function name
CompareIso639LanguageCode() in function header. Because this API is UefiLib
internal function,
It is not defined in UefiLib.h. With this update, Reviewed-by: Liming Gao
Thanks
Liming
>
On Wed, 4 Sep 2019 at 05:01, Ard Biesheuvel wrote:
>
> On Wed, 4 Sep 2019 at 04:49, Leif Lindholm wrote:
> >
> > On Tue, Sep 03, 2019 at 09:17:33PM -0700, Ard Biesheuvel wrote:
> > > We take great care to avoid GOT based relocations in EDK2 executables,
> > > primarily because they are pointless
On Wed, Sep 04, 2019 at 05:01:58AM -0700, Ard Biesheuvel wrote:
> On Wed, 4 Sep 2019 at 04:49, Leif Lindholm wrote:
> >
> > On Tue, Sep 03, 2019 at 09:17:33PM -0700, Ard Biesheuvel wrote:
> > > We take great care to avoid GOT based relocations in EDK2 executables,
> > > primarily because they are
Reviewed-by: Chasel Chiu
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Agyeman,
> Prince
> Sent: Wednesday, September 4, 2019 2:18 AM
> To: devel@edk2.groups.io
> Cc: Agyeman, Prince ; Sinha, Ankit
> ; Desimone, Nathaniel L
> ; Kubacki, Michael A
> ; Chiu, Chasel ;
On Wed, 4 Sep 2019 at 00:52, Laszlo Ersek wrote:
>
> Since commit 35e242b698cd ("MdePkg/BaseLib: rewrite Base64Decode()",
> 2019-07-16), Base64Decode() guarantees that DestinationSize is larger on
> output than it was on input if RETURN_BUFFER_TOO_SMALL is returned. Clean
> up the retval handling
Ack-by: Liming Gao
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Ard
> Biesheuvel
> Sent: Wednesday, September 4, 2019 10:22 PM
> To: Leif Lindholm
> Cc: edk2-devel-groups-io ; Gao, Liming
>
> Subject: Re: [edk2-devel] [PATCH]
Reviewed-by: Chasel Chiu
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Ni, Ray
> Sent: Wednesday, September 4, 2019 2:18 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Zeng, Star
> Subject: [edk2-devel] [PATCH] IntelFsp2WrapperPkg:
This patch cleans up the population SMBIOS entries by removing elements
that we don't have data for, as well as properly filling the ones for
which we do, through the newly added queries from RpiFirmwareDxe.
String parsing code is also added to BIOSInfoUpdateSmbiosType0() so
that any numeric
This series of patches improves the data reported by the firmware for SMB
queries.
This is achieved by first introducing new calls in RpiFirmwareDxe and then
cleaning
up the existing PlatformSmbiosDxe code. These modifications should ensure that
the drivers can be reused on other Raspberry Pi
On 9/3/19 6:38 PM, Laszlo Ersek wrote:
> The LoadImage() boot service is a bit unusual in that it allocates
> resources in a particular failure case; namely, it produces a valid
> "ImageHandle" when it returns EFI_SECURITY_VIOLATION. This is supposed to
> happen e.g. when Secure Boot verification
Hi Chasel,
Thanks for your quick fix.
Reviewed-by: Eric Dong
Thanks,
Eric
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Chiu,
> Chasel
> Sent: Wednesday, September 4, 2019 4:56 PM
> To: devel@edk2.groups.io
> Cc: Dong, Eric ; Ni, Ray ;
On Wed, 4 Sep 2019 at 04:49, Leif Lindholm wrote:
>
> On Tue, Sep 03, 2019 at 09:17:33PM -0700, Ard Biesheuvel wrote:
> > We take great care to avoid GOT based relocations in EDK2 executables,
> > primarily because they are pointless - we don't care about things like
> > the CoW footprint or
Hi Shenglei,
Would you please elaborate a little on how casting to UINTN can resolve the
overflow scenario and why 64bits OS will affect this code?
Thanks!
Chasel
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Zhang,
> Shenglei
> Sent: Monday, September 2, 2019 8:35
This patch introduces the capability to also query the Model Name/
Manufacturer Name/CPU Name/Firmware Revision using the RpiFirmware
protocol. This is aims at making the driver more suitable to cater
for platforms other than the Raspberry Pi 3 as well as simplifying
the population of entries in
On Tue, 3 Sep 2019 at 22:36, wrote:
>
> From: "Tien Hock, Loh"
>
> Update all license to SPDX. Also update UART clock to be calculated instead
> of hardcoded, removed some unused packages, and updated maintainers.
>
Please split this into 4 patches
> Signed-off-by: "Tien Hock, Loh"
>
On Wed, Sep 04, 2019 at 06:42:59PM +0800, Abner Chang wrote:
> Add RISC-V processor related definitions.
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Abner Chang
> ---
> MdePkg/Include/IndustryStandard/PeImage.h | 14 +-
> MdePkg/Include/Library/BaseLib.h
On Wed, Sep 04, 2019 at 06:43:01PM +0800, Abner Chang wrote:
> Implement RISC-V cache maintenance functions in BaseCacheMaintenanceLib.
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Abner Chang
> ---
> .../BaseCacheMaintenanceLib.inf| 4 +
>
When using StdLib, I found that access and open have difficulty if the
mapping name is not the same case as the mapping name in the path. I have
traced this down to a line in DevSearch.c (line 68)
if(wcsncmp(DevName, WorkNode->DevName, wcslen(WorkNode->DevName))
== 0) {
It
1. Default APIC NMI structure in MADT changed to expose
Level-Triggered interrupts.
2. x2APIC NMI structure won't be exposed to OS if x2APIC is not enabled.
Cc: Michael Kubacki
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Liming Gao
Signed-off-by: Ankit Sinha
---
In some cases, the CLANG38 toolchain profile in LTO mode emits GOT
based relocations in spite of our attempts to avoid this, by using
hidden visibility, -Bsymbolic etc.
On AARCH64, we managed to work around this by processing the GOT
based relocations in GenFw. As it turns out, the same issue
On 2019-09-03 10:41, Ni, Ray wrote:
> Can we change the process a bit?
> 1. maintainers created pull requests on behave of the patch owners
> 2. patch owners can be notified automatically if pull requests fail
> 3. patch owners update the pull requests
> (I am not familiar to pull requests. I
Following up on my last e-mail, I guess I had the wrong assumption: there
doesn't appear to be a way to resolve mappings within StdLib.
Are there any plans here?
Thanks,
Tim
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online
Tim,
I don't know about the plans with the StdLib, but I do remember a long time ago
with the old shell there was a protocol that let you translate volume names
(mappings) into handles and device paths.
So you could write a simple library that has 2 styles of APIs:
1) Handle + FilePath in
> -Original Message-
> From: Ni, Ray
> Sent: Thursday, September 5, 2019 2:04 AM
> To: devel@edk2.groups.io; Chiu, Chasel
> Cc: Dong, Eric ; Laszlo Ersek
> Subject: RE: [edk2-devel] [PATCH] UefiCpuPkg: support single
> EFI_PEI_CORE_FV_LOCATION_PPI in PpiList
>
> > -Original
Initial version of RISC-V platform package which provides the common libraries,
drivers, PCD and etc. for RISC-V platform development.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Gilbert Chen
---
Platform/RiscV/Readme.md | 89
Add SiFive silicon EDK2 metafile and header files of SiFive RISC-V cores.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Gilbert Chen
---
Silicon/SiFive/Include/Library/SiFiveE51.h | 66 ++
Silicon/SiFive/Include/Library/SiFiveU54.h |
"devel-riscv-v2" is a new branch created for reviewing code changes of SiFive
U500 VC707 FPGA
platform EDK2 port. Compare to old "devel-riscv" branch, the patches sent to
"devel-riscv-v2"
branch are made based on the most recent edk2/master. The corresponding patches
of
edk2 code changes were
FirmwareContextProcessorSpecificLib.h
- The difinitions of Firmware Context EDK2 implementaion based on RISC-V
OpenSBI.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Gilbert Chen
---
.../Library/FirmwareContextProcessorSpecificLib.h | 47 ++
1 file
Initial version of SiFive RISC-V core libraries. Library of each core creates
processor core SMBIOS data hob for building SMBIOS records in DXE phase.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Gilbert Chen
---
.../E51/Library/PeiCoreInfoHobLib/CoreInfoHob.c|
Common RISC-V SEC module for RISC-V platforms.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Gilbert Chen
---
Platform/RiscV/Universal/Sec/Riscv64/SecEntry.s | 439
Platform/RiscV/Universal/Sec/SecMain.c | 529
The initial version of SiFive U500 platform package.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Gilbert Chen
---
Platform/RiscV/SiFive/U500Pkg/Readme.md| 30 ++
Platform/RiscV/SiFive/U500Pkg/U500.dec | 40 ++
Platform/RiscV/SiFive/U500Pkg/U500.dsc
FirmwareContextProcessorSpecificLib
- Common library to consume EFI_RISCV_FIRMWARE_CONTEXT_HART_SPECIFIC and build
up processor specific data HOB.
RealTimClockLibNull
- NULL instance of Real Time Clock library.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Gilbert Chen
Update Readme.md and Maintainers.txt for RISV-V platforms.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Gilbert Chen
---
Maintainers.txt | 9 +
Readme.md | 11 +++
2 files changed, 20 insertions(+)
diff --git a/Maintainers.txt b/Maintainers.txt
1 - 100 of 124 matches
Mail list logo
