Re: [edk2-devel] [Patch v2] SecurityPkg Tcg2Config: Move common definitions to new Tcg2Internal.h

2019-09-15 Thread Wang, Jian J
Reviewed-by: Jian J Wang > -Original Message- > From: Gao, Liming > Sent: Thursday, September 12, 2019 2:07 PM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Zhang, Chao B > > Subject: [Patch v2] SecurityPkg Tcg2Config: Move common definitions to new > Tcg2Internal.h > > Common

Re: [edk2-devel] [PATCH] AdvancedFeaturePkg/BmcElog: Initialize ClearSelResponse

2019-09-15 Thread Liming Gao
Reviewed-by: Liming Gao >-Original Message- >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >Zhang, Shenglei >Sent: Monday, September 02, 2019 8:05 PM >To: devel@edk2.groups.io >Cc: Kubacki, Michael A ; Chaganty, Rangasai V >; Gao, Liming >Subject: [edk2-devel]

Re: [edk2-devel] [PATCH] AdvancedFeaturePkg/BmcElog: Change arithmetic logic

2019-09-15 Thread Liming Gao
Reviewed-by: Liming Gao >-Original Message- >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >Zhang, Shenglei >Sent: Monday, September 02, 2019 8:05 PM >To: devel@edk2.groups.io >Cc: Kubacki, Michael A ; Chaganty, Rangasai V >; Gao, Liming >Subject: [edk2-devel]

Re: [edk2-devel] [PATCH 1/3] MdeModulePkg: Entend the support keyboard type of Terminal console

2019-09-15 Thread Gao, Zhichao
Hi Roy, Ard, Laszlo, Do you have any comment if I add the new terminal type to TtyTerm.h? As PcAnsi.h, the spec related types are put into one header file. Thanks, Zhichao > -Original Message- > From: Gao, Zhichao > Sent: Monday, September 16, 2019 8:33 AM > To: Wu, Hao A ;

Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v1 07/22]: MdePkg/BaseIoLibIntrinsic: RISC-V I/O intrinsic functions.

2019-09-15 Thread Abner Chang
> -Original Message- > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > Sent: Thursday, September 5, 2019 10:28 PM > To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist) > > Subject: Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v1 07/22]: >

[edk2-devel] [PATCH v2] MinPlatformPkg/TestPointCheckLib: Add return value when OutTable is NULL

2019-09-15 Thread Zhang, Shenglei
Currently there is no check for the parameter OutTable. So add the logic that return value EFI_INVALID_PARAMETER when the OutTable is NULL. Cc: Michael Kubacki Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Signed-off-by: Shenglei Zhang --- v2:Update the copyright and the if...else

Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v1 01/22]: RiscVPkg: RISC-V processor package.

2019-09-15 Thread Abner Chang
> -Original Message- > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > Sent: Thursday, September 5, 2019 1:51 AM > To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist) > > Subject: Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v1 01/22]: > RiscVPkg: RISC-V processor

Re: [edk2-devel] [PATCH 1/3] MdeModulePkg: Entend the support keyboard type of Terminal console

2019-09-15 Thread Gao, Zhichao
Hi Roy, Ard, Laszlo, Do you have any comment if I add the new terminal type to TtyTerm.h? As PcAnsi.h, the spec mentioned terminal types are put into one header file. Thanks, Zhichao > -Original Message- > From: Gao, Zhichao > Sent: Monday, September 16, 2019 8:33 AM > To: Wu, Hao A ;

Re: [edk2-devel] [PATCH] BaseTools/LzmaCompress: Add two switches

2019-09-15 Thread Liming Gao
Shenglei: I add my comments. Thanks Liming >-Original Message- >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >Zhang, Shenglei >Sent: Thursday, September 12, 2019 10:40 AM >To: devel@edk2.groups.io >Cc: Feng, Bob C ; Gao, Liming >Subject: [edk2-devel] [PATCH]

Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v1 02/22]: RiscVPkg/Include: Add header files of RISC-V CPU package

2019-09-15 Thread Abner Chang
> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Leif Lindholm > Sent: Thursday, September 5, 2019 2:56 AM > To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist) > > Subject: Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v1

Re: [edk2-devel] [PATCH] BaseTools:change some incorrect parameter defaults

2019-09-15 Thread Bob Feng
Reviewed-by: Bob Feng -Original Message- From: Fan, ZhijuX Sent: Thursday, September 12, 2019 4:18 PM To: devel@edk2.groups.io Cc: Gao, Liming ; Feng, Bob C Subject: [PATCH] BaseTools:change some incorrect parameter defaults BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1858 for

[edk2-devel] [PATCH] BaseTools: Add more parameter checking for CopyFileOnChange()

2019-09-15 Thread Steven Shi
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2193 The current CopyFileOnChange() method in Misc.py does not accept the input SrcFile parameter as a dir, but the method does not check the SrcFile is dir or not. This patch is to add more input parameter type checking and error message output

Re: [edk2-devel] [PATCH v2] MinPlatformPkg/TestPointCheckLib: Add return value when OutTable is NULL

2019-09-15 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Zhang, Shenglei > Sent: Monday, September 16, 2019 9:09 AM > To: devel@edk2.groups.io > Cc: Kubacki, Michael A ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Gao, Liming > Subject: [PATCH v2] MinPlatformPkg/TestPointCheckLib: Add

Re: [edk2-devel] [edk2-test] [PATCH 1/1] uefi-sct/SctPkg: fix typo DuplicateDevicePath

2019-09-15 Thread Eric Jin
Reviewed-by: Eric Jin -Original Message- From: devel@edk2.groups.io On Behalf Of Heinrich Schuchardt Sent: Friday, September 13, 2019 4:54 PM To: EDK II Development Cc: Jin, Eric ; Supreeth Venkatesh ; Stephano Cetola ; Heinrich Schuchardt Subject: [edk2-devel] [edk2-test] [PATCH

Re: [edk2-devel] [edk2-test] [PATCH 1/1] uefi-sct/SctPkg: UninstallMultipleProtocols, checkpoint 7-9

2019-09-15 Thread Eric Jin
Reviewed-by: Eric Jin -Original Message- From: devel@edk2.groups.io On Behalf Of Heinrich Schuchardt Sent: Friday, September 13, 2019 3:27 AM To: EDK II Development Cc: Jin, Eric ; Supreeth Venkatesh ; Stephano Cetola ; Heinrich Schuchardt Subject: [edk2-devel] [edk2-test] [PATCH