Re: [edk2-devel] [PATCH 25/35] OvmfPkg/VideoDxe: document EFI_EDID_OVERRIDE_PROTOCOL.GetEdid() call

2019-09-23 Thread Philippe Mathieu-Daudé
Hi Laszlo, On 9/17/19 9:49 PM, Laszlo Ersek wrote: > According to the UEFI spec -- and to the edk2 header > "MdePkg/Include/Protocol/EdidOverride.h" too --, > EFI_EDID_OVERRIDE_PROTOCOL_GET_EDID takes an (EFI_HANDLE*), and not an > EFI_HANDLE, as second parameter ("ChildHandle"). > > This is

Re: [edk2-devel] [PATCH 35/35] UefiPayloadPkg/BlSupportDxe: fix ReserveResourceInGcd() calls

2019-09-23 Thread Guo Dong
This is not dead code. This actual bug didn't cause issues since BlSupportDxe just allocate resources reported from bootloaders. Anyway, this is a great enhancement from spec to capture such bugs. Thanks, Guo > -Original Message- > From: Philippe Mathieu-Daudé

Re: [edk2-devel] [PATCH 22/35] OvmfPkg/XenBusDxe: fix UninstallMultipleProtocolInterfaces() call

2019-09-23 Thread Philippe Mathieu-Daudé
On 9/17/19 9:49 PM, Laszlo Ersek wrote: > Unlike the InstallMultipleProtocolInterfaces() boot service, which takes > an (EFI_HANDLE*) as first parameter, the > UninstallMultipleProtocolInterfaces() boot service takes an EFI_HANDLE as > first parameter. > > This is an actual bug. It must have

Re: [edk2-devel] [PATCH 21/35] NetworkPkg/TcpDxe: fix SockFreeFoo() parameter list

2019-09-23 Thread Philippe Mathieu-Daudé
On 9/17/19 9:49 PM, Laszlo Ersek wrote: > The SockFreeFoo() callback function for NetbufFromExt() has to match the > NET_VECTOR_EXT_FREE prototype, which takes a (VOID*) as callback argument > (Arg). EFI_EVENT has nothing to do with NET_VECTOR_EXT_FREE. Fix the > SockFreeFoo() parameter list. > >

Re: [edk2-devel] [PATCH 20/35] NetworkPkg/Ip4Dxe: fix NetLibDestroyServiceChild() call

2019-09-23 Thread Philippe Mathieu-Daudé
On 9/17/19 9:49 PM, Laszlo Ersek wrote: > Both NetLibDestroyServiceChild() and EFI_SERVICE_BINDING_DESTROY_CHILD > take an EFI_HANDLE for the "ChildHandle" parameter, not an (EFI_HANDLE*). > > This patch fixes a real bug. > > Cc: Jiaxin Wu > Cc: Siyuan Fu > Signed-off-by: Laszlo Ersek > --- >

Re: [edk2-devel] [PATCH 35/35] UefiPayloadPkg/BlSupportDxe: fix ReserveResourceInGcd() calls

2019-09-23 Thread Philippe Mathieu-Daudé
On 9/23/19 6:02 PM, Dong, Guo wrote: > > This is not dead code. > This actual bug didn't cause issues since BlSupportDxe just allocate > resources reported from bootloaders. Ah OK, thanks Guo. > Anyway, this is a great enhancement from spec to capture such bugs. > > Thanks, > Guo > >>

Re: [edk2-devel] [PATCH 00/35] edk2: clean up the usage of standardized (VOID*) typedefs

2019-09-23 Thread Marvin Häuser
Good day, Thank you, Laszlo, for your ambition to introduce stricter code style enforcements. Sorry to "hijack" the actual topic (I did not CC anyone on purpose, as this is mostly a separate topic and I'd like a quick comment first), but this seems like a good occasion to mention another few

Re: [edk2-devel] [PATCH 31/35] ShellPkg/UefiShellDebug1CommandsLib: fix ShellCloseFile() call

2019-09-23 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey Thanks -Jaben > -Original Message- > From: Philippe Mathieu-Daudé [mailto:phi...@redhat.com] > Sent: Monday, September 23, 2019 3:01 AM > To: devel@edk2.groups.io; ler...@redhat.com > Cc: Carsey, Jaben ; Ni, Ray ; > Gao, Zhichao > Subject: Re: [edk2-devel]

Re: [edk2-devel] [PATCH 35/35] UefiPayloadPkg/BlSupportDxe: fix ReserveResourceInGcd() calls

2019-09-23 Thread Philippe Mathieu-Daudé
On 9/17/19 9:49 PM, Laszlo Ersek wrote: > The last parameter of ReserveResourceInGcd() is "ImageHandle", forwarded > in turn to gDS->AllocateMemorySpace() or gDS->AllocateIoSpace() as "owner" > image handle. > > But BlDxeEntryPoint() passes "SystemTable" as "ImageHandle". > > Compilers have not

[edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH] PciBusDxe: New PCI features Max_Payload_Size, Max_Read_Req_Size

2019-09-23 Thread Javeed, Ashraf
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2194 The EDK2 Kernel PciBusDxe driver is enhanced to enable the configuration of PCI features like Max_Payload_Size and Max_Read_Req_Size. Max_Payload_Size:- The PCI Device Control register provides this feature register field which controls

Re: [edk2-devel] [Patch] BaseTools: init DependencyHeaderFileSet for each MakeFile class

2019-09-23 Thread Liming Gao
Reviewed-by: Liming Gao > -Original Message- > From: Feng, Bob C > Sent: Thursday, September 19, 2019 10:57 AM > To: devel@edk2.groups.io > Cc: Gao, Liming ; Shi, Steven ; > Feng, Bob C > Subject: [Patch] BaseTools: init DependencyHeaderFileSet for each MakeFile > class > > REF:

Re: [edk2-devel] [edk2-platforms][PATCH V1 1/1] ClevoOpenBoardPkg/N1xxWU: Enable Synaptics touchpad support in OS

2019-09-23 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: devel@edk2.groups.io On Behalf Of Kubacki, Michael A Sent: Thursday, September 19, 2019 7:16 PM To: devel@edk2.groups.io Cc: Sinha, Ankit ; Desimone, Nathaniel L Subject: [edk2-devel] [edk2-platforms][PATCH V1 1/1]

Re: [edk2-devel] [edk2-platforms][PATCH V1 05/12] KabylakeOpenBoardPkg: Move EcCommands.h to KabylakeRvp3 board

2019-09-23 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: devel@edk2.groups.io On Behalf Of Kubacki, > Michael A > Sent: Saturday, September 21, 2019 2:40 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Sinha, Ankit ; > Jeremy Soller > Subject: [edk2-devel]

Re: [edk2-devel] [edk2-platforms PATCH v2] SimicsOpenBoardPkg: Always set the boot priority by default

2019-09-23 Thread Nate DeSimone
With the minor style changes noted by Michael fixed... Reviewed-by: Nate DeSimone -Original Message- From: Wei, David Y Sent: Monday, September 16, 2019 3:39 PM To: devel@edk2.groups.io Cc: Wu, Hao A ; Gao, Liming ; Sinha, Ankit ; Agyeman, Prince ; Kubacki, Michael A ; Desimone,

Re: [edk2-devel] [edk2-platforms][PATCH V1 03/12] ClevoOpenBoardPkg: Remove global files and references

2019-09-23 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: devel@edk2.groups.io On Behalf Of Kubacki, Michael A Sent: Friday, September 20, 2019 11:40 AM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Sinha, Ankit ; Jeremy Soller Subject: [edk2-devel]

Re: [edk2-devel] [PATCH 7/7] UefiCpuPkg: strip trailing whitespace

2019-09-23 Thread Philippe Mathieu-Daudé
On 9/19/19 8:06 PM, Leif Lindholm wrote: > Cc: Eric Dong > Cc: Ray Ni > Cc: Laszlo Ersek > Signed-off-by: Leif Lindholm > --- > UefiCpuPkg/Application/Cpuid/Cpuid.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/UefiCpuPkg/Application/Cpuid/Cpuid.c >

Re: [edk2-devel] [PATCH V4 3/3] MdeModulePkg/BM_UI: Add the new terminal types to related menu

2019-09-23 Thread Dandan Bi
Reviewed-by: Dandan Bi Thanks, Dandan > -Original Message- > From: Gao, Zhichao > Sent: Monday, September 23, 2019 12:32 PM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Wu, Hao A ; > Ni, Ray ; Bi, Dandan ; Gao, Liming > > Subject: [PATCH V4 3/3] MdeModulePkg/BM_UI: Add the new

Re: [edk2-devel] [edk2-platforms][PATCH V1 12/12] Add GalagoPro3 board details to global build and documentation

2019-09-23 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: devel@edk2.groups.io On Behalf Of Kubacki, Michael A Sent: Friday, September 20, 2019 11:41 AM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Sinha, Ankit ; Jeremy Soller Subject: [edk2-devel]

Re: [edk2-devel] [edk2-platforms][PATCH V1 04/12] KabylakeOpenBoardPkg: Move policy update libs to KabylakeRvp3 board

2019-09-23 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: devel@edk2.groups.io On Behalf Of Kubacki, > Michael A > Sent: Saturday, September 21, 2019 2:40 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Sinha, Ankit ; > Jeremy Soller > Subject: [edk2-devel]

Re: [edk2-devel] [edk2-non-osi][PATCH V1 1/1] edk2-non-osi: Rename ClevoOpenBoardBinPkg to KabylakeOpenBoardBinPkg

2019-09-23 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: Kubacki, Michael A Sent: Friday, September 20, 2019 11:40 AM To: devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Sinha, Ankit ; Jeremy Soller Subject: [edk2-non-osi][PATCH V1 1/1] edk2-non-osi: Rename ClevoOpenBoardBinPkg to

Re: [edk2-devel] [edk2-platforms][PATCH V1 06/12] KabylakeOpenBoardPkg: Move flash map to board

2019-09-23 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Kubacki, Michael A > Sent: Saturday, September 21, 2019 2:40 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Sinha, Ankit ; > Jeremy Soller > Subject: [edk2-platforms][PATCH V1 06/12]

Re: [edk2-devel] [edk2-platforms][PATCH V1 01/12] Platform/Intel: Remove N1xxWU board build option

2019-09-23 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: devel@edk2.groups.io On Behalf Of Kubacki, > Michael A > Sent: Saturday, September 21, 2019 2:40 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Sinha, Ankit ; > Jeremy Soller > Subject: [edk2-devel]

Re: [edk2-devel] [PATCH 4/7] EmulatorPkg: strip trailing whitespace

2019-09-23 Thread Philippe Mathieu-Daudé
On 9/19/19 8:06 PM, Leif Lindholm wrote: > Cc: Jordan Justen > Cc: Andrew Fish > Cc: Ray Ni > Signed-off-by: Leif Lindholm > --- > EmulatorPkg/Readme.md | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/EmulatorPkg/Readme.md b/EmulatorPkg/Readme.md > index

Re: [edk2-devel] [PATCH 1/7] ArmPkg: strip trailing whitespace

2019-09-23 Thread Philippe Mathieu-Daudé
On 9/19/19 8:06 PM, Leif Lindholm wrote: > Cc: Ard Biesheuvel > Signed-off-by: Leif Lindholm > --- > ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf >

Re: [edk2-devel] [PATCH 30/35] ShellPkg: stop taking EFI_HANDLE in place of SHELL_FILE_HANDLE

2019-09-23 Thread Philippe Mathieu-Daudé
On 9/17/19 9:49 PM, Laszlo Ersek wrote: > The TouchFileByHandle() and IsDirectoryEmpty() functions are passed > SHELL_FILE_HANDLE parameters, and they use those parameters correctly. > However, their parameter lists say EFI_HANDLE. > > Spell out the right type in the parameter lists. > > In

Re: [edk2-devel] [edk2-test][Patch] uefi-sct/SctPkg: Fix invalid attribute combination

2019-09-23 Thread Eric Jin
Pushed at 93a98df2609763cc162191bd5395617a621747fe -Original Message- From: devel@edk2.groups.io On Behalf Of Eric Jin Sent: Friday, September 20, 2019 11:10 AM To: Liu, XianhuiX ; devel@edk2.groups.io Cc: Oleksiy ; Supreeth Venkatesh Subject: Re: [edk2-devel] [edk2-test][Patch]

Re: [edk2-devel] [edk2-platforms][PATCH V1 11/12] KabylakeOpenBoardPkg/GalagoPro3: Add build files

2019-09-23 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: devel@edk2.groups.io On Behalf Of Kubacki, > Michael A > Sent: Saturday, September 21, 2019 2:40 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Sinha, Ankit ; > Jeremy Soller > Subject: [edk2-devel]

[edk2-devel] [PATCH 1/1] MdeModulePkg/SdMmcPciHcDxe: Fix bus timing switch sequence

2019-09-23 Thread Albecki, Mateusz
SD specification recommends switching card bus timing before switching bus timing in controller. Emmc driver used to do this switch other way around. This commit adds controller timing switch in EmmcSwitchBusTiming function to enforce this order and removes all controller timing programing from

Re: [edk2-devel] [PATCH 6/7] OvmfPkg: strip trailing whitespace

2019-09-23 Thread Philippe Mathieu-Daudé
On 9/20/19 12:24 PM, Leif Lindholm wrote: > > On Fri, Sep 20, 2019 at 08:13:36AM +0200, Laszlo Ersek wrote: >> On 09/19/19 20:06, Leif Lindholm wrote: >>> Cc: Jordan Justen >>> Cc: Laszlo Ersek >>> Cc: Ard Biesheuvel >>> Cc: Anthony Perard >>> Cc: Julien Grall >>> Cc: David Woodhouse >>>

Re: [edk2-devel] [edk2-platforms][PATCH V1 06/12] KabylakeOpenBoardPkg: Move flash map to board

2019-09-23 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: Kubacki, Michael A Sent: Friday, September 20, 2019 11:40 AM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Sinha, Ankit ; Jeremy Soller Subject: [edk2-platforms][PATCH V1 06/12] KabylakeOpenBoardPkg: Move

Re: [edk2-devel] [edk2-platforms][PATCH V1 05/12] KabylakeOpenBoardPkg: Move EcCommands.h to KabylakeRvp3 board

2019-09-23 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: devel@edk2.groups.io On Behalf Of Kubacki, Michael A Sent: Friday, September 20, 2019 11:40 AM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Sinha, Ankit ; Jeremy Soller Subject: [edk2-devel]

Re: [edk2-devel] [edk2-platforms][PATCH V1 11/12] KabylakeOpenBoardPkg/GalagoPro3: Add build files

2019-09-23 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: Kubacki, Michael A Sent: Friday, September 20, 2019 11:40 AM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Sinha, Ankit ; Jeremy Soller Subject: [edk2-platforms][PATCH V1 11/12]

Re: [edk2-devel] [edk2-platforms][PATCH V1 10/12] KabylakeOpenBoardPkg/GalagoPro3: Add modules

2019-09-23 Thread Nate DeSimone
I would like us to re-evaluate whether an override of PlatformInitPreMem is really needed... but I understand that is not in scope for this patch series. Reviewed-by: Nate DeSimone -Original Message- From: Kubacki, Michael A Sent: Friday, September 20, 2019 11:40 AM To:

Re: [edk2-devel] [edk2-platforms][PATCH V1 10/12] KabylakeOpenBoardPkg/GalagoPro3: Add modules

2019-09-23 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Kubacki, Michael A > Sent: Saturday, September 21, 2019 2:40 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Sinha, Ankit ; > Jeremy Soller > Subject: [edk2-platforms][PATCH V1 10/12] >

Re: [edk2-devel] [PATCH 26/35] SecurityPkg: fix UninstallMultipleProtocolInterfaces() calls

2019-09-23 Thread Philippe Mathieu-Daudé
On 9/17/19 9:49 PM, Laszlo Ersek wrote: > Unlike the InstallMultipleProtocolInterfaces() boot service, which takes > an (EFI_HANDLE*) as first parameter, the > UninstallMultipleProtocolInterfaces() boot service takes an EFI_HANDLE as > first parameter. > > These are actual bugs. They must have

Re: [edk2-devel] BaseTools --hash malfunction after migrate from stable201905 to stable201908

2019-09-23 Thread Steven Shi
Hi Derek, Thank you to raise this issue. We will fix it and add back the --hash original functionality. Thanks Steven From: Lin, Derek (HPS SW) [mailto:derek.l...@hpe.com] Sent: Friday, September 20, 2019 2:54 PM To: devel@edk2.groups.io Cc: Feng, Bob C ; Shi, Steven Subject: BaseTools --hash

Re: [edk2-devel] [edk2-platforms][PATCH V1 04/12] KabylakeOpenBoardPkg: Move policy update libs to KabylakeRvp3 board

2019-09-23 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: devel@edk2.groups.io On Behalf Of Kubacki, Michael A Sent: Friday, September 20, 2019 11:40 AM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Sinha, Ankit ; Jeremy Soller Subject: [edk2-devel]

Re: [edk2-devel] [PATCH 2/7] ArmPlatformPkg: strip trailing whitespace

2019-09-23 Thread Philippe Mathieu-Daudé
On 9/19/19 8:06 PM, Leif Lindholm wrote: > Cc: Ard Biesheuvel > Signed-off-by: Leif Lindholm > --- > ArmPlatformPkg/Scripts/Ds5/profile.py | 2 +- > ArmPlatformPkg/Scripts/Makefile | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git

Re: [edk2-devel] [RFC] EDK II Continuous Integration Phase 1

2019-09-23 Thread Michael D Kinney
Hi Sean, For host based tests, I agree that VS2017 or VS2019 would be a good choice. Pick the one with the best coverage and easiest for developers to get feedback on the test results and test coverage. That may be sufficient for automated CI tests. Enabling other tool chains for host based

Re: [edk2-devel] [edk2-platforms][PATCH V1 10/12] KabylakeOpenBoardPkg/GalagoPro3: Add modules

2019-09-23 Thread Kubacki, Michael A
Agree as noted in the patch commit message. At the very least an alternative solution must be used that eliminates the override copy. Thanks, Michael > -Original Message- > From: devel@edk2.groups.io On Behalf Of Nate > DeSimone > Sent: Monday, September 23, 2019 1:16 AM > To: Kubacki,

Re: [edk2-devel] [Qemu-devel] [PATCH 1/2] q35: implement 128K SMRAM at default SMBASE address

2019-09-23 Thread Laszlo Ersek
On 09/20/19 11:28, Laszlo Ersek wrote: > On 09/20/19 10:28, Igor Mammedov wrote: >> On Thu, 19 Sep 2019 19:02:07 +0200 >> "Laszlo Ersek" wrote: >> >>> Hi Igor, >>> >>> (+Brijesh) >>> >>> long-ish pondering ahead, with a question at the end. >> [...] >> >>> Finally: can you please remind me why we

Re: [edk2-devel] [edk2-platforms][PATCH V1 1/1] ClevoOpenBoardPkg/N1xxWU: Enable Synaptics touchpad support in OS

2019-09-23 Thread Sinha, Ankit
Reviewed-by: Ankit Sinha -Original Message- From: devel@edk2.groups.io On Behalf Of Kubacki, Michael A Sent: Thursday, September 19, 2019 7:16 PM To: devel@edk2.groups.io Cc: Sinha, Ankit ; Desimone, Nathaniel L Subject: [edk2-devel] [edk2-platforms][PATCH V1 1/1]

Re: [edk2-devel] [edk2-platforms][PATCH V1 01/12] Platform/Intel: Remove N1xxWU board build option

2019-09-23 Thread Jeremy Soller
Reviewed-by: Jeremy Soller On Fri, Sep 20, 2019, at 12:40 PM, Kubacki, Michael A wrote: > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2207 > > The N1xxWU board contents will be moved to KabylakeOpenBoardPkg > to reduce code duplication between ClevoOpenBoardPkg and >

Re: [edk2-devel] [edk2-platforms][PATCH V1 01/12] Platform/Intel: Remove N1xxWU board build option

2019-09-23 Thread Sinha, Ankit
Reviewed-by: Ankit Sinha -Original Message- From: devel@edk2.groups.io On Behalf Of Kubacki, Michael A Sent: Friday, September 20, 2019 11:40 AM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Sinha, Ankit ; Jeremy Soller Subject: [edk2-devel]

Re: [edk2-devel] [edk2-platforms][PATCH V1 03/12] ClevoOpenBoardPkg: Remove global files and references

2019-09-23 Thread Jeremy Soller
Reviewed-by: Jeremy Soller On Fri, Sep 20, 2019, at 12:40 PM, Michael Kubacki wrote: > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2207 > > Remove references to ClevoOpenBoardPkg external to the package > since the package is now removed. > > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc:

Re: [edk2-devel] [edk2-non-osi][PATCH V1 1/1] edk2-non-osi: Rename ClevoOpenBoardBinPkg to KabylakeOpenBoardBinPkg

2019-09-23 Thread Jeremy Soller
Reviewed-by: Jeremy Soller On Fri, Sep 20, 2019, at 12:39 PM, Kubacki, Michael A wrote: > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2207 > > * Renames the package to align with removal of ClevoOpenBoardPkg. > * Updates the KabylakeOpenBoardBinPkg maintainer list. > > Cc: Nate

Re: [edk2-devel] [edk2-platforms][PATCH V1 11/12] KabylakeOpenBoardPkg/GalagoPro3: Add build files

2019-09-23 Thread Jeremy Soller
Reviewed-by: Jeremy Soller On Fri, Sep 20, 2019, at 12:40 PM, Kubacki, Michael A wrote: > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2207 > > * Adds files required to build the GalagoPro3 board to the board >directory. > * Updates KabylakeOpenBoardPkg/OpenBoardPkg.dec to reference

Re: [edk2-devel] [edk2-platforms][PATCH V1 06/12] KabylakeOpenBoardPkg: Move flash map to board

2019-09-23 Thread Jeremy Soller
Reviewed-by: Jeremy Soller On Fri, Sep 20, 2019, at 12:40 PM, Michael Kubacki wrote: > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2207 > > The flash map currently in KabylakeOpenBoardPkg is only > applicable to the KabylakeRvp3 board. This change moves > the flash map to that board

Re: [edk2-devel] [edk2-platforms][PATCH V1 10/12] KabylakeOpenBoardPkg/GalagoPro3: Add modules

2019-09-23 Thread Jeremy Soller
Reviewed-by: Jeremy Soller On Fri, Sep 20, 2019, at 12:40 PM, Michael Kubacki wrote: > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2207 > > Adds the modules used for System 76 Galago Pro 3 board support. > > This override should be removed in a future cleanup change. That is > outside

Re: [edk2-devel] [edk2-platforms][PATCH V1 1/1] ClevoOpenBoardPkg/N1xxWU: Enable Synaptics touchpad support in OS

2019-09-23 Thread Jeremy Soller
Reviewed-by: Jeremy Soller On Thu, Sep 19, 2019, at 8:15 PM, Kubacki, Michael A wrote: > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2068 > > Adds the ACPI device for the Synaptics touchpad. With this change, > the touchpad device is functional in the OS. > > Cc: Ankit Sinha > Cc: Nate

Re: [edk2-devel] [edk2-platforms][PATCH V1 08/12] KabylakeOpenBoardPkg/GalagoPro3: Add headers

2019-09-23 Thread Jeremy Soller
Reviewed-by: Jeremy Soller On Fri, Sep 20, 2019, at 12:40 PM, Kubacki, Michael A wrote: > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2207 > > Adds the Galago Pro 3 board ID header file. > > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Ankit Sinha > Cc: Jeremy Soller > Signed-off-by:

Re: [edk2-devel] [edk2-platforms][PATCH V1 07/12] KabylakeOpenBoardPkg: Add PeiSerialPortLibSpiFlash

2019-09-23 Thread Jeremy Soller
Reviewed-by: Jeremy Soller On Fri, Sep 20, 2019, at 12:40 PM, Michael Kubacki wrote: > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2207 > > PeiSerialPortLibSpiFlash is currently used for early boot closed > chassis debug on production systems such as the System 76 Galago Pro > laptop.

Re: [edk2-devel] [edk2-platforms][PATCH V1 12/12] Add GalagoPro3 board details to global build and documentation

2019-09-23 Thread Jeremy Soller
Reviewed-by: Jeremy Soller On Fri, Sep 20, 2019, at 12:40 PM, Michael Kubacki wrote: > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2207 > > * Updates maintainers for the System 76 GalagoPro3 board > * Updated Readme.md with System 76 GalagoPro3 board details > * Adds the ability to

Re: [edk2-devel] [edk2-platforms][PATCH V1 04/12] KabylakeOpenBoardPkg: Move policy update libs to KabylakeRvp3 board

2019-09-23 Thread Jeremy Soller
Reviewed-by: Jeremy Soller On Fri, Sep 20, 2019, at 12:40 PM, Kubacki, Michael A wrote: > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2207 > > To prepare KabylakeOpenBoardPkg for multi-board support, the policy > update libraries should be moved to the individual board directory. >

Re: [edk2-devel] [edk2-platforms][PATCH V1 05/12] KabylakeOpenBoardPkg: Move EcCommands.h to KabylakeRvp3 board

2019-09-23 Thread Jeremy Soller
Reviewed-by: Jeremy Soller On Fri, Sep 20, 2019, at 12:40 PM, Michael Kubacki wrote: > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2207 > > EC command details may vary across Kaby Lake boards. This change moves > this set of EC commands to the KabylakeRvp3 directory since these >

[edk2-devel] [PATCH] MdeModulePkg: Enable/Disable S3BootScript dynamically.

2019-09-23 Thread Chiu, Chasel
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2212 Current S3BootScriptLib can only support build time opt-out but in binary model the same binary should support both enabling and disabling scenarios. To support this below PCD is expected to be used as DynamicPCD (or DynamicEx) to skip

Re: [edk2-devel] [edk2-test][Patch] uefi-sct/SctPkg: Add MediaPresentSupported check

2019-09-23 Thread Eric Jin
Xianhui, The content is clear to me. Two comments: 1. The copyright year is not updated. I will help to update when I commit, but hold one day to wait for possible comments. Reviewed-by: Eric Jin 2. Could you please provide the patch on the IHV part? Thanks. Best Regards Eric -Original

[edk2-devel] [Patch] Maintainers.txt: Move ShellBin maintainers to EDK II Releases section

2019-09-23 Thread Liming Gao
ShellBinPkg is generated for each edk2 stable tag release. Cc: Andrew Fish Cc: Laszlo Ersek Cc: Leif Lindholm Cc: Michael D Kinney Signed-off-by: Liming Gao --- Maintainers.txt | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/Maintainers.txt

Re: [edk2-devel] [Patch 05/10 V8] BaseTools: Enable Multiple Process AutoGen

2019-09-23 Thread dann frazier
On Wed, Aug 07, 2019 at 12:25:32PM +0800, Bob Feng wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875 > > Assign the Module AutoGen tasks into multiple > sub process. > > Cc: Liming Gao > Signed-off-by: Bob Feng > --- > .../Source/Python/AutoGen/AutoGenWorker.py| 191

Re: [edk2-devel] [PATCH 31/35] ShellPkg/UefiShellDebug1CommandsLib: fix ShellCloseFile() call

2019-09-23 Thread Gao, Zhichao
Reviewed-by: Zhichao Gao > -Original Message- > From: Carsey, Jaben > Sent: Monday, September 23, 2019 10:29 PM > To: Philippe Mathieu-Daudé ; devel@edk2.groups.io; > ler...@redhat.com > Cc: Ni, Ray ; Gao, Zhichao > Subject: RE: [edk2-devel] [PATCH 31/35] >

Re: [edk2-devel] [patch v2 1/5] EmbeddedPkg: Unload image on EFI_SECURITY_VIOLATION

2019-09-23 Thread Dandan Bi
Hi EmbeddedPkg maintainers , Could you help push this patch? Thanks, Dandan > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Dandan Bi > Sent: Wednesday, September 18, 2019 11:06 AM > To: devel@edk2.groups.io > Cc: Leif Lindholm ; Ard

Re: [edk2-devel] [PATCH 0/3] Arm builds on Visual Studio

2019-09-23 Thread Liming Gao
Leif: >-Original Message- >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Leif >Lindholm >Sent: Friday, September 20, 2019 4:27 AM >To: Laszlo Ersek >Cc: devel@edk2.groups.io; Gao, Liming ; Baptiste >Gerondeau ; ard.biesheu...@linaro.org; >Kinney, Michael D ;

Re: [edk2-devel] [RFC PATCH v2 00/44] SEV-ES guest support

2019-09-23 Thread Dong, Eric
Hi Tom, Thanks for you to contribute such a big changes. Seems like this is a big changes for current code, can you help to do a design review in TianoCore Design Meeting? It will be helpful for us to understand the code change and review it. Ray is the owner of that meeting, you can contact

Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v2 09/29] MdePkg/BaseIoLibIntrinsic: RISC-V I/O intrinsic functions.

2019-09-23 Thread Abner Chang
CC Maintainers. > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Abner Chang > Sent: Monday, September 23, 2019 8:32 AM > To: devel@edk2.groups.io > Cc: Chang, Abner (HPS SW/FW Technologist) > Subject: [edk2-devel] [edk2-staging/RISC-V-V2

Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v2 13/29] MdeModulePkg/Logo

2019-09-23 Thread Abner Chang
CC maintainers > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Abner Chang > Sent: Monday, September 23, 2019 8:32 AM > To: devel@edk2.groups.io > Cc: Chang, Abner (HPS SW/FW Technologist) > Subject: [edk2-devel] [edk2-staging/RISC-V-V2

Re: [edk2-devel] [edk2-platforms] Update Packages on Bugzilla

2019-09-23 Thread Kubacki, Michael A
Mike, I believe you were out of office when this was sent. Can these packages please be added? Thanks, Michael From: Kubacki, Michael A Sent: Friday, September 6, 2019 6:57 PM To: devel@edk2.groups.io Cc: Kinney, Michael D ; Wei, David Y ; Agyeman, Prince Subject: [edk2-platforms] Update

Re: [edk2-devel] [edk2-test] [PATCH 1/1] uefi-sct/SctPkg: use EFI_UNICODE_COLLATION_PROTOCOL2_GUID

2019-09-23 Thread Eric Jin
Reviewed-by: Eric Jin -Original Message- From: Heinrich Schuchardt Sent: Friday, September 20, 2019 7:07 PM To: EDK II Development Cc: Jin, Eric ; Supreeth Venkatesh ; Stephano Cetola ; Heinrich Schuchardt Subject: [edk2-test] [PATCH 1/1] uefi-sct/SctPkg: use

Re: [edk2-devel] [PATCH v3 0/2] *** Add VS2019 Support ***

2019-09-23 Thread Liming Gao
Push 6b80310f34199d1f62e45e40fa902734735091fa..670c903a68f214463f12c0c9619c162a0f342518 You can update BZ 2182 and close it. Thanks Liming >-Original Message- >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >Cheng, Ching JenX >Sent: Thursday, September 19, 2019

Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v2 10/29] MdePkg/BasePeCoff: Add RISC-V PE/Coff related code.

2019-09-23 Thread Abner Chang
CC maintainers > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Abner Chang > Sent: Monday, September 23, 2019 8:32 AM > To: devel@edk2.groups.io > Cc: Chang, Abner (HPS SW/FW Technologist) > Subject: [edk2-devel] [edk2-staging/RISC-V-V2

Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v2 11/29] MdePkg/BaseCpuLib: RISC-V Base CPU library implementation.

2019-09-23 Thread Abner Chang
CC maintainers. > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Abner Chang > Sent: Monday, September 23, 2019 8:32 AM > To: devel@edk2.groups.io > Cc: Chang, Abner (HPS SW/FW Technologist) > Subject: [edk2-devel] [edk2-staging/RISC-V-V2

Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v2 08/29] MdePkg/BaseCacheMaintenanceLib: RISC-V cache maintenance implementation.

2019-09-23 Thread Abner Chang
CC maintainers. > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Abner Chang > Sent: Monday, September 23, 2019 8:32 AM > To: devel@edk2.groups.io > Cc: Chang, Abner (HPS SW/FW Technologist) > Subject: [edk2-devel] [edk2-staging/RISC-V-V2

Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v2 14/29] NetworkPkg

2019-09-23 Thread Abner Chang
CC maintainers. > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Abner Chang > Sent: Monday, September 23, 2019 8:32 AM > To: devel@edk2.groups.io > Cc: Chang, Abner (HPS SW/FW Technologist) > Subject: [edk2-devel] [edk2-staging/RISC-V-V2

Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v2 08/29] MdePkg/BaseCacheMaintenanceLib: RISC-V cache maintenance implementation.

2019-09-23 Thread Abner Chang
CC maintainers. > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Abner Chang > Sent: Monday, September 23, 2019 8:32 AM > To: devel@edk2.groups.io > Cc: Chang, Abner (HPS SW/FW Technologist) > Subject: [edk2-devel] [edk2-staging/RISC-V-V2

Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v2 12/29] MdePkg/BaseSynchronizationLib: RISC-V cache related code.

2019-09-23 Thread Abner Chang
CC maintainers > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Abner Chang > Sent: Monday, September 23, 2019 8:32 AM > To: devel@edk2.groups.io > Cc: Chang, Abner (HPS SW/FW Technologist) > Subject: [edk2-devel] [edk2-staging/RISC-V-V2

Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v2 20/29] MdeModulePkg/DxeIplPeim : RISC-V platform level DxeIPL

2019-09-23 Thread Abner Chang
CC maintainer > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Abner Chang > Sent: Monday, September 23, 2019 8:32 AM > To: devel@edk2.groups.io > Cc: Chang, Abner (HPS SW/FW Technologist) > Subject: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH

Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v2 05/29] MdePkg/Include: RISC-V definitions.

2019-09-23 Thread Abner Chang
CC maintainers. > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Abner Chang > Sent: Monday, September 23, 2019 8:32 AM > To: devel@edk2.groups.io > Cc: Chang, Abner (HPS SW/FW Technologist) > Subject: [edk2-devel] [edk2-staging/RISC-V-V2

Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v2 07/29] MdePkg/BaseLib: BaseLib for RISC-V RV64 Processor.

2019-09-23 Thread Abner Chang
CC Maintainers. > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Abner Chang > Sent: Monday, September 23, 2019 8:32 AM > To: devel@edk2.groups.io > Cc: Chang, Abner (HPS SW/FW Technologist) > Subject: [edk2-devel] [edk2-staging/RISC-V-V2

Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v2 00/29] RISC-V EDK2 Port on

2019-09-23 Thread Abner Chang
CC maintainers. > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Abner Chang > Sent: Monday, September 23, 2019 8:31 AM > To: devel@edk2.groups.io > Cc: Chang, Abner (HPS SW/FW Technologist) > Subject: [edk2-devel] [edk2-staging/RISC-V-V2

Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v2 04/29] MdePkg: RISC-V RV64 binding in MdePkg

2019-09-23 Thread Abner Chang
CC maintainers. > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Abner Chang > Sent: Monday, September 23, 2019 8:31 AM > To: devel@edk2.groups.io > Cc: Chang, Abner (HPS SW/FW Technologist) > Subject: [edk2-devel] [edk2-staging/RISC-V-V2

Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v2 25/29] BaseTools/Scripts

2019-09-23 Thread Abner Chang
Add maintainers > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Abner Chang > Sent: Monday, September 23, 2019 8:32 AM > To: devel@edk2.groups.io > Cc: Chang, Abner (HPS SW/FW Technologist) > Subject: [edk2-devel] [edk2-staging/RISC-V-V2

Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v2 06/29] MdeModulePkg/CapsuleRuntimeDxe: Add RISCV64 arch.

2019-09-23 Thread Abner Chang
CC reviewers. > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Abner Chang > Sent: Monday, September 23, 2019 8:32 AM > To: devel@edk2.groups.io > Cc: Chang, Abner (HPS SW/FW Technologist) > Subject: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH

Re: [edk2-devel] [Patch 05/10 V8] BaseTools: Enable Multiple Process AutoGen

2019-09-23 Thread Bob Feng
Hi Dann, Thanks for raising this issue. Would you provide the static_library_files.list file, so that I can have a check? As this patch was pushed month ago, I'd like to ask if this build failure always happens since this patch was pushed? Thanks, Bob -Original Message- From:

Re: [edk2-devel] [PATCH v2] DebugFeaturePkg: Remove white space and update the ending format

2019-09-23 Thread Zhang, Shenglei
For this patch, I'll update the file format of AcpiDebug.c to Dos format when pushing the patch. Thanks, Shenglei > -Original Message- > From: Dong, Eric > Sent: Monday, September 9, 2019 8:36 AM > To: Zhang, Shenglei ; devel@edk2.groups.io > Cc: Gao, Liming > Subject: RE: [PATCH v2]

Re: [edk2-devel] [edk2-platforms][PATCH V1 07/12] KabylakeOpenBoardPkg: Add PeiSerialPortLibSpiFlash

2019-09-23 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: Kubacki, Michael A Sent: Friday, September 20, 2019 11:40 AM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Sinha, Ankit ; Jeremy Soller Subject: [edk2-platforms][PATCH V1 07/12] KabylakeOpenBoardPkg: Add

Re: [edk2-devel] [edk2-platforms][PATCH V1 08/12] KabylakeOpenBoardPkg/GalagoPro3: Add headers

2019-09-23 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: Kubacki, Michael A Sent: Friday, September 20, 2019 11:40 AM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Sinha, Ankit ; Jeremy Soller Subject: [edk2-platforms][PATCH V1 08/12]

[edk2-devel] [PATCH 0/1] Fix eMMC bus timing switch issue

2019-09-23 Thread Albecki, Mateusz
SD host controller specification section 3.9 recommends that controller's bus timing should be switched after card's bus timing has been switched. In current eMMC driver implementation every host controller switch has been done before call to EmmcSwitchBusTiming which is causing issues on some

Re: [edk2-devel] [PATCH 31/35] ShellPkg/UefiShellDebug1CommandsLib: fix ShellCloseFile() call

2019-09-23 Thread Philippe Mathieu-Daudé
On 9/17/19 9:49 PM, Laszlo Ersek wrote: > In the FileBufferSave() function, we invoke ShellCloseFile() if "Directory > Can Not Be Saved". > > The ShellCloseFile() function takes a (SHELL_FILE_HANDLE*) parameter > called "FileHandle", and correctly passes the de-referenced (*FileHandle) > to

[edk2-devel] How to fill EFI_VARIABLE_AUTHENTICATION_2 descriptor properly

2019-09-23 Thread phlamorim
I want to create an Authenticated Variable like described in UEFI specification 2.8 on tópic 8.2.2(8.2.2 Using the EFI_VARIABLE_AUTHENTICATION_2 descriptor). I understood the first step but im stucked from step 2 to 6. On the second step i should compute a Hash of the serialization of some

Re: [edk2-devel] [edk2-platforms][PATCH V1 01/12] Platform/Intel: Remove N1xxWU board build option

2019-09-23 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: devel@edk2.groups.io On Behalf Of Kubacki, Michael A Sent: Friday, September 20, 2019 11:40 AM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Sinha, Ankit ; Jeremy Soller Subject: [edk2-devel]

Re: [edk2-devel] [edk2-platforms][PATCH V1 07/12] KabylakeOpenBoardPkg: Add PeiSerialPortLibSpiFlash

2019-09-23 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Kubacki, Michael A > Sent: Saturday, September 21, 2019 2:40 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Sinha, Ankit ; > Jeremy Soller > Subject: [edk2-platforms][PATCH V1 07/12]

Re: [edk2-devel] [edk2-platforms][PATCH V1 08/12] KabylakeOpenBoardPkg/GalagoPro3: Add headers

2019-09-23 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Kubacki, Michael A > Sent: Saturday, September 21, 2019 2:40 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Sinha, Ankit ; > Jeremy Soller > Subject: [edk2-platforms][PATCH V1 08/12] >

Re: [edk2-devel] [PATCH v2] DebugFeaturePkg: Remove white space and update the ending format

2019-09-23 Thread Philippe Mathieu-Daudé
On 9/6/19 7:16 PM, Zhang, Shenglei wrote: > Remove white space in AcpiDebug.c. > The original end of last line in DebugFeaturePkg.dsc is '/r'. > Now update it to '/r/n'. > > Cc: Eric Dong > Cc: Liming Gao > Signed-off-by: Shenglei Zhang > --- > v2: In v1 the patch remove the '/r'. In v2 it is

Re: [edk2-devel] [PATCH v2] UserInterfaceFeaturePkg: Update the end of last line

2019-09-23 Thread Philippe Mathieu-Daudé
On 9/6/19 7:16 PM, Zhang, Shenglei wrote: > The original the of last line is '/r'. Now update it to '/r/n'. > > Cc: Dandan Bi > Cc: Liming Gao > Signed-off-by: Shenglei Zhang > --- > v2: In v1 the patch remove the '/r'. In v2 it is updated to '/r/n'. > The v1 patch is

Re: [edk2-devel] [PATCH 27/35] SecurityPkg: stop abusing EFI_EVENT for protocol notify registration

2019-09-23 Thread Philippe Mathieu-Daudé
On 9/17/19 9:49 PM, Laszlo Ersek wrote: > EfiCreateProtocolNotifyEvent() takes a (VOID**) for "Registration", > similarly to gBS->RegisterProtocolNotify(). We should pass the address of > an actual pointer-to-VOID, and not the address of an EFI_EVENT. EFI_EVENT > just happens to be specified as

[edk2-devel] [PATCH] MdeModulePkg/UfsPassThru : Fix UFS flag read from Query Resp UPIU

2019-09-23 Thread Agrawal, Sachin
As per UFS spec, flag value is stored in the 'last byte' of value field. Existing code is attempting to read first byte. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2208 Test: Verified the Fix by sending command to set fPowerOnWPEn flag and then reading it to verify the set value. Cc:

Re: [edk2-devel] [PATCH 10/35] MdeModulePkg/PlatformVarCleanupLib: fix HiiConstructConfigHdr() call

2019-09-23 Thread Philippe Mathieu-Daudé
On 9/17/19 9:49 PM, Laszlo Ersek wrote: > The HiiConstructConfigHdr() function takes the "DriverHandle" parameter in > order to fetch the device path from it, and then turn the device path into > PATH routing information. > > The HiiConstructConfigHdr() function is called from >