Andrew:
Current implementation requires PEI PcdDB and DXE PcdDB match. This is like a
new request for PCD DataBase. It requests PCD DB binary format and Dynamic PCD
token assignment be compatible in the different version.
Thanks
Liming
> -Original Message-
> From: devel@edk2.groups.io
Reviewed-by: Liming Gao
PR https://github.com/tianocore/edk2/pull/366
> -Original Message-
> From: Felix Polyudov
> Sent: Wednesday, February 12, 2020 6:35 AM
> To: Gao, Liming ; 'devel@edk2.groups.io'
>
> Subject: RE: [PATCH] MdePkg: Add PCI Express 5.0 Header File
>
> Liming,
>
>
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Esakkithevar, Kathappan
> Sent: Wednesday, February 12, 2020 3:13 AM
> To: devel@edk2.groups.io
> Cc: Chaganty, Rangasai V ; Chiu, Chasel
> ; Desimone, Nathaniel L
> ; Kethi Reddy, Deepika
> ; Agyeman, Prince
>
> Subject:
Jaben,
My example was confusing, but my use case was to put this code in a library
that adds a command. So after I register the command I’d like to register the
file type to be processed by it.
Making an alias for an external command could be a different feature?
> On Feb 11, 2020, at 5:30 PM,
V3 Changes:
Remove the feature PCD PcdCpuShadowMicrocodeByFit because the
whole FIT microcode shadow code is moved to this PEIM so platform
could disable this feature by not include PEIM now.
V2 Changes:
Rename EDKII_PEI_CPU_MICROCODE_ID to EDKII_PEI_MICROCODE_CPU_ID.
This patch adds a platform
Liming,
I agree I don't think this has been thought about.
Does the edk2 still support booting a split PEI from ROM and DXE from capsule
for update? If yes that seems to imply the assumption is that platform would
not change any Dynamic PCD layout, or update the PCD database versions. If you
Reviewed-by: Nate DeSimone
-Original Message-
From: Esakkithevar, Kathappan
Sent: Tuesday, February 11, 2020 11:13 AM
To: devel@edk2.groups.io
Cc: Chaganty, Rangasai V ; Chiu, Chasel
; Desimone, Nathaniel L
; Kethi Reddy, Deepika
; Agyeman, Prince
Subject: [edk2-platforms] [PATCH
Reviewed-by: Nate DeSimone
-Original Message-
From: Esakkithevar, Kathappan
Sent: Tuesday, February 11, 2020 11:13 AM
To: devel@edk2.groups.io
Cc: Chaganty, Rangasai V ; Chiu, Chasel
; Desimone, Nathaniel L
; Kethi Reddy, Deepika
; Agyeman, Prince
Subject: [edk2-platforms] [PATCH
Reviewed-by: Liming Gao
> -Original Message-
> From: Liu, Zhiguang
> Sent: Wednesday, February 12, 2020 9:40 AM
> To: devel@edk2.groups.io
> Cc: Feng, Bob C ; Gao, Liming
> Subject: [PATCH] BaseTools: remove -DNO_MSABI_VA_FUNCS option in CLANGPDB
> tool chain
>
> REF:
Reviewed-by: Eric Dong
-Original Message-
From: Ray Ni
Sent: Tuesday, November 26, 2019 2:16 PM
To: devel@edk2.groups.io
Cc: Ni, Ray ; Dong, Eric ; Zeng, Star
; Kinney, Michael D
Subject: [PATCH v2 3/3] UefiCpuPkg/CpuFeature: Introduce First to indicate 1st
unit.
From: Ray Ni
Hi Lin,
Next time you might need have Mike Kinney in the cc list:)
Reviewed-by: Zailiang Sun
-Original Message-
From: Gary Lin
Sent: Wednesday, February 12, 2020 2:24 PM
To: devel@edk2.groups.io
Cc: Sun, Zailiang ; Qian, Yi
Subject: [PATCH 1/2] Vlv2TbltDevicePkg/GenerateCapsule:
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Esakkithevar, Kathappan
> Sent: Wednesday, February 12, 2020 3:13 AM
> To: devel@edk2.groups.io
> Cc: Chaganty, Rangasai V ; Chiu, Chasel
> ; Desimone, Nathaniel L
> ; Kethi Reddy, Deepika
> ; Agyeman, Prince
>
> Subject:
Andrew
You can already add a command via a driver (including a driver's library).
Check into the Dynamic Commands in the shell spec.
Associating a file type with a command, basically if the first thing on the
command line is a file of that type, then prepend the command and re-process
the
Reviewed-by: Chasel Chiu
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of
> Kathappan Esakkithevar
> Sent: Wednesday, February 12, 2020 3:13 AM
> To: devel@edk2.groups.io
> Subject: [edk2-devel] [edk2-platforms] [PATCH v2 0/7] Add
> CometlakeOpenBoardPkg support
>
>
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Esakkithevar, Kathappan
> Sent: Wednesday, February 12, 2020 3:13 AM
> To: devel@edk2.groups.io
> Cc: Chaganty, Rangasai V ; Chiu, Chasel
> ; Desimone, Nathaniel L
> ; Kethi Reddy, Deepika
> ; Agyeman, Prince
>
> Subject:
Clean up the script.
Cc: Zailiang Sun
cc: Yi Qian
Signed-off-by: Gary Lin
---
Platform/Intel/Vlv2TbltDevicePkg/PreBuild.py | 97
1 file changed, 97 deletions(-)
diff --git a/Platform/Intel/Vlv2TbltDevicePkg/PreBuild.py
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2304
SyntaxWarning: "is" with a literal. Did you mean "=="?
Using "is" instead of "==" is an irregular syntax
Signed-off-by: Zhiju.Fan
Cc: Bob C Feng
Cc: Liming Gao
---
BaseTools/Source/Python/build/BuildReport.py | 2 +-
1 file changed, 1
That makes sense. So really what we are missing is a method to associate a file
with a command (required to support dynamic commands).
We could do that in lots of ways, but the first I think of is to add a new API
in the ShellProtocol to perform this association.
Do we also need a shell
Reviewed-by: Nate DeSimone
-Original Message-
From: Esakkithevar, Kathappan
Sent: Tuesday, February 11, 2020 11:13 AM
To: devel@edk2.groups.io
Cc: Chaganty, Rangasai V ; Chiu, Chasel
; Desimone, Nathaniel L
; Kethi Reddy, Deepika
; Agyeman, Prince
Subject: [edk2-platforms] [PATCH
> +EFI_STATUS
> +PlatformShadowMicrocode (
> + IN OUT CPU_MP_DATA *CpuMpData
> + )
> +{
> + return EFI_UNSUPPORTED;
> +}
Siyuan,
Better to have comments above "return EFI_UNSUPPORTED" to clarify the
existing supporting scope.
With that, Reviewed-by: Ray Ni
+ Mike for potential
On Wed, Feb 12, 2020 at 06:31:46AM +, Sun, Zailiang wrote:
> Hi Lin,
>
> Next time you might need have Mike Kinney in the cc list:)
>
Ok, will do that if I have patches for Vlv2TbltDevicePkg.
Thanks,
Gary Lin
> Reviewed-by: Zailiang Sun
>
> -Original Message-
> From: Gary Lin
Hi Vitaly,
After your patch to Switch to GNU mode for CLANGPDB, the build option
-DNO_MSABI_VA_FUNCS is not required. I will send another patch to remove it.
And for you question, this is a patch set that resolves BZ 2415, and the second
patch 21821933aea284cd3dfea6994bd4b83bd9739fc9 has direct
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2524
remove -DNO_MSABI_VA_FUNCS option in CLANGPDB tool chain After CLANGPDB is
switched to GNU mode, to use MS ABI version of GCC built-in macros for
variable argument lists as same as CLANG38 tool chain.
Cc: Bob Feng
Cc: Liming Gao
This patch set is good to me.
Reviewed-by: Bob Feng
-Original Message-
From: devel@edk2.groups.io On Behalf Of PierreGondois
Sent: Monday, February 10, 2020 6:49 PM
To: devel@edk2.groups.io
Cc: Pierre Gondois ; Feng, Bob C
; Gao, Liming ;
sami.muja...@arm.com;
Pushed.
-Original Message-
From: devel@edk2.groups.io On Behalf Of Bob Feng
Sent: Wednesday, February 12, 2020 10:07 AM
To: devel@edk2.groups.io; pierre.gond...@arm.com
Cc: Gao, Liming ; sami.muja...@arm.com; n...@arm.com
Subject: Re: [edk2-devel] [PATCH v4 0/2] BaseTools: Rationalise
For the patch series...
Reviewed-by: Nate DeSimone
-Original Message-
From: Chiu, Chasel
Sent: Sunday, February 9, 2020 7:53 PM
To: devel@edk2.groups.io
Cc: Ma, Maurice ; Desimone, Nathaniel L
; Zeng, Star
Subject: [PATCH 0/2] IntelFsp2Pkg: Coverity scan flags issues
GenCfgOpt.py:
Check if the ACPI table length, as reported in the ACPI table header, is
big enough to fit at least the header itself.
If not, report an error to the user and stop parsing the table in order
to prevent buffer overruns.
Signed-off-by: Krzysztof Koch
---
Changes can be seet at:
By the way, please rebase to the latest code when sending out
the V2 patch.
> -Original Message-
> From: Ni, Ray
> Sent: Tuesday, February 11, 2020 7:21 PM
> To: Fu, Siyuan ; devel@edk2.groups.io
> Cc: Dong, Eric ; Laszlo Ersek ;
> Kinney, Michael D
> Subject: RE: [Patch 1/2]
Reviewed-by: Liming Gao
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Vitaly
> Cheptsov via Groups.Io
> Sent: Tuesday, February 11, 2020 2:53 PM
> To: devel@edk2.groups.io
> Subject: [edk2-devel] [PATCH V2 1/1] BaseTools: Switch to GNU mode for
> CLANGPDB
>
> REF:
On Fri, Feb 07, 2020 at 18:13:19 +0530, Pankaj Bansal wrote:
> Keep the names and location of files as mentioned in ArmPlatformPkg.
This isn't really a goal in itself, but the AArch64/ addition is good
cleanup, so I'm not objecting. But please mention that one explicitly.
> This helps in porting
On Fri, Feb 07, 2020 at 18:13:18 +0530, Pankaj Bansal wrote:
> As per convention being followed in edk2-platforms, keep the dec
> file and dsc file together.
>
> Signed-off-by: Pankaj Bansal
Reviewed-by: Leif Lindholm
> ---
> Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc | 2 +-
> {Platform
> -Original Message-
> From: Leif Lindholm
> Sent: Monday, February 10, 2020 11:02 PM
> To: Pankaj Bansal
> Cc: Meenakshi Aggarwal ; Michael D Kinney
> ; Varun Sethi ;
> devel@edk2.groups.io
> Subject: Re: [PATCH 08/19] Silicon/NXP: Remove unnecessary PCDs
>
> On Fri, Feb 07, 2020 at
On 02/10/20 21:24, Michael D Kinney wrote:
> https://bugzilla.tianocore.org/show_bug.cgi?id=2514
>
> Remove EBC as one of the supported architectures
> in the UnitTestFrameworkPkg DSC file. The EBC
> compiler does not support cararg macros and the
small typo: s/cararg/vararg/
Thanks
Laszlo
>
Hi Ard
I am waiting for your response.
Regards
Gaurav
-Original Message-
From: Gaurav Jain
Sent: Friday, January 31, 2020 1:58 PM
To: Ard Biesheuvel
Cc: devel@edk2.groups.io; Leif Lindholm ; Pankaj Bansal
Subject: RE: [EXT] Re: [PATCH 1/1] EmbeddedPkg: Fixed Asserts in SCT Runtime
Hao,
I submitted a new Bugzilla to capture some potential enhancement to this patch.
https://bugzilla.tianocore.org/show_bug.cgi?id=2519
Your patch can fix the issue, but I think we need some cleanup to avoid
potential bugs in future.
Thanks,
Ray
> -Original Message-
> From: Wu, Hao A
> +typedef
> +EFI_STATUS
> +(EFIAPI *EDKII_PEI_SHADOW_MICROCODE) (
> + IN EDKII_PEI_SHADOW_MICROCODE_PPI*This,
> + IN UINTN CpuIdCount,
> + IN EDKII_PEI_CPU_MICROCODE_ID*MicrocodeCpuId,
1. How about CpuMicrocodeId or
Thank you Ray and Laszlo for your comments, I have sent the V2 patch set for
this change.
> -Original Message-
> From: Ni, Ray
> Sent: 2020年2月11日 19:24
> To: Fu, Siyuan ; devel@edk2.groups.io
> Cc: Dong, Eric ; Laszlo Ersek ;
> Kinney, Michael D
> Subject: RE: [Patch 1/2] UefiCpuPkg:
Reviewed-by: Liming Gao
> -Original Message-
> From: Fu, Siyuan
> Sent: Tuesday, February 11, 2020 9:37 PM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D ; Gao, Liming
>
> Subject: [PATCH v2 2/2] MdePkg: Remove FIT table industry standard header
> file.
>
> Commit c7c964b and
On Fri, Feb 07, 2020 at 18:13:21 +0530, Pankaj Bansal wrote:
> Add SocLib for LS1043A as per new directory structure
OK, now I'm confused again.
Separating the Chassis library from the SoC library seemed sensible.
But now we're merging them together again, only the other way around?
Can you
V2 Changes:
Rename EDKII_PEI_CPU_MICROCODE_ID to EDKII_PEI_MICROCODE_CPU_ID.
Return EFI_UNSUPPORTED instead of EFI_NOT_FOUND if no platform
microcode shadow PPI/Protocol is found.
Remove PcdCpuShadowMicrocodeByFit related tokens from UefiCpuPkg.uni
Commit c7c964b and dd01704 add header file for
Commit c7c964b and dd01704 add header file for FIT table and update
MpInitLib to support FIT based microcode shadow operation. There are
comments that FIT is Intel specific specification instead of industry
standard, which should not be placed in EDK2 MdePkg and UefiCpuPkg.
This patch removes the
On Tue, 11 Feb 2020 at 11:37, Gaurav Jain wrote:
>
> Hi Ard
>
> I am waiting for your response.
>
You said
> Either UEFI spec need to be modified as per the test or SCT Test needs fix as
> per UEFI Specification.
>
so you answered your own question, no?
> -Original Message-
> From:
Hello Bob,
If possible, I would prefer it to be committed before the freeze. Without it
our builds are failing,
Regards,
Pierre
From: devel@edk2.groups.io On Behalf Of Bob Feng via
Groups.Io
Sent: 11 February 2020 13:30
To: Pierre Gondois ; devel@edk2.groups.io
Cc: Feng, Bob C ; Gao, Liming
On Fri, Feb 07, 2020 at 18:13:20 +0530, Pankaj Bansal wrote:
> Add ChassisLib for Chassis2.
What is a Chassis2?
This adds a new package, a new library class - it needs more description.
Can we expect to see Silicon/NXP/Library/SocLib/Chassis.c broken out
into its own package in future?
>
V2 Changes:
Rename EDKII_PEI_CPU_MICROCODE_ID to EDKII_PEI_MICROCODE_CPU_ID.
Add missing files in V1 patch.
This patch adds a platform PEIM for FIT based shadow microcode PPI
support. A detailed design doc can be found here:
https://edk2.groups.io/g/devel/files/Designs/2020/0214/Support%20
On 2/10/20 11:54 PM, Laszlo Ersek wrote:
On 02/07/20 11:51, Laszlo Ersek wrote:
On 02/07/20 02:07, Philippe Mathieu-Daude wrote:
Around February of this year, Antoine posted various patches fixing
a huge quantity of typos, over 8000+ lines (such [1]).
This series salvages a third of his work.
On Fri, Feb 07, 2020 at 18:13:22 +0530, Pankaj Bansal wrote:
> RAM retrieval using SMC commands is common to all Layerscape SOCs.
> Therefore, move it to commom MemoryInit Pei Lib.
>
> Also added provision to reserve a portion of RAM.
"Also" is an indicator of something that should be a separate
Hi Pierre,
Thanks for updating the patch. I’ll trigger Intel internal CI to test this
patch.
BTW, Since edk2 soft-freeze is coming, do you require this patch to be
committed in this stable tag?
Thanks,
Bob
From: PierreGondois [mailto:pierre.gond...@arm.com]
Sent: Monday, February 10, 2020
Use lookup table to identify the platform and install corresponding ACPI
tables. As the number of supported platforms grow, the existing platform
identification using if..else does not scale well.
Signed-off-by: Vijayenthiran Subramaniam
---
Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c
This patch series adds support for RD-N1-Edge platform with multi-chip
capability. The first patch in this series is an improvement to SgiPkg to avoid
any usage of deprecated APIs. The second patch refactors the existing code to
use lookup table in order to identify the platform. The rest of the
The 'system-id' node of HW_CONFIG device tree has been updated to have
a new property 'multi-chip-mode' which holds the information about the
multi-chip-mode support. To adapt to this change, add 'MultiChipMode'
member to SGI_PLATFORM_DESCRIPTOR structure to get 'multi-chip-mode'
property from
For RD-N1-Edge platforms, use multi-chip-mode information from the
SGI platform descriptor HOB to pick the correct ACPI table to be
installed.
Signed-off-by: Vijayenthiran Subramaniam
---
Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.inf | 1 +
Add the `DISABLE_NEW_DEPRECATED_INTERFACES` build option in DSC file to
make sure that the deprecated APIs are not used SgiPkg.
Signed-off-by: Vijayenthiran Subramaniam
---
Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc | 3 +++
Platform/ARM/SgiPkg/SgiPlatform.dsc | 3 +++
2 files
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2280
This change adds owners to the the Maintainers.txt for CometlakeOpenBoardPkg.
Signed-off-by: Kathappan Esakkithevar
Cc: Sai Chaganty
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Deepika Kethi Reddy
Cc: Prince Agyeman
---
Maintainers.txt | 8
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2280
Adds the DSC and build files necessary to build the
CometlakeURvp board instance.
Key files
=
* build_config.cfg - Board-specific build configuration file.
* OpenBoardPkg.dsc - The CometlakeURvp board description file.
*
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2280
Header files for the CometlakeURvp board instance.
Signed-off-by: Kathappan Esakkithevar
Cc: Sai Chaganty
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Deepika Kethi Reddy
Cc: Prince Agyeman
---
V2:
Change copy right year to 2020 instead of 2019 at some newly created files.
Correct the typo name mistake at
SmmCometlakeURvpMultiBoardAcpiSupportLibConstructor function.
Create new GUID for PACKAGE_GUID and gCometlakeOpenBoardPkgTokenSpaceGuid at
OpenBoardPkg.dec instead reusing existing
Add a new 'initrd' command to the UEFI Shell that allows any file that is
accessible to the shell to be registered as the initrd that is returned
when Linux's EFI stub loader invokes the LoadFile2 protocol on its special
vendor media device path.
Signed-off-by: Ard Biesheuvel
---
Note that the
wuchenye1995 writes:
> Hi all,
>We found a problem with live migration of UEFI virtual machines due to
> size of OVMF.fd changes.
>Specifically, the size of OVMF.fd in edk with low version such as
> edk-2.0-25 is 2MB while the size of it in higher version such as edk-2.0-30
> is
Andrew --
I think this is a good idea, but I think this is probably a shell spec issue
because I don't want competing, incompatible implementations.
A few other issues: I think there is a persistence issue (similar to shell
variables) so that the change could be installed and survive a reboot.
Reviewed-by: Bret Barkelew
- Bret
From: devel@edk2.groups.io on behalf of Michael D Kinney
via Groups.Io
Sent: Monday, February 10, 2020 12:24:39 PM
To: devel@edk2.groups.io
Cc: Sean Brogan ; Bret Barkelew
Subject: [EXTERNAL] [edk2-devel] [Patch 0/2]
Reviewed-by: Bret Barkelew
- Bret
From: devel@edk2.groups.io on behalf of Michael D Kinney
via Groups.Io
Sent: Monday, February 10, 2020 12:24:40 PM
To: devel@edk2.groups.io
Cc: Sean Brogan ; Bret Barkelew
Subject: [EXTERNAL] [edk2-devel] [Patch 1/2]
62 matches
Mail list logo
