[edk2-devel] [PATCH] ArmVirtPkg/FdtPciHostBridgeLib: add extra roots for Arm.

2020-04-02 Thread Yubo Miao
From: miaoyubo Add support for extra roots for arm, in this patch, we import the scan for extra root buses therefore the uefi could recognize multiply roots for arm. The logic keeps the same with the logic in "OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.c" Contributed-under: TianoCore

Re: [edk2-devel] [PATCH 1/5] ArmPkg/CpuDxe: use private copy of GetRootTranslationTableInfo()

2020-04-02 Thread Ard Biesheuvel
On 4/2/20 1:03 PM, Leif Lindholm wrote: On Thu, Apr 02, 2020 at 12:29:30 +0200, Ard Biesheuvel wrote: On 4/2/20 12:28 PM, Leif Lindholm wrote: On Thu, Apr 02, 2020 at 12:20:54 +0200, Ard Biesheuvel wrote: On 4/2/20 12:16 PM, Leif Lindholm via groups.io wrote: On Sat, Mar 28, 2020 at 11:43:17

Re: [edk2-devel] [PATCH] ArmVirtPkg/FdtPciHostBridgeLib: add extra roots for Arm.

2020-04-02 Thread Laszlo Ersek
Quick review comments only, for now: On 04/02/20 14:08, Yubo Miao wrote: > From: miaoyubo > > Add support for extra roots for arm, in this patch, we > import the scan for extra root buses therefore the uefi > could recognize multiply roots for arm. > > The logic keeps the same with the logic

[edk2-devel] TianoCore Community Meeting tonight - Please note the time change reflecting daylight savings..

2020-04-02 Thread Soumya Guptha
Dear Community Members, Please note the time change on tonight's TianoCore Community meeting, reflecting the US daylight savings time change as we moved clocks an hour earlier during March. The community meeting will start from 6.30pm-7.30pm (PST). You can view the calendar here -

Re: [edk2-devel] Need newer releases/tags added to TianoCore Bugzilla

2020-04-02 Thread Michael D Kinney
Rebecca, Thanks for the reminder. I have updated the available values for that field. Mike > -Original Message- > From: devel@edk2.groups.io On > Behalf Of Rebecca Cran > Sent: Thursday, April 2, 2020 12:53 PM > To: devel@edk2.groups.io; Kinney, Michael D > > Subject: Re:

Re: [edk2-devel] TianoCore Community Meeting tonight - Please note the time change reflecting daylight savings..

2020-04-02 Thread Soumya Guptha
Sorry, Correction. The meeting is scheduled from 7.30pm-8.30pm (PST). Please note the time. _ From: Guptha, Soumya K Sent: Thursday, April 2, 2020 4:23 PM To: 'annou...@edk2.groups.io' ; devel@edk2.groups.io Subject: TianoCore Community Meeting tonight -

Re: [edk2-devel] Need newer releases/tags added to TianoCore Bugzilla

2020-04-02 Thread Michael D Kinney
Rebecca, The current use of that field is to identify previous releases that a bug fix needs to be propagated to. We do not know the exact release name for future releases until we make the release. I recommend you use the "Deadline" field to provide the date the feature must be implemented,

Re: [edk2-devel] Need newer releases/tags added to TianoCore Bugzilla

2020-04-02 Thread Rebecca Cran
Okay, but the edk2-stable202002 release is also missing. -- Rebecca Cran On 4/2/20 1:24 PM, Michael D Kinney wrote: Rebecca, The current use of that field is to identify previous releases that a bug fix needs to be propagated to. We do not know the exact release name for future releases

[edk2-devel] Upcoming Event: TianoCore Design Meeting - APAC/NAMO - Fri, 04/03/2020 9:30am-10:30am #cal-reminder

2020-04-02 Thread devel@edk2.groups.io Calendar
*Reminder:* TianoCore Design Meeting - APAC/NAMO *When:* Friday, 3 April 2020, 9:30am to 10:30am, (GMT+08:00) Asia/Chongqing *Where:* https://zoom.com.cn/j/971006237 View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=700770 ) *Organizer:* Ray Ni ray...@intel.com (

[edk2-devel] TianoCore Design Meeting - APAC/NAMO - Fri, 04/03/2020 #cal-notice

2020-04-02 Thread devel@edk2.groups.io Calendar
"TianoCore Design Meeting - APAC/NAMO" When: Friday, 3 April 2020 9:30am to 10:30am (GMT+08:00) Asia/Chongqing Where: https://zoom.com.cn/j/971006237 Organizer: ray...@intel.com Description: # TOPIC * EDK2 Redfish Implementation Review (Abner Chang/HPE) Slides:

Re: [edk2-devel] [PATCH] MdeModulePkg/SmiHandlerProfileInfo: Overflowed Array Index

2020-04-02 Thread Wang, Jian J
Hi Guomin, I think you missed one at line 435, function PowerButtonPhaseToString(). Regards, Jian From: Jiang, Guomin Sent: Monday, March 30, 2020 9:32 AM To: devel@edk2.groups.io; newexplor...@gmail.com; GuoMinJ via Groups.Io Cc: Wang, Jian J ; Wu, Hao A Subject: RE: [edk2-devel] [PATCH]

[edk2-devel] [PATCH 1/1] BaseTools:Add the spare space FV image size checker

2020-04-02 Thread Fan, ZhijuX
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2654 If FV is placed in FD region, its FV image size is fixed. When FV image size exceeds it, it will trig the build break. To alert the developer to adjust FV image size earlier, I request to add new checker for the the spare FV space. When the

Re: [edk2-devel] [PATCH v1 1/1] BaseTools: Update Edk2ToolsBuild.py to use multiple threads on Linux

2020-04-02 Thread Bob Feng
This change is good to me. Reviewed-by: Bob C Feng -Original Message- From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Michael Kubacki Sent: Friday, April 3, 2020 1:05 AM To: devel@edk2.groups.io Cc: Feng, Bob C ; Gao, Liming Subject: [edk2-devel] [PATCH v1 1/1]

[edk2-devel] [PATCH v2] MdeModulePkg/SmiHandlerProfileInfo: Overflowed Array Index

2020-04-02 Thread Guomin Jiang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2272 REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2287 REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2288 REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2289 REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2290 Index should

Re: [edk2-devel] [PATCH 1/1] BaseTools:Add the spare space FV image size checker

2020-04-02 Thread Sean via groups.io
I would have much rather seen this implemented independent of the GenFds tool as this is a nice feature but shouldn't be tightly coupled into the tool that does building and packaging firmware. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply

Re: [edk2-devel] [PATCH] .azurepipelines: Update CI steps

2020-04-02 Thread Liming Gao
Reviewed-by: Liming Gao > -Original Message- > From: devel@edk2.groups.io On Behalf Of Zhang, Shenglei > Sent: Wednesday, April 1, 2020 4:25 PM > To: devel@edk2.groups.io > Cc: Sean Brogan ; Bret Barkelew > ; Kinney, Michael D > ; Gao, Liming > Subject: [edk2-devel] [PATCH]

Re: [edk2-devel] [PATCH v2 0/2] Use submodule way to access brotli

2020-04-02 Thread Liming Gao
Reviewed-by: Liming Gao > -Original Message- > From: Zhang, Shenglei > Sent: Wednesday, April 1, 2020 4:32 PM > To: devel@edk2.groups.io > Cc: Gao, Liming ; Wang, Jian J ; > Wu, Hao A ; Feng, Bob C > > Subject: [PATCH v2 0/2] Use submodule way to access brotli > > Currently brotli is

Re: [edk2-devel] [PATCH v2] MdeModulePkg/RegularExpressionDxe: Make oniguruma a submodule in edk2.

2020-04-02 Thread Liming Gao
Reviewed-by: Liming Gao > -Original Message- > From: devel@edk2.groups.io On Behalf Of Zhang, Shenglei > Sent: Thursday, April 2, 2020 3:17 PM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Wu, Hao A ; > Gao, Liming > Subject: [edk2-devel] [PATCH v2]

Re: [edk2-devel] [PATCH 1/1] BaseTools:Add the spare space FV image size checker

2020-04-02 Thread Fan, ZhijuX
Hi, It can be implemented independent of the GenFds tool It accepts the parameters passed by building and GenFds Tool Best Regards Fan Zhiju From: sean.brogan via [] Sent: Friday, April 3, 2020 10:51 AM To: Fan; Fan, ZhijuX ; devel@edk2.groups.io Subject: Re: [edk2-devel] [PATCH 1/1]

Re: [edk2-devel] [PATCH v2] MdeModulePkg/SmiHandlerProfileInfo: Overflowed Array Index

2020-04-02 Thread Wang, Jian J
Reviewed-by: Jian J Wang Regards, Jian > -Original Message- > From: Jiang, Guomin > Sent: Friday, April 03, 2020 12:25 PM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Wu, Hao A ; > Dong, Eric ; Ni, Ray > Subject: [PATCH v2] MdeModulePkg/SmiHandlerProfileInfo: Overflowed Array >

Re: [edk2-devel] [PATCH 0/4] remove generation of EFI properties table

2020-04-02 Thread Dandan Bi
For the functionality, it is the same with before for platforms which set PcdPropertiesTableEnable to false by default. Reviewed-by: Dandan Bi for patch [PATCH 2/4] [PATCH 3/4] [PATCH 4/4]. If anyone still has the use case of enabling PcdPropertiesTableEnable, please comment. Thanks,

Re: [edk2-devel] [PATCH 1/1] BaseTools:Add the spare space FV image size checker

2020-04-02 Thread Sean via groups.io
Not sure I follow.  The changes are in BaseTools/Source/Python/GenFds/GenFds.py I am suggesting this functionality to be written outside the GenFds.py files so that we don't add complexity to the critical tools used for building and packaging FW binaries. -=-=-=-=-=-=-=-=-=-=-=- Groups.io

[edk2-devel] [PATCH] MdeModulePkg/SmiHandlerProfileInfo: Overflowed Array Index

2020-04-02 Thread Guomin Jiang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2272 REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2287 REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2288 REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2289 REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2290 Index should

[edk2-devel] Upcoming Event: TianoCore Community Meeting - APAC/NAMO - Thu, 04/02/2020 7:30pm-8:30pm #cal-reminder

2020-04-02 Thread devel@edk2.groups.io Calendar
*Reminder:* TianoCore Community Meeting - APAC/NAMO *When:* Thursday, 2 April 2020, 7:30pm to 8:30pm, (GMT-07:00) America/Los Angeles *Where:* https://bluejeans.com/889357567?src=join_info View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=700768 ) *Organizer:* Brian Richardson

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: Allow pin file to be checked out when combo is not in project manifest

2020-04-02 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: Desimone, Ashley E Sent: Tuesday, March 31, 2020 5:51 PM To: devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Pandya, Puja ; Bjorge, Erik C ; Bret Barkelew ; Agyeman, Prince Subject: [edk2-staging/EdkRepo] [PATCH] EdkRepo: Allow

Re: [edk2-devel] [PATCH 1/1] ShellPkg: Add support for input with separately reported modifiers

2020-04-02 Thread Gao, Zhichao
Hi Micheal Rothman, Can you help to review this issue? Because of the uefi spec issue, some firmware implemented the different behavior. Should the edk2 code to handle such issue? If yes, here maybe the situation: 1. Change for all apps -> uefi spec update and accept such behavior with

[edk2-devel] Upcoming Event: TianoCore Community Meeting - EMEA/NAMO - Thu, 04/02/2020 9:00am-10:00am #cal-reminder

2020-04-02 Thread devel@edk2.groups.io Calendar
*Reminder:* TianoCore Community Meeting - EMEA/NAMO *When:* Thursday, 2 April 2020, 9:00am to 10:00am, (GMT-07:00) America/Los Angeles *Where:* https://bluejeans.com/889357567?src=join_info View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=700767 ) *Organizer:* Brian Richardson

[edk2-devel] [PATCH v2] NetworkPkg/Ip6Dxe: Fix ASSERT logic in Ip6ProcessRouterAdvertise()

2020-04-02 Thread Maciej Rabeda
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2655 This patch fixes reversed logic of recently added ASSERTs which should ensure that Ip6IsNDOptionValid() implementation properly reacts to invalid packets. Cc: Jiaxin Wu Cc: Siyuan Fu Signed-off-by: Maciej Rabeda Reviewed-by: Siyuan Fu

[edk2-devel] [PATCH] BaseTools/Scripts: Add scripts to set PACKAGES_PATH environment

2020-04-02 Thread Heng Luo
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2656 1. Add GetPackagesPath.py, it will be used to get package pathes from special directories. A sub directory is a qualified package path when an EDKII Package can be found under it. 2. Add SetPackagesPath.bat and SetPackagesPath.sh, these

Re: [edk2-devel] [PATCH 1/1] ShellPkg: Add support for input with separately reported modifiers

2020-04-02 Thread Gao, Zhichao
Summarize the issue, if anything incorrect, please help to correct it. Thanks. Background: Uefi spec ambiguous description: > When interpreting the data from this function, it should be noted that if a > class > of printable characters that are normally adjusted by shift modifiers (e.g. > Shift

[edk2-devel] [edk2-staging][PATCH] BaseTools/Fmmt: Enhance for check input FD size

2020-04-02 Thread Feng, YunhuaX
Enhance for check input FD if empty file or not. Cc: Bob Feng Cc: Liming Gao Signed-off-by: Yunhua Feng --- BaseTools/Source/C/FMMT/FirmwareModuleManagement.c | 2 +- BaseTools/Source/C/FMMT/FmmtLib.c | 5 + 2 files changed, 6 insertions(+), 1 deletion(-) diff --git

[edk2-devel] [PATCH v2] MdeModulePkg/RegularExpressionDxe: Make oniguruma a submodule in edk2.

2020-04-02 Thread Zhang, Shenglei
Use submodule way to access oniguruma. And upgrade oniguruma version from v6.9.3 to v6.9.4_mark1. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2073 Cc: Jian J Wang Cc: Hao A Wu Cc: Liming Gao Signed-off-by: Shenglei Zhang --- v2:1.Update the inf file to make VS2019 build pass.

Re: [edk2-devel] [PATCH] BaseTools/Scripts: Add scripts to set PACKAGES_PATH environment

2020-04-02 Thread Sean via groups.io
I am not a fan of this.  The community and design meetings have had a few discussions about tools (PyTools has been presented twice) and a few brief discussions about common patterns to build platforms but I don't think there is real alignment.  Each "platform" has its own way of doing things.

[edk2-devel] [PATCH v1 1/1] BaseTools: Update Edk2ToolsBuild.py to use multiple threads on Linux

2020-04-02 Thread Michael Kubacki
From: Sean Brogan REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2640 Azure Pipelines agents have 2 threads. This commit has been shown to reduce the build time in half on those agents. Cc: Bob C Feng Cc: Liming Gao Signed-off-by: Michael Kubacki --- BaseTools/Edk2ToolsBuild.py | 16

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH v1 0/7] Adding support for archiving branch combos

2020-04-02 Thread Bjorge, Erik C
I will fix it next time. -Erik -Original Message- From: Desimone, Nathaniel L Sent: Wednesday, April 1, 2020 10:59 PM To: devel@edk2.groups.io; Bjorge, Erik C Cc: Desimone, Ashley E ; Pandya, Puja ; Bret Barkelew ; Agyeman, Prince Subject: RE: [edk2-devel] [edk2-staging/EdkRepo]

Re: [edk2-devel] [PATCH 5/5] ArmPkg/ArmMmuLib: drop unused TT_ATTR_INDX_INVALID CPP symbol

2020-04-02 Thread Ard Biesheuvel
On 4/2/20 12:23 PM, Leif Lindholm via groups.io wrote: On Sat, Mar 28, 2020 at 11:43:21 +0100, Ard Biesheuvel wrote: TT_ATTR_INDX_INVALID is #define'd but never used so drop it. Signed-off-by: Ard Biesheuvel --- ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuLibCore.c | 3 --- 1 file changed, 3

Re: [edk2-devel] [PATCH 1/5] ArmPkg/CpuDxe: use private copy of GetRootTranslationTableInfo()

2020-04-02 Thread Ard Biesheuvel
On 4/2/20 12:28 PM, Leif Lindholm wrote: On Thu, Apr 02, 2020 at 12:20:54 +0200, Ard Biesheuvel wrote: On 4/2/20 12:16 PM, Leif Lindholm via groups.io wrote: On Sat, Mar 28, 2020 at 11:43:17 +0100, Ard Biesheuvel wrote: Before getting rid of GetRootTranslationTableInfo() and the related

Re: [edk2-devel] [PATCH 1/5] ArmPkg/CpuDxe: use private copy of GetRootTranslationTableInfo()

2020-04-02 Thread Leif Lindholm
On Thu, Apr 02, 2020 at 12:29:30 +0200, Ard Biesheuvel wrote: > On 4/2/20 12:28 PM, Leif Lindholm wrote: > > On Thu, Apr 02, 2020 at 12:20:54 +0200, Ard Biesheuvel wrote: > > > On 4/2/20 12:16 PM, Leif Lindholm via groups.io wrote: > > > > On Sat, Mar 28, 2020 at 11:43:17 +0100, Ard Biesheuvel

Re: [edk2-devel] [PATCH 1/5] ArmPkg/CpuDxe: use private copy of GetRootTranslationTableInfo()

2020-04-02 Thread Leif Lindholm
On Sat, Mar 28, 2020 at 11:43:17 +0100, Ard Biesheuvel wrote: > Before getting rid of GetRootTranslationTableInfo() and the related > LookupAddresstoRootTable() in AARCH64's version of ArmMmuLib, add a > version of the former to CpuDxe, which will be its only remaining > user. While at it,

Re: [edk2-devel] [PATCH 1/5] ArmPkg/CpuDxe: use private copy of GetRootTranslationTableInfo()

2020-04-02 Thread Ard Biesheuvel
On 4/2/20 12:16 PM, Leif Lindholm via groups.io wrote: On Sat, Mar 28, 2020 at 11:43:17 +0100, Ard Biesheuvel wrote: Before getting rid of GetRootTranslationTableInfo() and the related LookupAddresstoRootTable() in AARCH64's version of ArmMmuLib, add a version of the former to CpuDxe, which

Re: [edk2-devel] [PATCH 1/5] ArmPkg/CpuDxe: use private copy of GetRootTranslationTableInfo()

2020-04-02 Thread Leif Lindholm
On Thu, Apr 02, 2020 at 12:20:54 +0200, Ard Biesheuvel wrote: > On 4/2/20 12:16 PM, Leif Lindholm via groups.io wrote: > > On Sat, Mar 28, 2020 at 11:43:17 +0100, Ard Biesheuvel wrote: > > > Before getting rid of GetRootTranslationTableInfo() and the related > > > LookupAddresstoRootTable() in

Re: [edk2-devel] [PATCH 5/5] ArmPkg/ArmMmuLib: drop unused TT_ATTR_INDX_INVALID CPP symbol

2020-04-02 Thread Ard Biesheuvel
On 4/2/20 12:57 PM, Leif Lindholm wrote: On Thu, Apr 02, 2020 at 12:29:40 +0200, Ard Biesheuvel wrote: On 4/2/20 12:23 PM, Leif Lindholm via groups.io wrote: On Sat, Mar 28, 2020 at 11:43:21 +0100, Ard Biesheuvel wrote: TT_ATTR_INDX_INVALID is #define'd but never used so drop it.

Re: [edk2-devel] [PATCH 5/5] ArmPkg/ArmMmuLib: drop unused TT_ATTR_INDX_INVALID CPP symbol

2020-04-02 Thread Leif Lindholm
On Sat, Mar 28, 2020 at 11:43:21 +0100, Ard Biesheuvel wrote: > TT_ATTR_INDX_INVALID is #define'd but never used so drop it. > > Signed-off-by: Ard Biesheuvel > --- > ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuLibCore.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git

Re: [edk2-devel] [PATCH 5/5] ArmPkg/ArmMmuLib: drop unused TT_ATTR_INDX_INVALID CPP symbol

2020-04-02 Thread Leif Lindholm
On Thu, Apr 02, 2020 at 12:29:40 +0200, Ard Biesheuvel wrote: > On 4/2/20 12:23 PM, Leif Lindholm via groups.io wrote: > > On Sat, Mar 28, 2020 at 11:43:21 +0100, Ard Biesheuvel wrote: > > > TT_ATTR_INDX_INVALID is #define'd but never used so drop it. > > > > > > Signed-off-by: Ard Biesheuvel >

Re: [edk2-devel] Query about VS2012

2020-04-02 Thread Michael D Kinney
It would also be good to clearly document the status of all tool chain tags in a few places: https://github.com/tianocore/edk2/blob/master/BaseTools/Conf/tools_def.template https://github.com/tianocore/edk2/blob/master/Readme.md The status I can think of are: 1) Actively used by EDK II CI.

Re: [edk2-devel] Upcoming Event: TianoCore Community Meeting - EMEA/NAMO - Thu, 04/02/2020 9:00am-10:00am #cal-reminder

2020-04-02 Thread Rebecca Cran
On 4/2/20 9:45 AM, devel@edk2.groups.io Calendar wrote: *Reminder:* TianoCore Community Meeting - EMEA/NAMO *When:* Thursday, 2 April 2020, 9:00am to 10:00am, (GMT-07:00) America/Los Angeles In relation to the discussion during the meeting, I've created

[edk2-devel] Need newer releases/tags added to TianoCore Bugzilla

2020-04-02 Thread Rebecca Cran
At least for the Feature Requests, the "Release(s) the issue is observed" and "Release(s) the issues must be fixed" fields are outdated, and missing newer tags. I haven't checked if the other areas such as bug reports also need updated. -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io