Re: [edk2-devel] Patch List for 202005 stable tag

2020-05-19 Thread Laszlo Ersek
On 05/19/20 14:04, Leif Lindholm wrote: > On Tue, May 19, 2020 at 11:09:42 +, Gao, Liming wrote: >> Hi Stewards and all: >> I collect current patch lists in devel mail list. Those patch contributors >> request to add them for 200205 stable tag. Because we have enter into Soft >> Feature

Re: [edk2-devel] [edk2-platforms] [PATCH 2/5] Vlv2TbltDevicePkg: Fix spelling errors

2020-05-19 Thread Michael D Kinney
Reviewed-by: Michael D Kinney > -Original Message- > From: devel@edk2.groups.io On > Behalf Of Nate DeSimone > Sent: Monday, May 18, 2020 11:18 PM > To: devel@edk2.groups.io > Cc: Sun, Zailiang ; Qian, Yi > > Subject: [edk2-devel] [edk2-platforms] [PATCH 2/5] > Vlv2TbltDevicePkg: Fix

Re: [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process

2020-05-19 Thread Sean
Nate/Laszlo, Regarding a squash merge workflow. I agree it can be abused and we all have seen terrible examples. But a patch series that contains 500+ file changes isn't really much better. Just because it is broken into multiple commits doesn't mean it is the right set of commits.

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH v1 2/2] EdkRepo: Update commands to use new submodule code

2020-05-19 Thread Ashley E Desimone
Hi Erik, Thanks for clarifying. I reapplied the patches this morning to look at and you are correct. Either I missed the content or made a mistake in applying the patches. Please ignore these comments. Thanks, Ashley Reviewed-by: Ashley DeSimone -Original Message- From: Bjorge, Erik

Re: [edk2-devel] [PATCH v2 0/2] ArmPkg/PlatformBootManagerLib: add build time checks for serial terminal settings

2020-05-19 Thread Laszlo Ersek
On 05/19/20 14:23, Ard Biesheuvel wrote: > Add build time checks for serial terminal settings, so we don't end up > with a non-functional serial console if the PCDs are set incorrectly > > v1 was just the second patch. v2 adds the first patch switching to > STATIC_ASSERT first, and then uses

Re: [edk2-devel] [PATCH V7 5/6] MdeModulePkg: Add FMP Capsule Image Header extension

2020-05-19 Thread Oleksiy Yakovlev
Hi Liming. 2 patches reviewed. Regards, Oleksiy. -Original Message- From: Gao, Liming [mailto:liming@intel.com] Sent: Monday, May 18, 2020 8:40 PM To: devel@edk2.groups.io; Oleksiy Yakovlev Cc: Kinney, Michael D; Wang, Jian J; Wu, Hao A; Yao, Jiewen; Zhang, Chao B; Felix Polyudov;

Re: [edk2-devel] [PATCH 2/2] SignedCapsulePkg: Add FMP Capsule Image Header extension

2020-05-19 Thread Oleksiy Yakovlev
Reviewed-by: Oleksiy Yakovlev -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#59832): https://edk2.groups.io/g/devel/message/59832 Mute This Topic: https://groups.io/mt/74222870/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe:

Re: [edk2-devel] [PATCH 1/2] MdeModulePkg: Add FMP Capsule Image Header extension

2020-05-19 Thread Oleksiy Yakovlev
Reviewed-by: Oleksiy Yakovlev -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#59831): https://edk2.groups.io/g/devel/message/59831 Mute This Topic: https://groups.io/mt/74222868/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe:

Re: [edk2-devel] [edk2-platforms: PATCH v2 1/3] Marvell/Library: UtmiLib: update USB2.0 analog settings

2020-05-19 Thread Leif Lindholm
On Tue, May 19, 2020 at 01:09:37 +0200, Marcin Wojtas wrote: > Hi Leif, > > pon., 18 maj 2020 o 20:16 Leif Lindholm napisał(a): > > > > On Mon, May 18, 2020 at 20:11:49 +0200, Marcin Wojtas wrote: > > > Hi Leif, > > > > > > pon., 18 maj 2020 o 19:12 Leif Lindholm napisał(a): > > > > > > > > On

[edk2-devel] [RFC edk2-platforms v3 3/3] Silicon/Hisilicon: Add RX8900RealTimeClockLib

2020-05-19 Thread Ming Huang
There are some boards base on D06, but use RX8900 RTC, so upstream the RX8900RealTimeClockLib. Signed-off-by: Ming Huang --- Silicon/Hisilicon/Library/RX8900RealTimeClockLib/RX8900RealTimeClock.h | 39 ++ Silicon/Hisilicon/Library/RX8900RealTimeClockLib/RX8900RealTimeClockLib.c | 468

[edk2-devel] [RFC edk2-platforms v3 0/3] Improve D0x

2020-05-19 Thread Ming Huang
Changes since v2: 1 Drop the Contributed-under tags. 2 revert the renaming. Ming Huang (3): Silicon/Hisilicon: Fix a typo issue in M41T83RealTimeClockLib Hisilicon/Library: Move two functions to RtcHelperLib Silicon/Hisilicon: Add RX8900RealTimeClockLib Platform/Hisilicon/D06/D06.dsc

[edk2-devel] [RFC edk2-platforms v3 2/3] Hisilicon/Library: Move two functions to RtcHelperLib

2020-05-19 Thread Ming Huang
The functions of acquiring ownership of RTC will be used for other RTC library, so move them to RtcHelperLib. Rename them by add leading Oem for uniform. Signed-off-by: Ming Huang --- Platform/Hisilicon/D06/D06.dsc | 1 +

[edk2-devel] [RFC edk2-platforms v3 1/3] Silicon/Hisilicon: Fix a typo issue in M41T83RealTimeClockLib

2020-05-19 Thread Ming Huang
There is a typo issue in M41T83RealTimeClockLib. The MACROSECOND should be MICROSECOND. Signed-off-by: Ming Huang --- Silicon/Hisilicon/Library/M41T83RealTimeClockLib/M41T83RealTimeClock.h| 4 ++-- Silicon/Hisilicon/Library/M41T83RealTimeClockLib/M41T83RealTimeClockLib.c | 14

Re: [edk2-devel] [RFC edk2-platforms v2 2/3] Hisilicon/Library: Move two functions to RtcHelperLib

2020-05-19 Thread Ming Huang
在 2020/5/19 20:16, Leif Lindholm 写道: > On Tue, May 19, 2020 at 19:08:40 +0800, Ming Huang wrote: >> The functions of acquiring ownership of RTC will be used for other >> RTC library, so move them to RtcHelperLib. Rename them by add leading >> Oem for uniform. >> >> Contributed-under: TianoCore

Re: [edk2-devel] [PATCH edk2-platforms 1/1] Platform/96Boards/96BoardsI2cDxe: rewrite DEPEX expression for legibility

2020-05-19 Thread Ard Biesheuvel
On 5/19/20 3:18 PM, Leif Lindholm via groups.io wrote: On Tue, May 19, 2020 at 14:36:58 +0200, Ard Biesheuvel wrote: Operator precedence is funny in DEPEX expressions, so let's add some parentheses to make it self explanatory. The resulting truth value is the same. Signed-off-by: Ard

Re: [edk2-devel] [PATCH edk2-platforms 1/1] Platform/96Boards/96BoardsI2cDxe: rewrite DEPEX expression for legibility

2020-05-19 Thread Leif Lindholm
On Tue, May 19, 2020 at 14:36:58 +0200, Ard Biesheuvel wrote: > Operator precedence is funny in DEPEX expressions, so let's add some > parentheses to make it self explanatory. The resulting truth value > is the same. > > Signed-off-by: Ard Biesheuvel Reviewed-by: Leif Lindholm Thanks! > --- >

Re: [edk2-devel] [PATCH v2 0/2] ArmPkg/PlatformBootManagerLib: add build time checks for serial terminal settings

2020-05-19 Thread Sami Mujawar
Reviewed-by: Sami Mujawar Regards, Sami Mujawar -Original Message- From: Ard Biesheuvel Sent: 19 May 2020 01:24 PM To: devel@edk2.groups.io Cc: l...@nuviainc.com; graeme.greg...@linaro.org; tanmay.jagd...@linaro.org; ler...@redhat.com; Sami Mujawar ; Ard Biesheuvel Subject: [PATCH

[edk2-devel] [PATCH edk2-platforms 1/1] Platform/96Boards/96BoardsI2cDxe: rewrite DEPEX expression for legibility

2020-05-19 Thread Ard Biesheuvel
Operator precedence is funny in DEPEX expressions, so let's add some parentheses to make it self explanatory. The resulting truth value is the same. Signed-off-by: Ard Biesheuvel --- Platform/96Boards/96BoardsI2cDxe/96BoardsI2cDxe.inf | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)

Re: [edk2-devel] [PATCH edk2-platforms 0/3] Silicon/SynQuacer: preparatory ConnectAll fixes

2020-05-19 Thread Ard Biesheuvel
On 5/16/20 7:59 PM, Ard Biesheuvel wrote: The ArmPkg BDS platform lib still calls ConnectAll(), which is something we should try to remove at some point. This series does some preparatory work on SynQuacer so that everything works as expected regardless of whether ConnectAll() is used: connect

Re: [edk2-devel] [edk2-platforms] [PATCH] SpiTool: Fix spelling errors

2020-05-19 Thread Leif Lindholm
On Mon, May 18, 2020 at 23:20:49 -0700, Nate DeSimone wrote: > "beggining" should be "beginning" > > Signed-off-by: Nate DeSimone Reviewed-by: Leif Lindholm Thanks Nate! Pushed as 3d2643b465f2. > Cc: Marcin Wojtas > Cc: Leif Lindholm > --- >

Re: [edk2-devel] [PATCH edk2-platforms 1/1] Silicon/Socionext/SynQuacer: use Generic Event Device for power button

2020-05-19 Thread Ard Biesheuvel
On 5/18/20 7:20 PM, Leif Lindholm via groups.io wrote: On Fri, May 15, 2020 at 10:32:35 +0200, Ard Biesheuvel wrote: Drop the description of the interrupt handling part of the GPIO controller, and use a ACPI0013 Generic Event device instead to handle the power button event. This way, an OS can

Re: [edk2-devel] [PATCH v2 0/2] ArmPkg/PlatformBootManagerLib: add build time checks for serial terminal settings

2020-05-19 Thread Leif Lindholm
On Tue, May 19, 2020 at 14:23:49 +0200, Ard Biesheuvel wrote: > Add build time checks for serial terminal settings, so we don't end up > with a non-functional serial console if the PCDs are set incorrectly > > v1 was just the second patch. v2 adds the first patch switching to > STATIC_ASSERT

[edk2-devel] [PATCH v2 1/2] ArmPkg/PlatformBootManagerLib: use static assertion for console type

2020-05-19 Thread Ard Biesheuvel
Replace the runtime ASSERT with the build time STATIC_ASSERT on the check that ensures that the terminal type we use for the serial console matches the one we explicitly add to the ConIn/ConOut/StdErr variables. This helps catch serial console issues early, even in RELEASE builds, reducing the

[edk2-devel] [PATCH v2 2/2] ArmPkg/PlatformBootManagerLib: reject 'default' parity and stop bit count

2020-05-19 Thread Ard Biesheuvel
In the ArmPkg version of PlatformBootManagerLib, we construct a serial device path based on the default settings for baud rate, parity and the number of stop bits, to ensure that a serial console is available even on the very first boot. This assumes that PcdUartDefaultParity or

[edk2-devel] [PATCH v2 0/2] ArmPkg/PlatformBootManagerLib: add build time checks for serial terminal settings

2020-05-19 Thread Ard Biesheuvel
Add build time checks for serial terminal settings, so we don't end up with a non-functional serial console if the PCDs are set incorrectly v1 was just the second patch. v2 adds the first patch switching to STATIC_ASSERT first, and then uses STATIC_ASSERT in the second one as well. Ard

Re: [edk2-devel] [RFC edk2-platforms v2 2/3] Hisilicon/Library: Move two functions to RtcHelperLib

2020-05-19 Thread Leif Lindholm
On Tue, May 19, 2020 at 19:08:40 +0800, Ming Huang wrote: > The functions of acquiring ownership of RTC will be used for other > RTC library, so move them to RtcHelperLib. Rename them by add leading > Oem for uniform. > > Contributed-under: TianoCore Contribution Agreement 1.1 We don't use this

Re: [edk2-devel] [PATCH] ArmPkg/PlatformBootManagerLib: reject 'default' parity and stop bit count

2020-05-19 Thread Ard Biesheuvel
On 5/19/20 12:00 PM, Laszlo Ersek wrote: On 05/18/20 19:11, Ard Biesheuvel wrote: In the ArmPkg version of PlatformBootManagerLib, we construct a serial device path based on the default settings for baud rate, parity and the number of stop bits, to ensure that a serial console is available even

Re: [edk2-devel] Patch List for 202005 stable tag

2020-05-19 Thread Leif Lindholm
On Tue, May 19, 2020 at 11:09:42 +, Gao, Liming wrote: > Hi Stewards and all: > I collect current patch lists in devel mail list. Those patch contributors > request to add them for 200205 stable tag. Because we have enter into Soft > Feature Freeze, I want to collect your feedback for

Re: [edk2-devel] [edk2][PATCH 1/1] HttpBoot: handle servers which may FIN after file sizing in HttpBootLoadFile

2020-05-19 Thread Maciej Rabeda
Hi Andrei, Thanks for catching this. Smells a bit like a potential issue with Python's implementation of underlying socketserver and interoperability with Windows. https://stackoverflow.com/questions/46785946/python-socketserver-sends-fin-flag Nevertheless, HTTP client should be aware that it

[edk2-devel] [RFC edk2-platforms v2 3/3] Silicon/Hisilicon: Add RX8900RealTimeClockLib

2020-05-19 Thread Ming Huang
There are some boards base on D06, but use RX8900 RTC, so upstream the RX8900RealTimeClockLib. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang --- Silicon/Hisilicon/Library/RX8900RealTimeClockLib/RX8900RealTimeClock.h | 39 ++

[edk2-devel] [RFC edk2-platforms v2 1/3] Silicon/Hisilicon: Fix a typo issue in M41T83RealTimeClockLib

2020-05-19 Thread Ming Huang
There is a typo issue in M41T83RealTimeClockLib. The MACROSECOND should be MICROSECOND. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang --- Silicon/Hisilicon/Library/M41T83RealTimeClockLib/M41T83RealTimeClock.h| 4 ++--

[edk2-devel] [RFC edk2-platforms v2 2/3] Hisilicon/Library: Move two functions to RtcHelperLib

2020-05-19 Thread Ming Huang
The functions of acquiring ownership of RTC will be used for other RTC library, so move them to RtcHelperLib. Rename them by add leading Oem for uniform. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang --- Platform/Hisilicon/D06/D06.dsc

[edk2-devel] [RFC edk2-platforms v2 0/3] Improve D0x

2020-05-19 Thread Ming Huang
Changes since v1: 1 Add a patch to fix typo issue; 2 Other modifications as comments. Ming Huang (3): Silicon/Hisilicon: Fix a typo issue in M41T83RealTimeClockLib Hisilicon/Library: Move two functions to RtcHelperLib Silicon/Hisilicon: Add RX8900RealTimeClockLib

Re: [edk2-devel] [PATCH] ArmPkg/PlatformBootManagerLib: reject 'default' parity and stop bit count

2020-05-19 Thread Leif Lindholm
+Sami On Tue, May 19, 2020 at 12:00:02 +0200, Laszlo Ersek wrote: > On 05/18/20 19:11, Ard Biesheuvel wrote: > > In the ArmPkg version of PlatformBootManagerLib, we construct a > > serial device path based on the default settings for baud rate, > > parity and the number of stop bits, to ensure

Re: [edk2-devel] [RFC edk2-platforms v1 2/2] Silicon/Hisilicon: Add RX8900RealTimeClockLib

2020-05-19 Thread Ming Huang
在 2020/5/19 2:13, Leif Lindholm 写道: > On Mon, May 18, 2020 at 21:37:24 +0800, Ming Huang wrote: >> There are some boards base on D06, but use RX8900 RTC, >> so upstream the RX8900RealTimeClockLib. >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Ming Huang >> ---

[edk2-devel] Patch List for 202005 stable tag

2020-05-19 Thread Liming Gao
Hi Stewards and all: I collect current patch lists in devel mail list. Those patch contributors request to add them for 200205 stable tag. Because we have enter into Soft Feature Freeze, I want to collect your feedback for them. If any patches are missing, please reply this mail to add them.

Re: [edk2-devel] [RFC edk2-platforms v1 1/2] Hisilicon/Library: Move two functions to RtcHelperLib

2020-05-19 Thread Ming Huang
在 2020/5/19 2:03, Leif Lindholm 写道: > On Mon, May 18, 2020 at 21:37:23 +0800, Ming Huang wrote: >> The functions of acquiring ownership of RTC will be used for other >> RTC library, so move them to RtcHelperLib. >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by:

Re: [edk2-devel] Upcoming Event: TianoCore Bug Triage - APAC / NAMO - Wed, 05/20/2020 9:30am-10:30am #cal-reminder

2020-05-19 Thread Liming Gao
Hi, all The following unconfirmed BZ will be discussed in this week TianoCore Bug Triage meeting. 2723 EDK2 Code michael.d.kin...@intel.com UNCO --- gcc10 failed to build ArmVirtPkg

Re: [edk2-devel] [PATCH edk2-platforms 1/3] Platform/96Boards/96BoardsI2cDxe: connect I2C controllers at EndOfDxe

2020-05-19 Thread Leif Lindholm
On Tue, May 19, 2020 at 12:23:21 +0200, Ard Biesheuvel wrote: > On 5/18/20 7:26 PM, Leif Lindholm wrote: > > On Sat, May 16, 2020 at 19:59:32 +0200, Ard Biesheuvel wrote: > > > The 96boards I2C driver currently relies on the platform to connect > > > all controllers, or I2C peripherals will not be

Re: [edk2-devel] [PATCH edk2-platforms 1/3] Platform/96Boards/96BoardsI2cDxe: connect I2C controllers at EndOfDxe

2020-05-19 Thread Ard Biesheuvel
On 5/18/20 7:26 PM, Leif Lindholm wrote: On Sat, May 16, 2020 at 19:59:32 +0200, Ard Biesheuvel wrote: The 96boards I2C driver currently relies on the platform to connect all controllers, or I2C peripherals will not be exposed if they are not the active boot target. Since I2C peripherals are

Re: [edk2-devel] [PATCH] ArmPkg/PlatformBootManagerLib: reject 'default' parity and stop bit count

2020-05-19 Thread Laszlo Ersek
On 05/18/20 19:11, Ard Biesheuvel wrote: > In the ArmPkg version of PlatformBootManagerLib, we construct a > serial device path based on the default settings for baud rate, > parity and the number of stop bits, to ensure that a serial console > is available even on the very first boot. > > This

Re: [edk2-devel] reg: Wifi Connection Manager Setup Page Issues

2020-05-19 Thread Dandan Bi
Hi Could you try to call WifiMgrDxeHiiConfigAccessCallback() in EFI_BROWSER_ACTION_RETRIEVE? Thanks/Dandan From: Sivaraman Nainar Sent: Friday, May 15, 2020 7:55 PM To: Wu, Jiaxin ; Rabeda, Maciej ; Bi, Dandan Cc: devel@edk2.groups.io; Sivaraman Nainar Subject: RE: reg: Wifi Connection

Re: [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process

2020-05-19 Thread Laszlo Ersek
On 05/19/20 09:21, Desimone, Nathaniel L wrote: > However, I would like to register my general endorsement for pull > requests or some other web based system of code review... and I don't > have an Instagram account by the way :) Personally, I prefer Gerrit as > I use it a lot with coreboot and

Re: [edk2-devel] [edk2-platforms] [PATCH 1/5] MinPlatformPkg: Fix spelling errors

2020-05-19 Thread Dong, Eric
Reviewed-by: Eric Dong > -Original Message- > From: Desimone, Nathaniel L > Sent: Tuesday, May 19, 2020 2:18 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Gao, Liming > ; Dong, Eric > Subject: [edk2-platforms] [PATCH 1/5] MinPlatformPkg: Fix spelling errors > > "implemenations"

Re: [edk2-devel] [edk2-platforms] [PATCH 5/5] KabylakeSiliconPkg: Fix spelling errors

2020-05-19 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Desimone, Nathaniel L > Sent: Tuesday, May 19, 2020 2:18 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Chaganty, Rangasai V > > Subject: [edk2-platforms] [PATCH 5/5] KabylakeSiliconPkg: Fix spelling errors > >

Re: [edk2-devel] [edk2-platforms] [PATCH 2/5] Vlv2TbltDevicePkg: Fix spelling errors

2020-05-19 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: devel@edk2.groups.io On Behalf Of Nate > DeSimone > Sent: Tuesday, May 19, 2020 2:18 PM > To: devel@edk2.groups.io > Cc: Sun, Zailiang ; Qian, Yi > Subject: [edk2-devel] [edk2-platforms] [PATCH 2/5] Vlv2TbltDevicePkg: Fix >

Re: [edk2-devel] [edk2-platforms] [PATCH 3/5] CoffeeLakeSiliconPkg: Fix spelling errors

2020-05-19 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Desimone, Nathaniel L > Sent: Tuesday, May 19, 2020 2:18 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Chaganty, Rangasai V > > Subject: [edk2-platforms] [PATCH 3/5] CoffeeLakeSiliconPkg: Fix spelling > errors > >

Re: [edk2-devel] [edk2-platforms] [PATCH 4/5] IntelSiliconPkg: Fix spelling errors

2020-05-19 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: devel@edk2.groups.io On Behalf Of Nate > DeSimone > Sent: Tuesday, May 19, 2020 2:18 PM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Chaganty, Rangasai V > > Subject: [edk2-devel] [edk2-platforms] [PATCH 4/5] IntelSiliconPkg: Fix >

Re: [edk2-devel] [edk2-platforms] [PATCH 1/5] MinPlatformPkg: Fix spelling errors

2020-05-19 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Desimone, Nathaniel L > Sent: Tuesday, May 19, 2020 2:18 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Gao, Liming > ; Dong, Eric > Subject: [edk2-platforms] [PATCH 1/5] MinPlatformPkg: Fix spelling errors > >

Re: [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process

2020-05-19 Thread Nate DeSimone
Hi All, I tend to agree with most of Laszlo's points. Specifically, that moving to pull requests will not fix the fact that maintainers are usually busy people and don't always give feedback in a punctual manner. Like Laszlo, I would also prefer that we do not squash patch series. My biggest

Re: [edk2-devel] [edk2-platforms] [PATCH 5/5] KabylakeSiliconPkg: Fix spelling errors

2020-05-19 Thread Chaganty, Rangasai V
Reviewed-by: Sai Chaganty -Original Message- From: Desimone, Nathaniel L Sent: Monday, May 18, 2020 11:18 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Chaganty, Rangasai V Subject: [edk2-platforms] [PATCH 5/5] KabylakeSiliconPkg: Fix spelling errors "implemenations" should be

Re: [edk2-devel] [edk2-platforms] [PATCH 4/5] IntelSiliconPkg: Fix spelling errors

2020-05-19 Thread Chaganty, Rangasai V
Reviewed-by: Sai Chaganty -Original Message- From: Desimone, Nathaniel L Sent: Monday, May 18, 2020 11:18 PM To: devel@edk2.groups.io Cc: Ni, Ray ; Chaganty, Rangasai V Subject: [edk2-platforms] [PATCH 4/5] IntelSiliconPkg: Fix spelling errors "implemenations" should be

Re: [edk2-devel] [edk2-platforms] [PATCH 3/5] CoffeeLakeSiliconPkg: Fix spelling errors

2020-05-19 Thread Chaganty, Rangasai V
Reviewed-by: Sai Chaganty -Original Message- From: Desimone, Nathaniel L Sent: Monday, May 18, 2020 11:18 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Chaganty, Rangasai V Subject: [edk2-platforms] [PATCH 3/5] CoffeeLakeSiliconPkg: Fix spelling errors "implemenations" should be

[edk2-devel] [edk2-platforms] [PATCH] SpiTool: Fix spelling errors

2020-05-19 Thread Nate DeSimone
"beggining" should be "beginning" Signed-off-by: Nate DeSimone Cc: Marcin Wojtas Cc: Leif Lindholm --- Silicon/Marvell/Applications/SpiTool/SpiFlashCmd.c | 3 ++- Silicon/Marvell/Applications/SpiTool/SpiFlashCmd.uni | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git

[edk2-devel] [edk2-platforms] [PATCH 2/5] Vlv2TbltDevicePkg: Fix spelling errors

2020-05-19 Thread Nate DeSimone
"implemenations" should be "implementations" Signed-off-by: Nate DeSimone Cc: Zailiang Sun Cc: Yi Qian --- .../Vlv2TbltDevicePkg/MonoStatusCode/MonoStatusCode.c| 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git

[edk2-devel] [edk2-platforms] [PATCH 4/5] IntelSiliconPkg: Fix spelling errors

2020-05-19 Thread Nate DeSimone
"implemenations" should be "implementations" "beggining" should be "beginning" Signed-off-by: Nate DeSimone Cc: Ray Ni Cc: Sai Chaganty --- .../IntelSiliconPkg/Library/DxeAslUpdateLib/DxeAslUpdateLib.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[edk2-devel] [edk2-platforms] [PATCH 5/5] KabylakeSiliconPkg: Fix spelling errors

2020-05-19 Thread Nate DeSimone
"implemenations" should be "implementations" "beggining" should be "beginning" Signed-off-by: Nate DeSimone Cc: Chasel Chiu Cc: Sai Chaganty --- .../Library/DxeAslUpdateLib/DxeAslUpdateLib.c | 4 ++-- .../Library/DxeAslUpdateLibNull/DxeAslUpdateLibNull.c | 4 ++-- 2

[edk2-devel] [edk2-platforms] [PATCH 0/5] Intel: Fix spelling errors

2020-05-19 Thread Nate DeSimone
"implemenations" should be "implementations" "beggining" should be "beginning" Signed-off-by: Nate DeSimone Cc: Chasel Chiu Cc: Eric Dong Cc: Liming Gao Cc: Ray Ni Cc: Sai Chaganty Cc: Yi Qian Cc: Zailiang Sun Nate DeSimone (5): MinPlatformPkg: Fix spelling errors Vlv2TbltDevicePkg:

[edk2-devel] [edk2-platforms] [PATCH 1/5] MinPlatformPkg: Fix spelling errors

2020-05-19 Thread Nate DeSimone
"implemenations" should be "implementations" "beggining" should be "beginning" Signed-off-by: Nate DeSimone Cc: Chasel Chiu Cc: Liming Gao Cc: Eric Dong --- .../Acpi/Library/DxeAslUpdateLib/DxeAslUpdateLib.c| 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[edk2-devel] [edk2-platforms] [PATCH 3/5] CoffeeLakeSiliconPkg: Fix spelling errors

2020-05-19 Thread Nate DeSimone
"implemenations" should be "implementations" "beggining" should be "beginning" Signed-off-by: Nate DeSimone Cc: Chasel Chiu Cc: Sai Chaganty --- .../Library/DxeAslUpdateLib/DxeAslUpdateLib.c | 4 ++-- .../Library/DxeAslUpdateLibNull/DxeAslUpdateLibNull.c | 4 ++-- 2

<    1   2