Re: [edk2-devel] [PATCH v5 3/9] UefiCpuPkg/CpuMpPei: Add GDT and IDT migration support (CVE-2019-11098)

On 07/09/20 03:56, Guomin Jiang wrote: > From: Michael Kubacki > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1614 > > Moves the GDT and IDT to permanent memory in a memory discovered > callback. This is done to ensure the GDT and IDT authenticated in > pre-memory is not fetched from

Re: [edk2-devel] [PATCH] SecurityPkg/Tcg2PhysicalPresenceLib: Fix incorrect TCG VER comparision

On 07/09/20 04:46, Gao, Zhichao wrote: > From: Terry Lee > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2697 > > Tcg2PhysicalPresenceLibConstructor set the module variable > mIsTcg2PPVerLowerThan_1_3 with incorrect TCG version comparision. > > Cc: Jiewen Yao > Cc: Jian J Wang > Cc:

Re: [edk2-devel] [PATCH v5 8/9] UefiCpuPkg: Correct some typos.

On 07/09/20 03:56, Guomin Jiang wrote: > Correct some typos. > > Cc: Eric Dong > Cc: Ray Ni > Cc: Laszlo Ersek > Cc: Rahul Kumar > Signed-off-by: Guomin Jiang > --- > UefiCpuPkg/CpuMpPei/CpuMpPei.h| 2 +- >

[edk2-devel] "Error 4000" EDK II Build Issue

Hi all, I am trying to build the EDK II firmware for the MinnowBoard Turbot using Windows, as outlined here. When I try to execute the final command to build the firmware, it gives me an

Re: [edk2-devel] [PATCH v5 2/9] MdeModulePkg/PeiCore: Enable T-RAM evacuation in PeiCore (CVE-2019-11098)

On 07/09/20 03:56, Guomin Jiang wrote: > From: Michael Kubacki > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1614 > > Introduces new changes to PeiCore to move the contents of temporary > RAM visible to the PeiCore to permanent memory. This expands on > pre-existing shadowing support

Re: [edk2-devel] [PATCH v5 4/9] UefiCpuPkg/SecMigrationPei: Add initial PEIM (CVE-2019-11098)

On 07/09/20 03:56, Guomin Jiang wrote: > From: Michael Kubacki > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1614 > > Adds a PEIM that republishes structures produced in SEC. This > is done because SEC modules may not be shadowed in some platforms > due to space constraints or special

Re: [edk2-devel] [PATCH v4 01/15] PcAtChipsetPkg: Add MMIO Support to RTC driver

Hi Ard, Please find my response inline marked [SAMI]. Regards, Sami Mujawar -Original Message- From: Ard Biesheuvel Sent: 07 July 2020 02:17 PM To: Sami Mujawar ; devel@edk2.groups.io Cc: l...@nuviainc.com; ray...@intel.com; Alexandru Elisei ; Andre Przywara ; Matteo Carlini ;

Re: [edk2-devel] [Patch v2 01/16] BaseTools/Python: Allow HOST_APPLICATION to use NULL libraries

Reviewed-by: Bob Feng -Original Message- From: Kinney, Michael D Sent: Thursday, July 9, 2020 12:05 PM To: devel@edk2.groups.io Cc: Feng, Bob C ; Gao, Liming ; Sean Brogan ; Bret Barkelew ; Yao, Jiewen Subject: [Patch v2 01/16] BaseTools/Python: Allow HOST_APPLICATION to use NULL

Re: [edk2-devel] [Patch v2 05/16] MdePkg/Library/BaseLib: Add BaseLib instance for host based unit tests

Mike: New library instance library class should be UnitTestHostBaseLib instead of BaseLib. Thanks Liming > -Original Message- > From: Kinney, Michael D > Sent: Thursday, July 9, 2020 12:05 PM > To: devel@edk2.groups.io > Cc: Gao, Liming ; Sean Brogan > ; Bret Barkelew ; > Yao,

Re: [edk2-devel] [PATCH v4 02/15] ArmVirtPkg: Add Kvmtool RTC Fdt Client Library

Hi Ard, Please find my response inline marked [SAMI]. Regards, Sami Mujawar -Original Message- From: devel@edk2.groups.io On Behalf Of Ard Biesheuvel via groups.io Sent: 07 July 2020 02:20 PM To: Sami Mujawar ; devel@edk2.groups.io Cc: l...@nuviainc.com; ler...@redhat.com; Alexandru

Re: [edk2-devel] [Patch v2 15/16] MdePkg/Library/BaseStackCheckLib: Fix PCD type in INF

Reviewed-by: Liming Gao > -Original Message- > From: Kinney, Michael D > Sent: Thursday, July 9, 2020 12:05 PM > To: devel@edk2.groups.io > Cc: Gao, Liming > Subject: [Patch v2 15/16] MdePkg/Library/BaseStackCheckLib: Fix PCD type in > INF > > Update INF file to use a [Pcd] section

Re: [edk2-devel] [Patch 03/15] MdePkg/BaseCacheMaintenanceLibNull: Add Null instance for host testing

Reviewed-by: Liming Gao > -Original Message- > From: Kinney, Michael D > Sent: Monday, June 15, 2020 8:19 AM > To: devel@edk2.groups.io > Cc: Gao, Liming ; Sean Brogan > ; Bret Barkelew ; > Yao, Jiewen > Subject: [Patch 03/15] MdePkg/BaseCacheMaintenanceLibNull: Add Null instance >

Re: [edk2-devel] [Patch 02/15] MdePkg/BaseCpuLibNull: Add Null version of CpuLib for host testing

Reviewed-by: Liming Gao > -Original Message- > From: Kinney, Michael D > Sent: Monday, June 15, 2020 8:19 AM > To: devel@edk2.groups.io > Cc: Gao, Liming ; Sean Brogan > ; Bret Barkelew ; > Yao, Jiewen > Subject: [Patch 02/15] MdePkg/BaseCpuLibNull: Add Null version of CpuLib for >

[edk2-devel] Cancelled Event: TianoCore Design Meeting - APAC/NAMO - Friday, 10 July 2020 #cal-cancelled

BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:CANCELLED CALSCALE:GREGORIAN BEGIN:VEVENT UID:g7lq.1578029159272351097.u...@groups.io DTSTAMP:20200709T114247Z ORGANIZER;CN=Ray Ni:mailto:ray...@intel.com DTSTART:20200710T013000Z DTEND:20200710T023000Z

Re: [edk2-devel] [edk2-platforms] [PATCH] IntelSiliconPkg: IOMMU generic bug fix

Lorena: I have one minor comment on this patch. The error return status should be EFI_UNSUPPORTED. + return error; ==> return EFI_UNSUPPORTED; Thanks Liming From: De Leon Vazquez, Lorena R Sent: Tuesday, July 7, 2020 1:24 AM To: Gao, Liming ; devel@edk2.groups.io; Lohr, Paul A ; Yao,

Re: [edk2-devel] [Patch 04/15] MdePkg/BaseLib: Break out IA32/X64 GCC inline privileged functions

Mike: Is there the rule to know which function can't be in unit test? And, those functions will be in GccInline.c or GccInlinePriv.c? There is no change in MSFT C source file, because MSFT C source file has been separated as the function level. Right? Thanks Liming > -Original

Re: [edk2-devel] [Patch 04/15] MdePkg/BaseLib: Break out IA32/X64 GCC inline privileged functions

Liming, In order to support host based unit tests, all the code has to be compatible with a user mode process. This means any functions that execute instructions that are not allowed in a user mode process need to be separated out. For the IA32/X64 specific GccInline.c files, the analysis was

[edk2-devel] [edk2-platforms] [PATCH v3 2/2] Platform/NXP:LX2160: Enable support of USB controller

From: Meenakshi Aggarwal - Enable support of USB drives on lx2160 RDB board. - LX2160 has DWC3 controller - Increase FD size to accomodate USB driver. Signed-off-by: Meenakshi Aggarwal --- Silicon/NXP/LX2160A/LX2160A.dsc.inc | 4 Silicon/NXP/NxpQoriqLs.dsc.inc |

[edk2-devel] [edk2-platforms] [PATCH v3 1/2] Silicon/NXP: Add DWC3 USB controller initialization driver

From: Meenakshi Aggarwal Add support of DWC3 controller driver which performs DWC3 controller initialization and register itself as NonDiscoverableMmioDevice Signed-off-by: Meenakshi Aggarwal --- Silicon/NXP/NxpQoriqLs.dec | 5 +

[edk2-devel] [edk2-platforms] [PATCH v3 0/2] Add USB driver support

This patchset implement USB driver for DWC3 controller and enable USB for LX2160A Platform. Changes in v2: - Indentation changes - Incorporated review comments - create EndOfDxe event and initialize USB in EndOfDxe callback function. Changes in v3: -

Re: [edk2-devel] [PATCH v1 1/3] UnitTestFrameworkPkg : BaseTimerLib: Adds a host-based timer Lib

I sent out a new patch series. Not sure, it might be waiting in the -- - Matthew Carlson -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#62316): https://edk2.groups.io/g/devel/message/62316 Mute This Topic:

[edk2-devel] [PATCH v2 1/3] UnitTestFrameworkPkg : BaseTimerLibPosix: Adds a host-based timer Lib

From: Matthew Carlson This adds a host based BaseTimerLib that won't assert. Cc: Michael D Kinney Cc: Sean Brogan Cc: Bret Barkelew Signed-off-by: Matthew Carlson --- UnitTestFrameworkPkg/Library/Posix/BaseTimerLibPosix/TimerLibPosix.c | 125

[edk2-devel] [PATCH v2 0/3] Add Host Based Unit Tests for BaseCryptLib to CryptoPkg

From: Matthew Carlson This turns on Host Based Unit Tests for CryptoPkg, adds the unit test itself, and adds a POSIX BaseTimerLib for unit tests. Matthew Carlson (3): UnitTestFrameworkPkg : BaseTimerLibPosix: Adds a host-based timer Lib CryptoPkg: BaseCryptLib: Add unit tests (Host and

[edk2-devel] [PATCH v2 3/3] AzurePipelines : Pr Gate: Turn on HBUT for CryptoPkg

From: Matthew Carlson Turns on Host Based Unit Tests for CryptoPkg by enabling the target NOOPT in the CI pipeline. Cc: Sean Brogan Cc: Bret Barkelew Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: Matthew Carlson --- .azurepipelines/templates/pr-gate-build-job.yml | 2 +- 1 file

Re: [edk2-devel] [Patch v2 02/16] MdePkg/BaseCpuLibNull: Add Null version of CpuLib for host testing

Reviewed-by: Sean Brogan On 7/8/2020 9:05 PM, Michael D Kinney wrote: REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2798 The services in CpuLib usually generate exceptions in a unit test host application. Provide a Null instance that can be safely used. This Null instance can also be

Re: [edk2-devel] [PATCH V2 0/3] MdeModulePkg/PartitionDxe: Fix the partition check issue

I have tested on the OVMF with linux iso image like Ubuntu, Fedora and RedHat. It can enumerate under the shell and load the grub efi application. Thanks, Zhichao > -Original Message- > From: Wu, Hao A > Sent: Thursday, July 9, 2020 1:04 PM > To: Gao, Zhichao ; devel@edk2.groups.io >

Re: [edk2-devel] [PATCH V2 0/3] MdeModulePkg/PartitionDxe: Fix the partition check issue

> -Original Message- > From: Gao, Zhichao > Sent: Friday, July 10, 2020 8:41 AM > To: Wu, Hao A ; devel@edk2.groups.io > Cc: Ni, Ray ; Laszlo Ersek > Subject: RE: [PATCH V2 0/3] MdeModulePkg/PartitionDxe: Fix the partition > check issue > > I have tested on the OVMF with linux iso image

[edk2-devel] [PATCH 1/1] CryptoPkg/OpensslLib: Upgrade OpenSSL to 1.1.1g

Upgrade openssl to 1.1.1g. the directory have been reorganized, openssl moved crypto/include/internal to include/crypto folder. So we change directory to match the re-organization. Cc: Jian J Wang Cc: Xiaoyu Lu Signed-off-by: GuoMinJ --- CryptoPkg/CryptoPkg.dec | 1 -

Re: [edk2-devel] [Patch v2 01/16] BaseTools/Python: Allow HOST_APPLICATION to use NULL libraries

Reviewed-by: Sean Brogan On 7/8/2020 9:05 PM, Michael D Kinney wrote: REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2797 Update HOST_APPLICATION module type to use NULL library instances. Cc: Bob Feng Cc: Liming Gao Cc: Sean Brogan Cc: Bret Barkelew Cc: Jiewen Yao Signed-off-by:

Re: [edk2-devel] [PATCH] SecurityPkg/Tcg2PhysicalPresenceLib: Fix incorrect TCG VER comparision

This bug is not obeserved by me. But I view the code. The condition is incorrect and it would affect the TCG operation: if (!mIsTcg2PPVerLowerThan_1_3) { if (OperationRequest < TCG2_PHYSICAL_PRESENCE_VENDOR_SPECIFIC_OPERATION) { // // TCG2 PP1.3 spec defined

Re: [edk2-devel] [edk2: PATCH] UefiCpuPkg: To enable X2Apic by default

On 07/10/20 05:31, Ji-yunX Lu wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2845 > Platform shall enable X2APIC by default to meet requirements for interrupt > steering policy on Windows OS. > > Change-Id: Ia9e24bce79c91762c560fa3de6260716939f0b1b > Signed-off-by: Ji-yunX Lu > Cc:

Re: [edk2-devel] [PATCH] SecurityPkg/Tcg2PhysicalPresenceLib: Fix incorrect TCG VER comparision

(+Marc-André, Stefan) On 07/10/20 02:44, Gao, Zhichao wrote: > This bug is not obeserved by me. But I view the code. The condition is > incorrect and it would affect the TCG operation: > if (!mIsTcg2PPVerLowerThan_1_3) { > if (OperationRequest < >

Re: [edk2-devel] [PATCH v5 0/9] Add new feature that evacuate temporary to permanent memory (CVE-2019-11098)

Guomin, On 07/09/20 03:56, Guomin Jiang wrote: > The TOCTOU vulnerability allow that the physical present person to replace > the code with the normal BootGuard check and PCR0 value. > The issue occur when BootGuard measure IBB and access flash code after NEM > disable. > the reason why we

[edk2-devel] [Patch] MdeModulePkg/Variable/RuntimeDxe: Fix return status from Reclaim()

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2844 Update Reclaim() to return the error status from the reclaim operation and not the status of SynchronizeRuntimeVariableCache() that can be EFI_SUCCESS even through the status from reclaim is an error. Without this change, the return status